From 8225d7975a93ce6fdca884ef62b992f8a2596ed5 Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Tue, 7 Sep 2021 11:11:18 +0200
Subject: [PATCH] fixed error when gdtEntryType is empty

---
 frontend/src/components/Transaction.vue       | 76 +++++++++----------
 .../src/components/TransactionCollaps.vue     |  8 +-
 .../AccountOverview/GdtTransactionList.vue    |  1 +
 3 files changed, 43 insertions(+), 42 deletions(-)

diff --git a/frontend/src/components/Transaction.vue b/frontend/src/components/Transaction.vue
index 283ceb6cb..e1884a3e3 100644
--- a/frontend/src/components/Transaction.vue
+++ b/frontend/src/components/Transaction.vue
@@ -1,11 +1,11 @@
 <template>
   <div>
+    
     <div class="list-group">
       <div class="list-group-item gdt-transaction-list-item" v-b-toggle="'a' + date + ''">
         <!-- Icon  -->
         <div class="text-right" style="position: absolute">
-          <b-icon
-            v-if="gdtEntryType"
+          <b-icon          
             :icon="getLinesByType(gdtEntryType).icon"
             :class="getLinesByType(gdtEntryType).iconclasses"
           ></b-icon>
@@ -80,47 +80,46 @@ export default {
     TransactionCollaps,
   },
   props: {
-    amount: { type: Number, default: 0 },
+    amount: { type: Number },
     date: {
-      type: Date,
-      default: function () {
-        return new Date()
-      },
+      type: Date
     },
-    comment: { type: String, default: '' },
-    gdtEntryType: { type: Number, default: 0 },
-    factor: { type: Number, default: 0 },
-    gdt: { type: Number, default: 0 },
+    comment: { type: String },
+    gdtEntryType: { type: Number, default: 1},
+    factor: { type: Number},
+    gdt: { type: Number},
   },
   methods: {
     getLinesByType(givenType) {
-      const linesByType = {
-        1: {
-          icon: 'heart',
-          iconclasses: 'gradido-global-color-accent m-mb-1 font2em',
-          description: 'Beitrag',
-          descriptiontext: this.$n(this.amount, 'decimal') + ' €',
-          credittext: this.$n(this.gdt, 'decimal') + ' GDT',
-        },
-        4: {
-          icon: 'person-check',
-          iconclasses: 'gradido-global-color-accent m-mb-1 font2em',
-          description: 'Geworbenes Mitglied',
-          descriptiontext: '5%',
-          credittext: this.$n(this.amount, 'decimal') + ' GDT',
-        },
-        7: {
-          icon: 'gift',
-          iconclasses: 'gradido-global-color-accent m-mb-1 font2em',
-          description: 'Aktion',
-          descriptiontext: this.comment,
-          credittext: this.$n(this.gdt, 'decimal') + ' GDT',
-        },
-      }
-
-      const type = linesByType[givenType]
-
-      if (type)
+       
+        const linesByType = {
+          1: {
+            icon: 'heart',
+            iconclasses: 'gradido-global-color-accent m-mb-1 font2em',
+            description: 'Beitrag',
+            descriptiontext: this.$n(this.amount, 'decimal') + ' €',
+            credittext: this.$n(this.gdt, 'decimal') + ' GDT',
+          },
+          4: {
+            icon: 'person-check',
+            iconclasses: 'gradido-global-color-accent m-mb-1 font2em',
+            description: 'Geworbenes Mitglied',
+            descriptiontext: '5%',
+            credittext: this.$n(this.amount, 'decimal') + ' GDT',
+          },
+          7: {
+            icon: 'gift',
+            iconclasses: 'gradido-global-color-accent m-mb-1 font2em',
+            description: 'Aktion',
+            descriptiontext: this.comment,
+            credittext: this.$n(this.gdt, 'decimal') + ' GDT',
+          },
+        }
+        
+       
+      const type = linesByType[givenType]       
+      
+      if (type) 
         return {
           icon: type.icon,
           iconclasses: type.iconclasses,
@@ -128,6 +127,7 @@ export default {
           descriptiontext: type.descriptiontext,
           credittext: type.credittext,
         }
+      
     },
   },
 }
diff --git a/frontend/src/components/TransactionCollaps.vue b/frontend/src/components/TransactionCollaps.vue
index 04299fa5f..4c016ea9d 100644
--- a/frontend/src/components/TransactionCollaps.vue
+++ b/frontend/src/components/TransactionCollaps.vue
@@ -23,10 +23,10 @@
 export default {
   name: 'TransactionCollaps',
   props: {
-    amount: { type: Number, default: 0 },
-    gdtEntryType: { type: Number, default: 0 },
-    factor: { type: Number, default: 0 },
-    gdt: { type: Number, default: 0 },
+    amount: { type: Number },
+    gdtEntryType: { type: Number },
+    factor: { type: Number },
+    gdt: { type: Number },
   },
   methods: {
     getLinesByType(givenType) {
diff --git a/frontend/src/views/Pages/AccountOverview/GdtTransactionList.vue b/frontend/src/views/Pages/AccountOverview/GdtTransactionList.vue
index 1aed9a3c9..538fc60bb 100644
--- a/frontend/src/views/Pages/AccountOverview/GdtTransactionList.vue
+++ b/frontend/src/views/Pages/AccountOverview/GdtTransactionList.vue
@@ -17,6 +17,7 @@
         } in transactionsGdt"
         :key="transactionId"
       >
+ 
         <transaction
           :amount="amount"
           :date="date"