From daeb0ed32c3f0c536a9e5750075ab6119af4ccfc Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Tue, 30 Nov 2021 14:58:47 +0100
Subject: [PATCH 1/2] Change create method from query to mutation.

---
 admin/src/components/CreationFormular.vue     |  4 ++--
 admin/src/graphql/createPendingCreation.js    | 10 ++++++++--
 backend/src/graphql/resolver/AdminResolver.ts |  4 ++--
 3 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/admin/src/components/CreationFormular.vue b/admin/src/components/CreationFormular.vue
index 2f7d68c4c..5d29c6fcb 100644
--- a/admin/src/components/CreationFormular.vue
+++ b/admin/src/components/CreationFormular.vue
@@ -270,8 +270,8 @@ export default {
           })
         } else {
           this.$apollo
-            .query({
-              query: createPendingCreation,
+            .mutate({
+              mutation: createPendingCreation,
               variables: this.submitObj,
             })
             .then((result) => {
diff --git a/admin/src/graphql/createPendingCreation.js b/admin/src/graphql/createPendingCreation.js
index a6618e356..72c3249de 100644
--- a/admin/src/graphql/createPendingCreation.js
+++ b/admin/src/graphql/createPendingCreation.js
@@ -1,11 +1,17 @@
 import gql from 'graphql-tag'
 
 export const createPendingCreation = gql`
-  query ($email: String!, $amount: Int!, $note: String!, $creationDate: String!, $moderator: Int!) {
+  mutation (
+    $email: String!
+    $amount: Int!
+    $memo: String!
+    $creationDate: String!
+    $moderator: Int!
+  ) {
     createPendingCreation(
       email: $email
       amount: $amount
-      note: $note
+      memo: $memo
       creationDate: $creationDate
       moderator: $moderator
     )
diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 4c9cb33f8..f3c9d1516 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -1,4 +1,4 @@
-import { Resolver, Query, Arg, Args, Authorized } from 'type-graphql'
+import { Resolver, Query, Arg, Args, Authorized, Mutation } from 'type-graphql'
 import { getCustomRepository, Raw } from 'typeorm'
 import { UserAdmin } from '../model/UserAdmin'
 import { LoginUserRepository } from '../../typeorm/repository/LoginUser'
@@ -29,7 +29,7 @@ export class AdminResolver {
     return users
   }
 
-  @Query(() => [Number])
+  @Mutation(() => [Number])
   async createPendingCreation(
     @Args() { email, amount, memo, creationDate, moderator }: CreatePendingCreationArgs,
   ): Promise<number[]> {

From 0e592fd353c435b5194857a0b02baae8258ebcc2 Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Wed, 1 Dec 2021 09:22:08 +0100
Subject: [PATCH 2/2] Added some tests and reduce coverage since we removed
 comments.

---
 .github/workflows/test.yml |  2 +-
 admin/src/main.test.js     | 18 ++++++++++++------
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 66fc1c9f5..acff97d0e 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -441,7 +441,7 @@ jobs:
           report_name: Coverage Admin Interface
           type: lcov
           result_path: ./coverage/lcov.info
-          min_coverage: 52
+          min_coverage: 50
           token: ${{ github.token }}
 
   ##############################################################################
diff --git a/admin/src/main.test.js b/admin/src/main.test.js
index c639593d6..bf3df3799 100644
--- a/admin/src/main.test.js
+++ b/admin/src/main.test.js
@@ -3,12 +3,14 @@ import './main'
 import CONFIG from './config'
 
 import Vue from 'vue'
+import VueApollo from 'vue-apollo'
 import Vuex from 'vuex'
 import VueI18n from 'vue-i18n'
 import { BootstrapVue, IconsPlugin } from 'bootstrap-vue'
 import moment from 'vue-moment'
 
 jest.mock('vue')
+jest.mock('vue-apollo')
 jest.mock('vuex')
 jest.mock('vue-i18n')
 jest.mock('vue-moment')
@@ -55,6 +57,10 @@ describe('main', () => {
     expect(InMemoryCache).toBeCalled()
   })
 
+  it('calls the VueApollo', () => {
+    expect(VueApollo).toBeCalled()
+  })
+
   it('calls Vue', () => {
     expect(Vue).toBeCalled()
   })
@@ -63,16 +69,16 @@ describe('main', () => {
     expect(VueI18n).toBeCalled()
   })
 
-  it.skip('calls BootstrapVue', () => {
-    expect(BootstrapVue).toBeCalled()
+  it('calls BootstrapVue', () => {
+    expect(Vue.use).toBeCalledWith(BootstrapVue)
   })
 
-  it.skip('calls IconsPlugin', () => {
-    expect(IconsPlugin).toBeCalled()
+  it('calls IconsPlugin', () => {
+    expect(Vue.use).toBeCalledWith(IconsPlugin)
   })
 
-  it.skip('calls Moment', () => {
-    expect(moment).toBeCalled()
+  it('calls Moment', () => {
+    expect(Vue.use).toBeCalledWith(moment)
   })
 
   it.skip('creates a store', () => {