From 90dfd1063ba5915d90557a74ce7f849486732537 Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Fri, 14 Oct 2022 13:31:34 +0200
Subject: [PATCH] pattern const added

---
 .../ContributionMessagesFormular.vue                |  4 +++-
 .../ContributionMessagesFormular.vue                |  4 +++-
 .../components/Contributions/ContributionForm.vue   | 13 +++++++------
 3 files changed, 13 insertions(+), 8 deletions(-)

diff --git a/admin/src/components/ContributionMessages/ContributionMessagesFormular.vue b/admin/src/components/ContributionMessages/ContributionMessagesFormular.vue
index 11492d53c..c01ce8cb5 100644
--- a/admin/src/components/ContributionMessages/ContributionMessagesFormular.vue
+++ b/admin/src/components/ContributionMessages/ContributionMessagesFormular.vue
@@ -25,6 +25,8 @@
 <script>
 import { adminCreateContributionMessage } from '@/graphql/adminCreateContributionMessage'
 
+const STRIP_HTML_PATTERN = /(<([^>]+)>)/gi
+
 export default {
   name: 'ContributionMessagesFormular',
   props: {
@@ -66,7 +68,7 @@ export default {
   },
   computed: {
     clearTextFromHtml() {
-      return this.form.text.replace(/(<([^>]+)>)/gi, '')
+      return this.form.text.replace(STRIP_HTML_PATTERN, '')
     },
     disabled() {
       if (this.form.text !== '') {
diff --git a/frontend/src/components/ContributionMessages/ContributionMessagesFormular.vue b/frontend/src/components/ContributionMessages/ContributionMessagesFormular.vue
index 56732961c..a5ab81112 100644
--- a/frontend/src/components/ContributionMessages/ContributionMessagesFormular.vue
+++ b/frontend/src/components/ContributionMessages/ContributionMessagesFormular.vue
@@ -25,6 +25,8 @@
 <script>
 import { createContributionMessage } from '../../graphql/mutations.js'
 
+const STRIP_HTML_PATTERN = /(<([^>]+)>)/gi
+
 export default {
   name: 'ContributionMessagesFormular',
   props: {
@@ -66,7 +68,7 @@ export default {
   },
   computed: {
     clearTextFromHtml() {
-      return this.form.text.replace(/(<([^>]+)>)/gi, '')
+      return this.form.text.replace(STRIP_HTML_PATTERN, '')
     },
     disabled() {
       if (this.form.text !== '') {
diff --git a/frontend/src/components/Contributions/ContributionForm.vue b/frontend/src/components/Contributions/ContributionForm.vue
index 2c0a9f452..11671b8d0 100644
--- a/frontend/src/components/Contributions/ContributionForm.vue
+++ b/frontend/src/components/Contributions/ContributionForm.vue
@@ -87,6 +87,9 @@
   </div>
 </template>
 <script>
+const PATTERN_STRIP_HTML = /(<([^>]+)>)/gi
+const PATTERN_NON_DIGIT = /\D/g
+
 export default {
   name: 'ContributionForm',
   props: {
@@ -98,17 +101,15 @@ export default {
       minlength: 5,
       maxlength: 255,
       maximalDate: new Date(),
-      form: this.value, // includes 'id',
-      patternStripHtml: new RegExp(/(<([^>]+)>)/gi),
-      patternNonDigit: new RegExp(/\D/g),
+      form: this.value, // includes 'id'
     }
   },
   methods: {
     numberFormat(value) {
-      return value.replace(this.patternNonDigit, '')
+      return value.replace(PATTERN_NON_DIGIT, '')
     },
     submit() {
-      this.form.amount = this.form.amount.replace(this.patternNonDigit, '')
+      this.form.amount = this.form.amount.replace(PATTERN_NON_DIGIT, '')
       // spreading is needed for testing
       this.form.memo = this.memoStripHtml
       this.$emit(this.form.id ? 'update-contribution' : 'set-contribution', { ...this.form })
@@ -131,7 +132,7 @@ export default {
   },
   computed: {
     memoStripHtml() {
-      return this.form.memo.replace(this.patternStripHtml)
+      return this.form.memo.replace(PATTERN_STRIP_HTML, '')
     },
     minimalDate() {
       // sets the date to the 1st of the previous month