From 95e937f6e10310de620b34c7e0c6418dadcad71e Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Wed, 8 Sep 2021 12:19:19 +0200
Subject: [PATCH] fix test

---
 frontend/src/components/Transaction.spec.js   | 11 +++++++-
 frontend/src/components/Transaction.vue       | 26 +++++--------------
 ...ps.spec.js => TransactionCollapse.spec.js} |  6 ++---
 ...ionCollaps.vue => TransactionCollapse.vue} | 18 +++----------
 4 files changed, 24 insertions(+), 37 deletions(-)
 rename frontend/src/components/{TransactionCollaps.spec.js => TransactionCollapse.spec.js} (78%)
 rename frontend/src/components/{TransactionCollaps.vue => TransactionCollapse.vue} (83%)

diff --git a/frontend/src/components/Transaction.spec.js b/frontend/src/components/Transaction.spec.js
index e5e0c89f0..d78af1e76 100644
--- a/frontend/src/components/Transaction.spec.js
+++ b/frontend/src/components/Transaction.spec.js
@@ -20,8 +20,17 @@ describe('Transaction', () => {
     },
   }
 
+  const propsData = {
+    amount: 100,
+    gdt: 110,
+    factor: 22,
+    comment: '',
+    date: '2020-04-10T13:28:00+00:00',
+    gdtEntryType: 4,
+  }
+
   const Wrapper = () => {
-    return mount(Transaction, { localVue, mocks })
+    return mount(Transaction, { localVue, mocks, propsData })
   }
 
   describe('mount', () => {
diff --git a/frontend/src/components/Transaction.vue b/frontend/src/components/Transaction.vue
index faf347a41..ce5b225d9 100644
--- a/frontend/src/components/Transaction.vue
+++ b/frontend/src/components/Transaction.vue
@@ -60,29 +60,27 @@
 
       <!-- collaps trancaction info-->
       <b-collapse :id="'a' + date + ''" class="pb-4">
-        <transaction-collaps
+        <transaction-collapse
           :amount="amount"
           :gdtEntryType="gdtEntryType"
           :factor="factor"
           :gdt="gdt"
-        ></transaction-collaps>
+        ></transaction-collapse>
       </b-collapse>
     </div>
   </div>
 </template>
 <script>
-import TransactionCollaps from '../components/TransactionCollaps.vue'
+import TransactionCollapse from './TransactionCollapse.vue'
 
 export default {
   name: 'Transaction',
   components: {
-    TransactionCollaps,
+    TransactionCollapse,
   },
   props: {
     amount: { type: Number },
-    date: {
-      type: Date,
-    },
+    date: { type: String },
     comment: { type: String },
     gdtEntryType: { type: Number, default: 1 },
     factor: { type: Number },
@@ -116,18 +114,8 @@ export default {
 
       const type = linesByType[givenType]
 
-      if (type)
-        return {
-          icon: type.icon,
-          iconclasses: type.iconclasses,
-          description: type.description,
-          descriptiontext: type.descriptiontext,
-          credittext: type.credittext,
-        }
-      this.throwError('no lines for this type')
-    },
-    throwError(msg) {
-      throw new Error(msg)
+      if (type) return type
+      throw new Error('no lines for this type')
     },
   },
 }
diff --git a/frontend/src/components/TransactionCollaps.spec.js b/frontend/src/components/TransactionCollapse.spec.js
similarity index 78%
rename from frontend/src/components/TransactionCollaps.spec.js
rename to frontend/src/components/TransactionCollapse.spec.js
index edb5c5dd7..a4345dec0 100644
--- a/frontend/src/components/TransactionCollaps.spec.js
+++ b/frontend/src/components/TransactionCollapse.spec.js
@@ -1,11 +1,11 @@
 import { mount } from '@vue/test-utils'
-import TransactionCollaps from './TransactionCollaps'
+import TransactionCollapse from './TransactionCollapse'
 
 const localVue = global.localVue
 
 const toastErrorMock = jest.fn()
 
-describe('TransactionCollaps', () => {
+describe('TransactionCollapse', () => {
   let wrapper
 
   const mocks = {
@@ -21,7 +21,7 @@ describe('TransactionCollaps', () => {
   }
 
   const Wrapper = () => {
-    return mount(TransactionCollaps, { localVue, mocks })
+    return mount(TransactionCollapse, { localVue, mocks })
   }
 
   describe('mount', () => {
diff --git a/frontend/src/components/TransactionCollaps.vue b/frontend/src/components/TransactionCollapse.vue
similarity index 83%
rename from frontend/src/components/TransactionCollaps.vue
rename to frontend/src/components/TransactionCollapse.vue
index 4148c6d56..6d6acfdc5 100644
--- a/frontend/src/components/TransactionCollaps.vue
+++ b/frontend/src/components/TransactionCollapse.vue
@@ -21,10 +21,10 @@
 </template>
 <script>
 export default {
-  name: 'transaction-collaps',
+  name: 'TransactionCollapse',
   props: {
     amount: { type: Number },
-    gdtEntryType: { type: Number },
+    gdtEntryType: { type: Number, default: 1 },
     factor: { type: Number },
     gdt: { type: Number },
   },
@@ -68,18 +68,8 @@ export default {
 
       const type = linesByType[givenType]
 
-      if (type)
-        return {
-          headline: type.headline,
-          first: type.first,
-          firstMath: type.firstMath,
-          second: type.second,
-          secondMath: type.secondMath,
-        }
-      this.throwError('no additional transaction info for this type')
-    },
-    throwError(msg) {
-      throw new Error(msg)
+      if (type) return type
+      throw new Error('no additional transaction info for this type')
     },
   },
 }