From 9953945bb5f5fb0327da0fb16a24f8e248f27384 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Sat, 2 Oct 2021 12:34:40 +0200
Subject: [PATCH] refactor balance resolver code

---
 .../src/graphql/resolvers/BalanceResolver.ts  | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/backend/src/graphql/resolvers/BalanceResolver.ts b/backend/src/graphql/resolvers/BalanceResolver.ts
index 4c83bbbcd..642f32975 100644
--- a/backend/src/graphql/resolvers/BalanceResolver.ts
+++ b/backend/src/graphql/resolvers/BalanceResolver.ts
@@ -20,23 +20,23 @@ export class BalanceResolver {
 
     const userEntity = await userRepository.findByPubkeyHex(context.pubKey)
     const balanceEntity = await balanceRepository.findByUser(userEntity.id)
-    let balance: Balance
     const now = new Date()
-    if (balanceEntity) {
-      balance = new Balance({
-        balance: roundFloorFrom4(balanceEntity.amount),
-        decay: roundFloorFrom4(
-          await calculateDecay(balanceEntity.amount, balanceEntity.recordDate, now),
-        ),
-        decay_date: now.toString(),
-      })
-    } else {
-      balance = new Balance({
+
+    // No balance found
+    if (!balanceEntity) {
+      return new Balance({
         balance: 0,
         decay: 0,
         decay_date: now.toString(),
       })
     }
-    return balance
+
+    return new Balance({
+      balance: roundFloorFrom4(balanceEntity.amount),
+      decay: roundFloorFrom4(
+        await calculateDecay(balanceEntity.amount, balanceEntity.recordDate, now),
+      ),
+      decay_date: now.toString(),
+    })
   }
 }