IT4Change/gradido
3
0
Fork 0
mirror of https://github.com/IT4Change/gradido.git synced 2025-12-13 07:45:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Move contribution, user and moderator search in the first try block to lock the database.

Browse Source
This commit is contained in:
elweyn 2023-01-13 11:35:33 +01:00
parent df4e2b419a
commit 9d8c026617
1 changed files with 3 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
backend/src/graphql/resolver/ContributionResolver.ts
View File

@ -557,37 +557,6 @@ export class ContributionResolver {
@Arg('id', () => Int) id: number,
@Ctx() context: Context,
): Promise<boolean> {
const clientTimezoneOffset = getClientTimezoneOffset(context)
const contribution = await DbContribution.findOne(id)
if (!contribution) {
logger.error(`Contribution not found for given id: ${id}`)
throw new Error('Contribution not found to given id.')
}
if (contribution.contributionStatus === 'DENIED') {
logger.error(`Contribution state (${contribution.contributionStatus}) can't be confirmed`)
throw new Error("Contribution state can't be confirmed")
}
const moderatorUser = getUser(context)
if (moderatorUser.id === contribution.userId) {
logger.error('Moderator can not confirm own contribution')
throw new Error('Moderator can not confirm own contribution')
}
const user = await DbUser.findOneOrFail(
{ id: contribution.userId },
{ withDeleted: true, relations: ['emailContact'] },
)
if (user.deletedAt) {
logger.error('This user was deleted. Cannot confirm a contribution.')
throw new Error('This user was deleted. Cannot confirm a contribution.')
}
const creations = await getUserCreation(contribution.userId, clientTimezoneOffset, false)
validateContribution(
creations,
contribution.amount,
contribution.contributionDate,
clientTimezoneOffset,
)
// acquire lock
const releaseLock = await TRANSACTIONS_LOCK.acquire()
@ -598,9 +567,9 @@ export class ContributionResolver {
logger.error(`Contribution not found for given id: ${id}`)
throw new Error('Contribution not found to given id.')
}
if (contribution.confirmedAt) {
logger.error(`Contribution already confirmd: ${id}`)
throw new Error('Contribution already confirmd.')
if (contribution.contributionStatus === 'DENIED') {
logger.error(`Contribution state (${contribution.contributionStatus}) can't be confirmed`)
throw new Error("Contribution state can't be confirmed")
}
const moderatorUser = getUser(context)
if (moderatorUser.id === contribution.userId) {