From a21e5676bcc99c464dc4d435f63fbfcdd390baa8 Mon Sep 17 00:00:00 2001
From: ogerly <landmatrosen@googlemail.com>
Date: Mon, 10 May 2021 10:49:49 +0200
Subject: [PATCH] fix extra table-transactions footer

---
 frontend/src/views/Pages/AccountOverview.vue    |  3 +++
 .../views/Pages/AccountOverview/GddStatus.vue   |  4 ++--
 .../views/Pages/AccountOverview/GddTable.vue    |  9 ++-------
 .../Pages/AccountOverview/GddTableFooter.vue    | 17 +++++++++++++++++
 .../views/Pages/UserProfileTransactionList.vue  |  3 ---
 5 files changed, 24 insertions(+), 12 deletions(-)
 create mode 100644 frontend/src/views/Pages/AccountOverview/GddTableFooter.vue

diff --git a/frontend/src/views/Pages/AccountOverview.vue b/frontend/src/views/Pages/AccountOverview.vue
index d41e7de56..2d5047d8c 100644
--- a/frontend/src/views/Pages/AccountOverview.vue
+++ b/frontend/src/views/Pages/AccountOverview.vue
@@ -19,6 +19,7 @@
         :transactionCount="transactionCount"
         @update-transactions="updateTransactions"
       />
+      <gdd-table-footer :transactionCount="transactionCount" />
     </b-container>
   </div>
 </template>
@@ -26,6 +27,7 @@
 import GddStatus from './AccountOverview/GddStatus.vue'
 import GddSend from './AccountOverview/GddSend.vue'
 import GddTable from './AccountOverview/GddTable.vue'
+import GddTableFooter from './AccountOverview/GddTableFooter.vue'
 
 export default {
   name: 'Overview',
@@ -47,6 +49,7 @@ export default {
     GddStatus,
     GddSend,
     GddTable,
+    GddTableFooter,
   },
   methods: {
     toggleShowList(bool) {
diff --git a/frontend/src/views/Pages/AccountOverview/GddStatus.vue b/frontend/src/views/Pages/AccountOverview/GddStatus.vue
index 96267e335..8698d1fdc 100644
--- a/frontend/src/views/Pages/AccountOverview/GddStatus.vue
+++ b/frontend/src/views/Pages/AccountOverview/GddStatus.vue
@@ -1,7 +1,7 @@
 <template>
   <div>
     <b-row>
-      <b-col col="6">
+      <b-col>
         <stats-card
           type="gradient-red"
           sub-title="balance_gdd"
@@ -11,7 +11,7 @@
           {{ $n(balance) }} GDD
         </stats-card>
       </b-col>
-      <b-col col="6">
+      <b-col>
         <stats-card
           type="gradient-orange"
           sub-title="balance_gdt"
diff --git a/frontend/src/views/Pages/AccountOverview/GddTable.vue b/frontend/src/views/Pages/AccountOverview/GddTable.vue
index c60e4013b..e4d5fcb77 100644
--- a/frontend/src/views/Pages/AccountOverview/GddTable.vue
+++ b/frontend/src/views/Pages/AccountOverview/GddTable.vue
@@ -88,15 +88,10 @@
           </b-card>
         </b-collapse>
       </b-list-group-item>
-      <b-list-group-item v-show="this.$route.path == '/overview'">
-        <b-alert v-if="transactions.length === 0" show variant="secondary">
+      <b-list-group-item v-show="transactionCount === 0">
+        <b-alert show variant="secondary">
           <span class="alert-text">{{ $t('transaction.nullTransactions') }}</span>
         </b-alert>
-        <router-link
-          v-else-if="transactions.length > 5"
-          to="/transactions"
-          v-html="$t('transaction.show_all', { count: transactionCount })"
-        ></router-link>
       </b-list-group-item>
     </b-list-group>
   </div>
diff --git a/frontend/src/views/Pages/AccountOverview/GddTableFooter.vue b/frontend/src/views/Pages/AccountOverview/GddTableFooter.vue
new file mode 100644
index 000000000..a8b7bd8ae
--- /dev/null
+++ b/frontend/src/views/Pages/AccountOverview/GddTableFooter.vue
@@ -0,0 +1,17 @@
+<template>
+  <b-list-group>
+    <b-list-group-item v-show="transactionCount > 5">
+      <router-link
+        to="/transactions"
+        v-html="$t('transaction.show_all', { count: transactionCount })"
+      ></router-link>
+    </b-list-group-item>
+  </b-list-group>
+</template>
+<script>
+export default {
+  props: {
+    transactionCount: { type: Number, default: 0 },
+  },
+}
+</script>
diff --git a/frontend/src/views/Pages/UserProfileTransactionList.vue b/frontend/src/views/Pages/UserProfileTransactionList.vue
index 21668fd06..e7c35a731 100644
--- a/frontend/src/views/Pages/UserProfileTransactionList.vue
+++ b/frontend/src/views/Pages/UserProfileTransactionList.vue
@@ -15,9 +15,6 @@
           />
         </b-col>
       </b-row>
-      <b-row class="text-center mb-6" v-if="transactions.length == 0">
-        <b-col class="h2">{{ $t('transaction.nullTransactions') }}</b-col>
-      </b-row>
     </b-container>
   </div>
 </template>