From b580f8755da0a0034f58eb6b8871bab68c366d3e Mon Sep 17 00:00:00 2001
From: elweyn <heine.hannes@gmail.com>
Date: Mon, 4 Jul 2022 07:40:10 +0200
Subject: [PATCH] Refactor updateCreations.

---
 backend/src/graphql/resolver/AdminResolver.ts         | 11 +----------
 .../src/graphql/resolver/util/isContributionValid.ts  | 11 +++++++++++
 2 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/backend/src/graphql/resolver/AdminResolver.ts b/backend/src/graphql/resolver/AdminResolver.ts
index 5476fd8a1..962c13e9b 100644
--- a/backend/src/graphql/resolver/AdminResolver.ts
+++ b/backend/src/graphql/resolver/AdminResolver.ts
@@ -52,6 +52,7 @@ import {
   getUserCreations,
   isContributionValid,
   isStartEndDateValid,
+  updateCreations,
 } from './util/isContributionValid'
 import {
   CONTRIBUTIONLINK_MEMO_MAX_CHARS,
@@ -688,13 +689,3 @@ export class AdminResolver {
     return new ContributionLink(dbContributionLink)
   }
 }
-
-function updateCreations(creations: Decimal[], contribution: Contribution): Decimal[] {
-  const index = getCreationIndex(contribution.contributionDate.getMonth())
-
-  if (index < 0) {
-    throw new Error('You cannot create GDD for a month older than the last three months.')
-  }
-  creations[index] = creations[index].plus(contribution.amount.toString())
-  return creations
-}
diff --git a/backend/src/graphql/resolver/util/isContributionValid.ts b/backend/src/graphql/resolver/util/isContributionValid.ts
index 0a9b57170..552370f4c 100644
--- a/backend/src/graphql/resolver/util/isContributionValid.ts
+++ b/backend/src/graphql/resolver/util/isContributionValid.ts
@@ -1,6 +1,7 @@
 import { TransactionTypeId } from '@/graphql/enum/TransactionTypeId'
 import { backendLogger as logger } from '@/server/logger'
 import { getConnection } from '@dbTools/typeorm'
+import { Contribution } from '@entity/Contribution'
 import Decimal from 'decimal.js-light'
 import { FULL_CREATION_AVAILABLE, MAX_CREATION_AMOUNT } from '../const/const'
 
@@ -117,3 +118,13 @@ export const isStartEndDateValid = (
     throw new Error(`The value of validFrom must before or equals the validTo!`)
   }
 }
+
+export const updateCreations = (creations: Decimal[], contribution: Contribution): Decimal[] => {
+  const index = getCreationIndex(contribution.contributionDate.getMonth())
+
+  if (index < 0) {
+    throw new Error('You cannot create GDD for a month older than the last three months.')
+  }
+  creations[index] = creations[index].plus(contribution.amount.toString())
+  return creations
+}