From b68fab72ccd3b777aeefb8a87c2ec1f41c036024 Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Mon, 21 Mar 2022 14:01:41 +0100
Subject: [PATCH] review from ulf and hannes

---
 frontend/src/components/GddSend/TransactionForm.vue           | 2 +-
 .../src/components/LinkInformations/RedeemInformation.vue     | 4 ++--
 frontend/src/components/LinkInformations/RedeemLoggedOut.vue  | 2 +-
 .../src/components/LinkInformations/RedeemSelfCreator.vue     | 2 +-
 frontend/src/components/LinkInformations/RedeemValid.vue      | 2 +-
 frontend/src/locales/de.json                                  | 2 +-
 frontend/src/locales/en.json                                  | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/frontend/src/components/GddSend/TransactionForm.vue b/frontend/src/components/GddSend/TransactionForm.vue
index 845e749cc..ec4aff4d3 100644
--- a/frontend/src/components/GddSend/TransactionForm.vue
+++ b/frontend/src/components/GddSend/TransactionForm.vue
@@ -19,7 +19,7 @@
             <div class="mt-4" v-show="selected === sendTypes.link">
               <h2 class="alert-heading">{{ $t('gdd_per_link.header') }}</h2>
               <div>
-                {{ $t('gdd_per_link.sentence_1') }}
+                {{ $t('gdd_per_link.choose-amount') }}
               </div>
             </div>
 
diff --git a/frontend/src/components/LinkInformations/RedeemInformation.vue b/frontend/src/components/LinkInformations/RedeemInformation.vue
index 71c0b27ad..bdc17db9a 100644
--- a/frontend/src/components/LinkInformations/RedeemInformation.vue
+++ b/frontend/src/components/LinkInformations/RedeemInformation.vue
@@ -2,7 +2,7 @@
   <div class="redeem-information">
     <b-jumbotron bg-variant="muted" text-variant="dark" border-variant="info">
       <h1>
-        {{ user.firstName }}
+        {{ firstName }}
         {{ $t('transaction-link.send_you') }} {{ amount | GDD }}
       </h1>
       <b>{{ memo }}</b>
@@ -13,7 +13,7 @@
 export default {
   name: 'RedeemInformation',
   props: {
-    user: { type: Object, required: true },
+    firstName: { type: String, required: true },
     amount: { type: String, required: true },
     memo: { type: String, required: true, default: '' },
   },
diff --git a/frontend/src/components/LinkInformations/RedeemLoggedOut.vue b/frontend/src/components/LinkInformations/RedeemLoggedOut.vue
index 15d9a985b..20b75869a 100644
--- a/frontend/src/components/LinkInformations/RedeemLoggedOut.vue
+++ b/frontend/src/components/LinkInformations/RedeemLoggedOut.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="redeem-logged-out">
-    <redeem-information :user="user" :amount="amount" :memo="memo" />
+    <redeem-information :firstName="user.firstName" :amount="amount" :memo="memo" />
 
     <b-jumbotron>
       <div class="mb-6">
diff --git a/frontend/src/components/LinkInformations/RedeemSelfCreator.vue b/frontend/src/components/LinkInformations/RedeemSelfCreator.vue
index ffcdc2543..5a4928690 100644
--- a/frontend/src/components/LinkInformations/RedeemSelfCreator.vue
+++ b/frontend/src/components/LinkInformations/RedeemSelfCreator.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="redeem-self-creator">
-    <redeem-information :user="user" :amount="amount" :memo="memo" />
+    <redeem-information :firstName="user.firstName" :amount="amount" :memo="memo" />
 
     <b-jumbotron>
       <div class="mb-3 text-center">
diff --git a/frontend/src/components/LinkInformations/RedeemValid.vue b/frontend/src/components/LinkInformations/RedeemValid.vue
index 96af8e3b2..301afad69 100644
--- a/frontend/src/components/LinkInformations/RedeemValid.vue
+++ b/frontend/src/components/LinkInformations/RedeemValid.vue
@@ -1,6 +1,6 @@
 <template>
   <div class="redeem-valid">
-    <redeem-information :user="user" :amount="amount" :memo="memo" />
+    <redeem-information :firstName="user.firstName" :amount="amount" :memo="memo" />
     <b-jumbotron>
       <div class="mb-3 text-center">
         <b-button variant="primary" @click="$emit('redeem-link', amount)" size="lg">
diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index fc220a79f..39245be9d 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -116,7 +116,7 @@
     "redeemed": "Erfolgreich eingelöst! Deinem Konto wurden {n} GDD gutgeschrieben.",
     "successfully-redeemed": "Erfolgreich eingelöst!",
     "redeemed-at": "Der Link wurde bereits am {date} eingelöst.",
-    "sentence_1": "Wähle einen Betrag aus, welchen du per Link versenden möchtest. Du kannst auch noch eine Nachricht eintragen. Beim Klick „jetzt generieren“ wird ein Link erstellt, den du versenden kannst.",
+    "choose-amount": "Wähle einen Betrag aus, welchen du per Link versenden möchtest. Du kannst auch noch eine Nachricht eintragen. Beim Klick „jetzt generieren“ wird ein Link erstellt, den du versenden kannst.",
     "to-login": "Log dich ein",
     "to-register": "Registriere ein neues Konto"
   },
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index 28d7c15ab..bc21452b3 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -116,7 +116,7 @@
     "redeemed": "Successfully redeemed! Your account has been credited with {n} GDD.",
     "redeemed-at": "The link was already redeemed on {date}.",
     "successfully-redeemed": "Successfully redeemed!",
-    "sentence_1": "Select an amount that you would like to send via link. You can also enter a message. Click 'Generate now' to create a link that you can share.",
+    "choose-amount": "Select an amount that you would like to send via link. You can also enter a message. Click 'Generate now' to create a link that you can share.",
     "to-login": "Log in",
     "to-register": "Register a new account"
   },