From 79bede5e35cb8f01e67f2196b8f229aad9d0367c Mon Sep 17 00:00:00 2001 From: elweyn Date: Fri, 24 Mar 2023 09:33:52 +0100 Subject: [PATCH 1/3] feat(backend): add fields to subscriber --- backend/src/apis/KlicktippController.ts | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/backend/src/apis/KlicktippController.ts b/backend/src/apis/KlicktippController.ts index a291bb945..bb3e79831 100644 --- a/backend/src/apis/KlicktippController.ts +++ b/backend/src/apis/KlicktippController.ts @@ -79,3 +79,16 @@ export const getKlicktippTagMap = async () => { } return '' } + +export const addFieldsToSubscriber = async ( + email: string, + fields: any = {}, + newemail = '', + newsmsnumber = '', +) => { + const isLogin = await loginKlicktippUser() + if (isLogin) { + const subscriberId = await klicktippConnector.subscriberSearch(email) + return await klicktippConnector.subscriberUpdate(subscriberId, fields, newemail, newsmsnumber) + } +} From 20a80d56a68e31a8b16ce076392a74b014ab6d01 Mon Sep 17 00:00:00 2001 From: elweyn Date: Tue, 4 Apr 2023 09:09:37 +0200 Subject: [PATCH 2/3] Add callCklickTippAPI to addFieldsToSubscriber --- backend/src/apis/KlicktippController.ts | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/backend/src/apis/KlicktippController.ts b/backend/src/apis/KlicktippController.ts index d94b4e132..91c92c855 100644 --- a/backend/src/apis/KlicktippController.ts +++ b/backend/src/apis/KlicktippController.ts @@ -143,9 +143,15 @@ export const addFieldsToSubscriber = async ( newemail = '', newsmsnumber = '', ) => { - const isLogin = await loginKlicktippUser() - if (isLogin) { - const subscriberId = await klicktippConnector.subscriberSearch(email) - return await klicktippConnector.subscriberUpdate(subscriberId, fields, newemail, newsmsnumber) - } + return callKlickTippAPI( + async ({ email, fields, newemail, newsmsnumber }) => { + const isLogin = await loginKlicktippUser() + if (isLogin) { + const subscriberId = await klicktippConnector.subscriberSearch(email) + return klicktippConnector.subscriberUpdate(subscriberId, fields, newemail, newsmsnumber) + } + throw new LogError(`Could not add fields (${fields}) to subscriber ${email}`) + }, + { email, fields, newemail, newsmsnumber }, + ) } From 070f84f21b2a1605f07d890d397a59481eca86f5 Mon Sep 17 00:00:00 2001 From: elweyn Date: Tue, 4 Apr 2023 19:47:50 +0200 Subject: [PATCH 3/3] Remove callKlickTippAPI method. --- backend/src/apis/KlicktippController.ts | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/backend/src/apis/KlicktippController.ts b/backend/src/apis/KlicktippController.ts index 710e2c611..6d59eaefc 100644 --- a/backend/src/apis/KlicktippController.ts +++ b/backend/src/apis/KlicktippController.ts @@ -97,15 +97,11 @@ export const addFieldsToSubscriber = async ( newemail = '', newsmsnumber = '', ) => { - return callKlickTippAPI( - async ({ email, fields, newemail, newsmsnumber }) => { - const isLogin = await loginKlicktippUser() - if (isLogin) { - const subscriberId = await klicktippConnector.subscriberSearch(email) - return klicktippConnector.subscriberUpdate(subscriberId, fields, newemail, newsmsnumber) - } - throw new LogError(`Could not add fields (${fields}) to subscriber ${email}`) - }, - { email, fields, newemail, newsmsnumber }, - ) + if (!CONFIG.KLICKTIPP) return true + const isLogin = await loginKlicktippUser() + if (isLogin) { + const subscriberId = await klicktippConnector.subscriberSearch(email) + return klicktippConnector.subscriberUpdate(subscriberId, fields, newemail, newsmsnumber) + } + return false }