From bfa0e9481cda6761d2352724698354a0b377303e Mon Sep 17 00:00:00 2001
From: Einhornimmond <git@einhornimmond.de>
Date: Fri, 8 Oct 2021 18:20:52 +0200
Subject: [PATCH] fix problems with transaction

---
 .../graphql/resolver/TransactionResolver.ts   | 42 ++++++++++++-------
 .../src/typeorm/entity/TransactionSendCoin.ts |  3 ++
 backend/src/util/decay.ts                     |  3 ++
 3 files changed, 33 insertions(+), 15 deletions(-)

diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts
index c46054ed5..571c7c856 100644
--- a/backend/src/graphql/resolver/TransactionResolver.ts
+++ b/backend/src/graphql/resolver/TransactionResolver.ts
@@ -368,19 +368,20 @@ async function sendCoins(
 
     const queryRunner = getConnection().createQueryRunner()
     await queryRunner.connect()
-    await queryRunner.startTransaction()
+    await queryRunner.startTransaction('READ UNCOMMITTED')
     try {
       // transaction
-      const transaction = new DbTransaction()
+      let transaction = new DbTransaction()
       transaction.transactionTypeId = TransactionTypeId.SEND
       transaction.memo = memo
       const transactionRepository = getCustomRepository(TransactionRepository)
-      queryRunner.manager.save(transaction).catch(() => {
-        throw new Error('error saving transaction')
+      queryRunner.manager.save(transaction).catch((error) => {
+        throw new Error('error saving transaction: ' + error)
+      })
+      const insertResult = await queryRunner.manager.insert(DbTransaction, transaction)
+      transaction = await queryRunner.manager.findOneOrFail(DbTransaction, insertResult.generatedMaps[0].id).catch((error) => {
+        throw new Error('error loading saved transaction: ' + error)
       })
-
-      // eslint-disable-next-line no-console
-      console.log('transaction after saving: %o', transaction)
 
       if (!recipiantUser) {
         throw new Error('Cannot find recipiant user by local send coins transaction')
@@ -431,13 +432,15 @@ async function sendCoins(
       transactionSendCoin.recipiantUserId = recipiantUser.id
       transactionSendCoin.recipiantPublic = Buffer.from(fromHex(recipiantPublicKey))
       transactionSendCoin.amount = centAmount
-      queryRunner.manager.save(transactionSendCoin).catch(() => {
-        throw new Error('error saving transaction send coin')
+      transactionSendCoin.senderFinalBalance = senderStateBalance.amount 
+      await queryRunner.manager.save(transactionSendCoin).catch((error) => {
+        throw new Error('error saving transaction send coin: ' + error)
       })
 
       // tx hash
       const state = cryptoGenerichashInit(null, cryptoGenericHashBytes)
       if (transaction.id > 1) {
+        
         const previousTransaction = await transactionRepository.findOne({ id: transaction.id - 1 })
         if (!previousTransaction) {
           throw new Error('Error previous transaction not found')
@@ -450,21 +453,28 @@ async function sendCoins(
       cryptoGenerichashUpdate(state, receivedString)
       cryptoGenerichashUpdate(state, proto.gradido.SignatureMap.encode(sigMap).finish())
       transaction.txHash = Buffer.from(cryptoGenerichashFinal(state, cryptoGenericHashBytes))
-      transactionRepository.save(transaction).catch(() => {
-        throw new Error('error saving transaction with tx hash')
+      await queryRunner.manager.save(transaction).catch((error) => {
+        throw new Error('error saving transaction with tx hash: ' + error)
       })
-
+      
       // save signature
       const signature = new DbTransactionSignature()
       signature.transactionId = transaction.id
       signature.signature = Buffer.from(sign)
       signature.pubkey = senderUser.pubkey
-      queryRunner.manager.save(signature).catch(() => {
-        throw new Error('error saving signature')
+      await queryRunner.manager.save(signature).catch((error) => {
+        throw new Error('error saving signature: ' + error)
       })
-      queryRunner.commitTransaction()
+      await queryRunner.commitTransaction()
     } catch (e) {
       await queryRunner.rollbackTransaction()
+      const count = await queryRunner.manager.count(DbTransaction)
+      // fix autoincrement value which seems not effected from rollback      
+      await queryRunner.query('ALTER TABLE `transactions` auto_increment = ?', [ count ]).catch((error) => {
+        // eslint-disable-next-line no-console
+        console.log("problems with reset auto increment: %o", error)
+      })
+
       throw e
     } finally {
       // you need to release query runner which is manually created:
@@ -514,6 +524,8 @@ async function sendCoins(
       })
       if (!info.messageId) {
         throw new Error('error sending notification email, but transaction succeed')
+      } else {
+        console.log('send email: %o', info)
       }
     }
   }
diff --git a/backend/src/typeorm/entity/TransactionSendCoin.ts b/backend/src/typeorm/entity/TransactionSendCoin.ts
index 4054ea755..6153ee94c 100644
--- a/backend/src/typeorm/entity/TransactionSendCoin.ts
+++ b/backend/src/typeorm/entity/TransactionSendCoin.ts
@@ -24,6 +24,9 @@ export class TransactionSendCoin extends BaseEntity {
   @Column()
   amount: number
 
+  @Column({ name: 'sender_final_balance' })
+  senderFinalBalance: number
+
   @OneToOne(() => Transaction)
   @JoinColumn({ name: 'transaction_id' })
   transaction: Transaction
diff --git a/backend/src/util/decay.ts b/backend/src/util/decay.ts
index 7ea97ada9..fd65ddedc 100644
--- a/backend/src/util/decay.ts
+++ b/backend/src/util/decay.ts
@@ -7,6 +7,9 @@ function decayFormula(amount: number, seconds: number): number {
 }
 
 async function calculateDecay(amount: number, from: Date, to: Date): Promise<number> {
+  if(amount === undefined || !from || !to) {
+    throw new Error('at least one parameter is undefined')
+  }
   // load decay start block
   const transactionRepository = getCustomRepository(TransactionRepository)
   const decayStartBlock = await transactionRepository.findDecayStartBlock()