From c042df87144e41ec274cfa5a5f13879c25d64644 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Fri, 11 Mar 2022 13:12:44 +0100
Subject: [PATCH] remove one unnecessary conditional check

---
 .../src/graphql/resolver/TransactionLinkResolver.ts    | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.ts b/backend/src/graphql/resolver/TransactionLinkResolver.ts
index 7deb27912..9d1b72f6f 100644
--- a/backend/src/graphql/resolver/TransactionLinkResolver.ts
+++ b/backend/src/graphql/resolver/TransactionLinkResolver.ts
@@ -99,14 +99,10 @@ export class TransactionLinkResolver {
   async queryTransactionLink(@Arg('code') code: string): Promise<TransactionLink> {
     const transactionLink = await dbTransactionLink.findOneOrFail({ code })
     const user = await dbUser.findOneOrFail({ id: transactionLink.userId })
-    let redeemedBy: dbUser | null = null
+    let redeemedBy: User | null = null
     if (transactionLink && transactionLink.redeemedBy) {
-      redeemedBy = await dbUser.findOneOrFail({ id: transactionLink.redeemedBy })
+      redeemedBy = new User(await dbUser.findOneOrFail({ id: transactionLink.redeemedBy }))
     }
-    return new TransactionLink(
-      transactionLink,
-      new User(user),
-      redeemedBy ? new User(redeemedBy) : null,
-    )
+    return new TransactionLink(transactionLink, new User(user), redeemedBy)
   }
 }