additional test with missing response data

backend/src/federation/validateCommunities.test.ts

@@ -59,7 +59,46 @@ describe('validate Communities', () => {
       expect(logger.debug).toBeCalledWith(`Federation: found 0 dbCommunities`)
     })
 
-    describe('with one Community of api 1_0', () => {
+    describe('with one Community of api 1_0 but missing pubKey response', () => {
+      beforeEach(async () => {
+        // eslint-disable-next-line @typescript-eslint/require-await
+        jest.spyOn(GraphQLClient.prototype, 'rawRequest').mockImplementation(async () => {
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-return
+          return { data: {} } as Response<unknown> })
+        const variables1 = {
+          publicKey: Buffer.from(
+            '1111111111111111111111111111111111111111111111111111111111111111',
+          ),
+          apiVersion: '1_0',
+          endPoint: 'http//localhost:5001/api/',
+          lastAnnouncedAt: new Date(),
+        }
+        await DbFederatedCommunity.createQueryBuilder()
+          .insert()
+          .into(DbFederatedCommunity)
+          .values(variables1)
+          .orUpdate({
+            // eslint-disable-next-line camelcase
+            conflict_target: ['id', 'publicKey', 'apiVersion'],
+            overwrite: ['end_point', 'last_announced_at'],
+          })
+          .execute()
+        jest.clearAllMocks()
+        await validateCommunities()
+      })
+
+      it('logs one community found', () => {
+        expect(logger.debug).toBeCalledWith(`Federation: found 1 dbCommunities`)
+      })
+      it('logs requestGetPublicKey missing response data ', () => {
+        expect(logger.warn).toBeCalledWith(
+          'Federation: getPublicKey without response data from endpoint',
+          'http//localhost:5001/api/1_0/',
+        )
+      })
+    })
+
+    describe('with one Community of api 1_0 and not matching pubKey', () => {
       beforeEach(async () => {
         // eslint-disable-next-line @typescript-eslint/require-await
         jest.spyOn(GraphQLClient.prototype, 'rawRequest').mockImplementation(async () => {
@@ -73,7 +112,9 @@ describe('validate Communities', () => {
           } as Response<unknown>
         })
         const variables1 = {
-          publicKey: Buffer.from('11111111111111111111111111111111'),
+          publicKey: Buffer.from(
+            '1111111111111111111111111111111111111111111111111111111111111111',
+          ),
           apiVersion: '1_0',
           endPoint: 'http//localhost:5001/api/',
           lastAnnouncedAt: new Date(),
@@ -133,7 +174,64 @@ describe('validate Communities', () => {
         )
       })
       it('logs not matching publicKeys', () => {
-        expect(logger.warn).toBeCalledWith('Federation: received none or not matching publicKey...')
+        expect(logger.warn).toBeCalledWith(
+          'Federation: received not matching publicKey:',
+          'somePubKey',
+          expect.stringMatching('1111111111111111111111111111111111111111111111111111111111111111'),
+        )
+      })
+    })
+    describe('with one Community of api 1_0 and matching pubKey', () => {
+      beforeEach(async () => {
+        // eslint-disable-next-line @typescript-eslint/require-await
+        jest.spyOn(GraphQLClient.prototype, 'rawRequest').mockImplementation(async () => {
+          // eslint-disable-next-line @typescript-eslint/no-unsafe-return
+          return {
+            data: {
+              getPublicKey: {
+                publicKey: '1111111111111111111111111111111111111111111111111111111111111111',
+              },
+            },
+          } as Response<unknown>
+        })
+        const variables1 = {
+          publicKey: Buffer.from(
+            '1111111111111111111111111111111111111111111111111111111111111111',
+          ),
+          apiVersion: '1_0',
+          endPoint: 'http//localhost:5001/api/',
+          lastAnnouncedAt: new Date(),
+        }
+        await DbFederatedCommunity.createQueryBuilder()
+          .insert()
+          .into(DbFederatedCommunity)
+          .values(variables1)
+          .orUpdate({
+            // eslint-disable-next-line camelcase
+            conflict_target: ['id', 'publicKey', 'apiVersion'],
+            overwrite: ['end_point', 'last_announced_at'],
+          })
+          .execute()
+        await DbFederatedCommunity.update({}, { verifiedAt: null })
+        jest.clearAllMocks()
+        await validateCommunities()
+      })
+
+      it('logs one community found', () => {
+        expect(logger.debug).toBeCalledWith(`Federation: found 1 dbCommunities`)
+      })
+      it('logs requestGetPublicKey for community api 1_0 ', () => {
+        expect(logger.info).toBeCalledWith(
+          'Federation: getPublicKey from endpoint',
+          'http//localhost:5001/api/1_0/',
+        )
+      })
+      it('logs community pubKey verified', () => {
+        expect(logger.info).toHaveBeenNthCalledWith(
+          3,
+          'Federation: verified community with:',
+          'http//localhost:5001/api/',
+        )
       })
     })
     describe('with two Communities of api 1_0 and 1_1', () => {
@@ -145,13 +243,15 @@ describe('validate Communities', () => {
           return {
             data: {
               getPublicKey: {
-                publicKey: '11111111111111111111111111111111',
+                publicKey: '1111111111111111111111111111111111111111111111111111111111111111',
               },
             },
           } as Response<unknown>
         })
         const variables2 = {
-          publicKey: Buffer.from('11111111111111111111111111111111'),
+          publicKey: Buffer.from(
+            '1111111111111111111111111111111111111111111111111111111111111111',
+          ),
           apiVersion: '1_1',
           endPoint: 'http//localhost:5001/api/',
           lastAnnouncedAt: new Date(),
@@ -167,6 +267,7 @@ describe('validate Communities', () => {
           })
           .execute()
 
+        await DbFederatedCommunity.update({}, { verifiedAt: null })
         jest.clearAllMocks()
         await validateCommunities()
       })
@@ -190,7 +291,9 @@ describe('validate Communities', () => {
       let dbCom: DbFederatedCommunity
       beforeEach(async () => {
         const variables3 = {
-          publicKey: Buffer.from('11111111111111111111111111111111'),
+          publicKey: Buffer.from(
+            '1111111111111111111111111111111111111111111111111111111111111111',
+          ),
           apiVersion: '2_0',
           endPoint: 'http//localhost:5001/api/',
           lastAnnouncedAt: new Date(),
@@ -208,6 +311,7 @@ describe('validate Communities', () => {
         dbCom = await DbFederatedCommunity.findOneOrFail({
           where: { publicKey: variables3.publicKey, apiVersion: variables3.apiVersion },
         })
+        await DbFederatedCommunity.update({}, { verifiedAt: null })
         jest.clearAllMocks()
         await validateCommunities()
       })

backend/src/federation/validateCommunities.ts

@@ -47,14 +47,18 @@ export async function validateCommunities(): Promise<void> {
         const pubKey = await client.getPublicKey()
         if (pubKey && pubKey === dbCom.publicKey.toString()) {
           await DbFederatedCommunity.update({ id: dbCom.id }, { verifiedAt: new Date() })
-          logger.info(`Federation: verified community: id=${dbCom.id}, endpoint=${dbCom.endPoint}`)
+          logger.info(`Federation: verified community with:`, dbCom.endPoint)
           const pubComInfo = await client.getPublicCommunityInfo()
           if (pubComInfo) {
             await writeForeignCommunity(dbCom, pubComInfo)
             logger.info(`Federation: write publicInfo of community: name=${pubComInfo.name}`)
           }
         } else {
-          logger.warn(`Federation: received none or not matching publicKey...`)
+          logger.warn(
+            'Federation: received not matching publicKey:',
+            pubKey,
+            dbCom.publicKey.toString(),
+          )
         }
       }
     } catch (err) {