From bae1b85482bc5f895d8f5089f50b0b48b347c7ed Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Fri, 25 Mar 2022 09:29:42 +0100
Subject: [PATCH 01/17] add bootstrap pagination on GDD Transaction List, tests
 adapted

---
 .../src/components/GddTransactionList.spec.js | 83 ++++---------------
 .../src/components/GddTransactionList.vue     | 11 ++-
 2 files changed, 21 insertions(+), 73 deletions(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index ba45d93d4..28a052abe 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -405,78 +405,23 @@ describe('GddTransactionList', () => {
       })
     })
 
-    describe('pagination buttons', () => {
-      const transactions = Array.from({ length: 42 }, (_, idx) => {
-        return {
-          amount: '3.14',
-          balanceDate: '2021-04-29T17:26:40+00:00',
-          decay: {},
-          memo: 'Kreiszahl PI',
-          linkedUser: {
-            firstName: 'Bibi',
-            lastName: 'Bloxberg',
-            __typename: 'User',
-          },
-          id: idx + 1,
-          typeId: 'RECEIVE',
-        }
-      })
-
-      let paginationButtons
-
-      beforeEach(async () => {
-        await wrapper.setProps({
-          transactions,
-          transactionCount: 42,
-          showPagination: true,
-          decayStartBlock: new Date(),
+    describe.only('pagination buttons', () => {
+      it('shows the pagination buttons if transactionCount > 25', () => {
+        beforeEach(async () => {
+          await wrapper.setProps({
+            transactionCount: 42,
+          })
         })
-        paginationButtons = wrapper.find('div.pagination-buttons')
+        expect(wrapper.find('div.pagination')).toBeTruthy()
       })
 
-      it('shows the pagination buttons', () => {
-        expect(paginationButtons.exists()).toBeTruthy()
-      })
-
-      it('has the previous button disabled', () => {
-        expect(paginationButtons.find('button.previous-page').attributes('disabled')).toBe(
-          'disabled',
-        )
-      })
-
-      it('shows the text "1 / 2"', () => {
-        expect(paginationButtons.find('p.text-center').text()).toBe('1 math.div 2')
-      })
-
-      it('emits update-transactions when next button is clicked', async () => {
-        await paginationButtons.find('button.next-page').trigger('click')
-        expect(wrapper.emitted('update-transactions')[1]).toEqual([
-          { currentPage: 2, pageSize: 25 },
-        ])
-      })
-
-      it('shows text "2 / 2" when next button is clicked', async () => {
-        await paginationButtons.find('button.next-page').trigger('click')
-        expect(paginationButtons.find('p.text-center').text()).toBe('2 math.div 2')
-      })
-
-      it('has next-button disabled when next button is clicked', async () => {
-        await paginationButtons.find('button.next-page').trigger('click')
-        expect(paginationButtons.find('button.next-page').attributes('disabled')).toBe('disabled')
-      })
-
-      it('scrolls to top after loading next page', async () => {
-        await paginationButtons.find('button.next-page').trigger('click')
-        expect(scrollToMock).toBeCalled()
-      })
-
-      it('emits update-transactions when preivous button is clicked after next buton', async () => {
-        await paginationButtons.find('button.next-page').trigger('click')
-        await paginationButtons.find('button.previous-page').trigger('click')
-        expect(wrapper.emitted('update-transactions')[2]).toEqual([
-          { currentPage: 1, pageSize: 25 },
-        ])
-        expect(scrollToMock).toBeCalled()
+      it('shows no the pagination buttons if transactionCount < 25', () => {
+        beforeEach(async () => {
+          await wrapper.setProps({
+            transactionCount: 2,
+          })
+        })
+        expect(wrapper.find('div.pagination').exists()).toBe(false)
       })
     })
   })
diff --git a/frontend/src/components/GddTransactionList.vue b/frontend/src/components/GddTransactionList.vue
index 2424907c5..9e5cc8e8d 100644
--- a/frontend/src/components/GddTransactionList.vue
+++ b/frontend/src/components/GddTransactionList.vue
@@ -56,12 +56,17 @@
         </transaction-list-item>
       </div>
     </div>
-    <pagination-buttons
+    <b-pagination
       v-if="showPagination"
+      class="mt-3"
+      pills
+      size="lg"
       v-model="currentPage"
       :per-page="pageSize"
       :total-rows="transactionCount"
-    ></pagination-buttons>
+      align="center"
+    ></b-pagination>
+
     <div v-if="transactionCount <= 0" class="mt-4 text-center">
       <span>{{ $t('transaction.nullTransactions') }}</span>
     </div>
@@ -70,7 +75,6 @@
 
 <script>
 import TransactionListItem from '@/components/TransactionListItem'
-import PaginationButtons from '@/components/PaginationButtons'
 import TransactionDecay from '@/components/Transactions/TransactionDecay'
 import TransactionSend from '@/components/Transactions/TransactionSend'
 import TransactionReceive from '@/components/Transactions/TransactionReceive'
@@ -81,7 +85,6 @@ export default {
   name: 'gdd-transaction-list',
   components: {
     TransactionListItem,
-    PaginationButtons,
     TransactionDecay,
     TransactionSend,
     TransactionReceive,

From 5b16d687ac7db36d4d26ddced34159b3ea1720f5 Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Fri, 25 Mar 2022 09:48:28 +0100
Subject: [PATCH 02/17] add bootstrap pagination on GDD Transaction List, tests
 adapted

---
 .../src/components/GdtTransactionList.spec.js | 20 +++++++++++++++++++
 .../src/components/GdtTransactionList.vue     | 11 ++++++----
 2 files changed, 27 insertions(+), 4 deletions(-)

diff --git a/frontend/src/components/GdtTransactionList.spec.js b/frontend/src/components/GdtTransactionList.spec.js
index a04cdc905..81db73de9 100644
--- a/frontend/src/components/GdtTransactionList.spec.js
+++ b/frontend/src/components/GdtTransactionList.spec.js
@@ -167,5 +167,25 @@ describe('GdtTransactionList ', () => {
         )
       })
     })
+
+    describe.only('pagination buttons', () => {
+      it('shows the pagination buttons if transactionCount > 25', () => {
+        beforeEach(async () => {
+          await wrapper.setProps({
+            transactionGdtCount: 42,
+          })
+        })
+        expect(wrapper.find('div.pagination')).toBeTruthy()
+      })
+
+      it('shows no the pagination buttons if transactionCount < 25', () => {
+        beforeEach(async () => {
+          await wrapper.setProps({
+            transactionGdtCount: 2,
+          })
+        })
+        expect(wrapper.find('div.pagination').exists()).toBe(false)
+      })
+    })
   })
 })
diff --git a/frontend/src/components/GdtTransactionList.vue b/frontend/src/components/GdtTransactionList.vue
index 0c061ed06..a6f19a560 100644
--- a/frontend/src/components/GdtTransactionList.vue
+++ b/frontend/src/components/GdtTransactionList.vue
@@ -27,23 +27,26 @@
         ></transaction>
       </div>
     </div>
-    <pagination-buttons
+    <b-pagination
+      v-if="transactionGdtCount > 25"
+      class="mt-3"
+      pills
+      size="lg"
       v-model="currentPage"
       :per-page="pageSize"
       :total-rows="transactionGdtCount"
-    ></pagination-buttons>
+      align="center"
+    ></b-pagination>
   </div>
 </template>
 
 <script>
 import { listGDTEntriesQuery } from '@/graphql/queries'
-import PaginationButtons from '@/components/PaginationButtons'
 import Transaction from '@/components/Transaction.vue'
 
 export default {
   name: 'gdt-transaction-list',
   components: {
-    PaginationButtons,
     Transaction,
   },
   data() {

From 6e8ef54858b659450a8891b2314e114491c46653 Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:45:50 +0200
Subject: [PATCH 03/17] Update frontend/src/components/GdtTransactionList.vue

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GdtTransactionList.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GdtTransactionList.vue b/frontend/src/components/GdtTransactionList.vue
index a6f19a560..8944ea69b 100644
--- a/frontend/src/components/GdtTransactionList.vue
+++ b/frontend/src/components/GdtTransactionList.vue
@@ -28,7 +28,7 @@
       </div>
     </div>
     <b-pagination
-      v-if="transactionGdtCount > 25"
+      v-if="transactionGdtCount > pageSize"
       class="mt-3"
       pills
       size="lg"

From ea825bc6cdc56bb254d31f6c1456402de4e8748d Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:46:07 +0200
Subject: [PATCH 04/17] Update
 frontend/src/components/GdtTransactionList.spec.js

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GdtTransactionList.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GdtTransactionList.spec.js b/frontend/src/components/GdtTransactionList.spec.js
index 81db73de9..66c7ecc21 100644
--- a/frontend/src/components/GdtTransactionList.spec.js
+++ b/frontend/src/components/GdtTransactionList.spec.js
@@ -168,7 +168,7 @@ describe('GdtTransactionList ', () => {
       })
     })
 
-    describe.only('pagination buttons', () => {
+    describe('pagination buttons', () => {
       it('shows the pagination buttons if transactionCount > 25', () => {
         beforeEach(async () => {
           await wrapper.setProps({

From da9b5f0bbb091985f65eaa18556bb01a5ad2c736 Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:46:28 +0200
Subject: [PATCH 05/17] Update
 frontend/src/components/GdtTransactionList.spec.js

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GdtTransactionList.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GdtTransactionList.spec.js b/frontend/src/components/GdtTransactionList.spec.js
index 66c7ecc21..34d2713af 100644
--- a/frontend/src/components/GdtTransactionList.spec.js
+++ b/frontend/src/components/GdtTransactionList.spec.js
@@ -175,7 +175,7 @@ describe('GdtTransactionList ', () => {
             transactionGdtCount: 42,
           })
         })
-        expect(wrapper.find('div.pagination')).toBeTruthy()
+        expect(wrapper.find('div.pagination').exists()).toBe(true)
       })
 
       it('shows no the pagination buttons if transactionCount < 25', () => {

From f4813468de6ff3501d49d34cf2a507d00aa3e71f Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:46:41 +0200
Subject: [PATCH 06/17] Update
 frontend/src/components/GddTransactionList.spec.js

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GddTransactionList.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index 28a052abe..6f450d6fb 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -415,7 +415,7 @@ describe('GddTransactionList', () => {
         expect(wrapper.find('div.pagination')).toBeTruthy()
       })
 
-      it('shows no the pagination buttons if transactionCount < 25', () => {
+      it('shows no pagination buttons if transactionCount < pageSize', () => {
         beforeEach(async () => {
           await wrapper.setProps({
             transactionCount: 2,

From f6d12c2b464e61f1366ca62e25d87d434d937740 Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:46:52 +0200
Subject: [PATCH 07/17] Update
 frontend/src/components/GddTransactionList.spec.js

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GddTransactionList.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index 6f450d6fb..b02d6c2d7 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -406,7 +406,7 @@ describe('GddTransactionList', () => {
     })
 
     describe.only('pagination buttons', () => {
-      it('shows the pagination buttons if transactionCount > 25', () => {
+      it('shows the pagination buttons if transactionCount > pageSize', () => {
         beforeEach(async () => {
           await wrapper.setProps({
             transactionCount: 42,

From 1ad41ddac8504143417f395944a7437bc3c6b5f2 Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:47:07 +0200
Subject: [PATCH 08/17] Update
 frontend/src/components/GddTransactionList.spec.js

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GddTransactionList.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index b02d6c2d7..4205ca304 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -412,7 +412,7 @@ describe('GddTransactionList', () => {
             transactionCount: 42,
           })
         })
-        expect(wrapper.find('div.pagination')).toBeTruthy()
+        expect(wrapper.find('div.pagination').exists()).toBe(true)
       })
 
       it('shows no pagination buttons if transactionCount < pageSize', () => {

From a6396cc99803acdd9a9156746770f3f8286d69bf Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:48:27 +0200
Subject: [PATCH 09/17] Update
 frontend/src/components/GdtTransactionList.spec.js

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GdtTransactionList.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GdtTransactionList.spec.js b/frontend/src/components/GdtTransactionList.spec.js
index 34d2713af..420e76156 100644
--- a/frontend/src/components/GdtTransactionList.spec.js
+++ b/frontend/src/components/GdtTransactionList.spec.js
@@ -169,7 +169,7 @@ describe('GdtTransactionList ', () => {
     })
 
     describe('pagination buttons', () => {
-      it('shows the pagination buttons if transactionCount > 25', () => {
+      it('shows the pagination buttons if transactionCount > pageSize', () => {
         beforeEach(async () => {
           await wrapper.setProps({
             transactionGdtCount: 42,

From b2af0f24298f4aeccea5bfcd880255a12890d50b Mon Sep 17 00:00:00 2001
From: Alexander Friedland <ogerly@users.noreply.github.com>
Date: Tue, 29 Mar 2022 11:48:38 +0200
Subject: [PATCH 10/17] Update
 frontend/src/components/GdtTransactionList.spec.js

Co-authored-by: Moriz Wahl <moriz.wahl@gmx.de>
---
 frontend/src/components/GdtTransactionList.spec.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/GdtTransactionList.spec.js b/frontend/src/components/GdtTransactionList.spec.js
index 420e76156..1e2096ece 100644
--- a/frontend/src/components/GdtTransactionList.spec.js
+++ b/frontend/src/components/GdtTransactionList.spec.js
@@ -178,7 +178,7 @@ describe('GdtTransactionList ', () => {
         expect(wrapper.find('div.pagination').exists()).toBe(true)
       })
 
-      it('shows no the pagination buttons if transactionCount < 25', () => {
+      it('shows no the pagination buttons if transactionCount < pageSize', () => {
         beforeEach(async () => {
           await wrapper.setProps({
             transactionGdtCount: 2,

From d488b037bd43507c70ed1ebb8b607939fbeb717f Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Thu, 31 Mar 2022 15:41:46 +0200
Subject: [PATCH 11/17] Unused test commented out

---
 frontend/src/components/GddTransactionList.spec.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index 062523323..ba49e8f2a 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -406,7 +406,7 @@ describe('GddTransactionList', () => {
     })
 
     describe('pagination buttons', () => {
-      const transactions = Array.from({ length: 42 }, (_, idx) => {
+      /* const transactions = Array.from({ length: 42 }, (_, idx) => {
         return {
           amount: '3.14',
           balanceDate: '2021-04-29T17:26:40+00:00',
@@ -422,6 +422,7 @@ describe('GddTransactionList', () => {
           balance: '33.33',
         }
       })
+      */
 
       it('shows no pagination buttons if transactionCount < pageSize', () => {
         beforeEach(async () => {

From 48b73c25152166e56b3424a0c5c39e100cc23adb Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Thu, 31 Mar 2022 17:30:02 +0200
Subject: [PATCH 12/17] tests for pagenation exists

---
 .../src/components/GddTransactionList.spec.js | 43 +++++++------------
 .../src/components/GdtTransactionList.spec.js | 42 ++++++++++++------
 2 files changed, 45 insertions(+), 40 deletions(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index ba49e8f2a..5c9dbbb14 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -405,33 +405,22 @@ describe('GddTransactionList', () => {
       })
     })
 
-    describe('pagination buttons', () => {
-      /* const transactions = Array.from({ length: 42 }, (_, idx) => {
-        return {
-          amount: '3.14',
-          balanceDate: '2021-04-29T17:26:40+00:00',
-          decay: {},
-          memo: 'Kreiszahl PI',
-          linkedUser: {
-            firstName: 'Bibi',
-            lastName: 'Bloxberg',
-            __typename: 'User',
-          },
-          id: idx + 1,
-          typeId: 'RECEIVE',
-          balance: '33.33',
-        }
-      })
-      */
+    // describe('pagination buttons', () => {
+    //  describe('updates transaction count < 25', () => {
+    //    beforeEach(async () => {
+    //      await wrapper.setProps({
+    //        transactionCount: 2,
+    //      })
+    //    })
 
-      it('shows no pagination buttons if transactionCount < pageSize', () => {
-        beforeEach(async () => {
-          await wrapper.setProps({
-            transactionCount: 2,
-          })
-        })
-        expect(wrapper.find('div.pagination').exists()).toBe(false)
-      })
-    })
+    //    it('updates transaction count', () => {
+    //      expect(wrapper.vm.transactionCount).toBe(2)
+    //    })
+
+    //    it('shows no pagination buttons if transactionCount < pageSize', () => {
+    //      expect(wrapper.find('div.pagination').exists()).toBe(false)
+    //    })
+    //  })
+    // })
   })
 })
diff --git a/frontend/src/components/GdtTransactionList.spec.js b/frontend/src/components/GdtTransactionList.spec.js
index 1e2096ece..7871b6750 100644
--- a/frontend/src/components/GdtTransactionList.spec.js
+++ b/frontend/src/components/GdtTransactionList.spec.js
@@ -166,25 +166,41 @@ describe('GdtTransactionList ', () => {
           }),
         )
       })
-    })
 
-    describe('pagination buttons', () => {
-      it('shows the pagination buttons if transactionCount > pageSize', () => {
-        beforeEach(async () => {
-          await wrapper.setProps({
-            transactionGdtCount: 42,
+      describe('pagination buttons', () => {
+        describe('with transactionCount > pageSize', () => {
+          beforeEach(async () => {
+            apolloMock.mockResolvedValue({
+              data: {
+                listGDTEntries: {
+                  count: 42,
+                  gdtEntries: [],
+                },
+              },
+            })
+            wrapper = Wrapper()
+          })
+          it('shows the pagination buttons', () => {
+            expect(wrapper.find('ul.pagination').exists()).toBe(true)
           })
         })
-        expect(wrapper.find('div.pagination').exists()).toBe(true)
-      })
 
-      it('shows no the pagination buttons if transactionCount < pageSize', () => {
-        beforeEach(async () => {
-          await wrapper.setProps({
-            transactionGdtCount: 2,
+        describe('with transactionCount < pageSize', () => {
+          beforeEach(async () => {
+            apolloMock.mockResolvedValue({
+              data: {
+                listGDTEntries: {
+                  count: 2,
+                  gdtEntries: [],
+                },
+              },
+            })
+            wrapper = Wrapper()
+          })
+          it('shows no pagination buttons', () => {
+            expect(wrapper.find('ul.pagination').exists()).toBe(false)
           })
         })
-        expect(wrapper.find('div.pagination').exists()).toBe(false)
       })
     })
   })

From 895d785916171b73cccb1d1b0002b204b443cdb8 Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Thu, 31 Mar 2022 21:17:27 +0200
Subject: [PATCH 13/17] tests GddTransactionList pagenation

---
 .../src/components/GddTransactionList.spec.js | 40 +++++++++++--------
 1 file changed, 24 insertions(+), 16 deletions(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index 5c9dbbb14..7eaa42081 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -405,22 +405,30 @@ describe('GddTransactionList', () => {
       })
     })
 
-    // describe('pagination buttons', () => {
-    //  describe('updates transaction count < 25', () => {
-    //    beforeEach(async () => {
-    //      await wrapper.setProps({
-    //        transactionCount: 2,
-    //      })
-    //    })
+    describe('change of currentPage', () => {
+      beforeEach(async () => {
+        wrapper.setData({ currentPage: 2 })
+      })
 
-    //    it('updates transaction count', () => {
-    //      expect(wrapper.vm.transactionCount).toBe(2)
-    //    })
-
-    //    it('shows no pagination buttons if transactionCount < pageSize', () => {
-    //      expect(wrapper.find('div.pagination').exists()).toBe(false)
-    //    })
-    //  })
-    // })
+      describe('pagination buttons', () => {
+        describe('updates transaction count < 25', () => {
+          beforeEach(async () => {
+            const decayStartBlock = new Date(2001, 8, 9)
+            await wrapper.setProps({
+              transactions: [],
+              transactionCount: 26,
+              decayStartBlock,
+              pageSize: 25,
+            })
+          })
+          it('updates transaction transactionCount', () => {
+            expect(wrapper.vm.transactionCount).toBe(26)
+          })
+          it('shows pagination buttons if transactionCount > pageSize', () => {
+            expect(wrapper.find('ul.pagination').exists()).toBe(true)
+          })
+        })
+      })
+    })
   })
 })

From 1b88c23b050a0ff6a02ef1c00f20feac69f97993 Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Mon, 4 Apr 2022 17:59:57 +0200
Subject: [PATCH 14/17] fixed test for pagination

---
 .../src/components/GddTransactionList.spec.js | 34 +++++++++++++++++--
 1 file changed, 31 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index 7eaa42081..eba3dee2d 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -405,13 +405,13 @@ describe('GddTransactionList', () => {
       })
     })
 
-    describe('change of currentPage', () => {
+    describe('change of 2 currentPage', () => {
       beforeEach(async () => {
         wrapper.setData({ currentPage: 2 })
       })
 
       describe('pagination buttons', () => {
-        describe('updates transaction count < 25', () => {
+        describe('updates transactionCount > 25', () => {
           beforeEach(async () => {
             const decayStartBlock = new Date(2001, 8, 9)
             await wrapper.setProps({
@@ -419,16 +419,44 @@ describe('GddTransactionList', () => {
               transactionCount: 26,
               decayStartBlock,
               pageSize: 25,
+              showPagination: true,
             })
           })
           it('updates transaction transactionCount', () => {
             expect(wrapper.vm.transactionCount).toBe(26)
           })
-          it('shows pagination buttons if transactionCount > pageSize', () => {
+          it('shows pagination buttons if showPagination = true', () => {
             expect(wrapper.find('ul.pagination').exists()).toBe(true)
           })
         })
       })
     })
+
+    describe('change of 1 currentPage', () => {
+      beforeEach(async () => {
+        wrapper.setData({ currentPage: 1 })
+      })
+
+      describe('pagination buttons', () => {
+        describe('updates transactionCount < 25', () => {
+          beforeEach(async () => {
+            const decayStartBlock = new Date(2001, 8, 9)
+            await wrapper.setProps({
+              transactions: [],
+              transactionCount: 2,
+              decayStartBlock,
+              pageSize: 25,
+              showPagination: false,
+            })
+          })
+          it('updates transaction transactionCount', () => {
+            expect(wrapper.vm.transactionCount).toBe(2)
+          })
+          it('shows pagination buttons if showPagination = true', () => {
+            expect(wrapper.find('ul.pagination').exists()).toBe(false)
+          })
+        })
+      })
+    })
   })
 })

From f8412acb5ead9c3918a74fe57eb8bf96a4b656d5 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Tue, 5 Apr 2022 13:27:43 +0200
Subject: [PATCH 15/17] improve tests

---
 .../src/components/GddTransactionList.spec.js | 87 ++++++++++---------
 .../src/components/GdtTransactionList.spec.js |  6 +-
 2 files changed, 49 insertions(+), 44 deletions(-)

diff --git a/frontend/src/components/GddTransactionList.spec.js b/frontend/src/components/GddTransactionList.spec.js
index eba3dee2d..fbcb10bdd 100644
--- a/frontend/src/components/GddTransactionList.spec.js
+++ b/frontend/src/components/GddTransactionList.spec.js
@@ -23,6 +23,8 @@ describe('GddTransactionList', () => {
     return mount(GddTransactionList, { localVue, mocks })
   }
 
+  const decayStartBlock = new Date(2001, 8, 9)
+
   describe('mount', () => {
     beforeEach(() => {
       wrapper = Wrapper()
@@ -84,7 +86,6 @@ describe('GddTransactionList', () => {
 
     describe('with transactions', () => {
       beforeEach(async () => {
-        const decayStartBlock = new Date(2001, 8, 9)
         await wrapper.setProps({
           transactions: [
             {
@@ -405,57 +406,59 @@ describe('GddTransactionList', () => {
       })
     })
 
-    describe('change of 2 currentPage', () => {
+    describe('pagination buttons', () => {
       beforeEach(async () => {
-        wrapper.setData({ currentPage: 2 })
+        await wrapper.setProps({
+          transactions: Array.from({ length: 42 }, (_, idx) => {
+            return {
+              amount: '3.14',
+              balanceDate: '2021-04-29T17:26:40+00:00',
+              decay: {},
+              memo: 'Kreiszahl PI',
+              linkedUser: {
+                firstName: 'Bibi',
+                lastName: 'Bloxberg',
+                __typename: 'User',
+              },
+              id: idx + 1,
+              typeId: 'RECEIVE',
+              balance: '33.33',
+            }
+          }),
+          transactionCount: 42,
+          decayStartBlock,
+          pageSize: 25,
+          showPagination: true,
+        })
       })
 
-      describe('pagination buttons', () => {
-        describe('updates transactionCount > 25', () => {
-          beforeEach(async () => {
-            const decayStartBlock = new Date(2001, 8, 9)
-            await wrapper.setProps({
-              transactions: [],
-              transactionCount: 26,
-              decayStartBlock,
-              pageSize: 25,
-              showPagination: true,
-            })
-          })
-          it('updates transaction transactionCount', () => {
-            expect(wrapper.vm.transactionCount).toBe(26)
-          })
-          it('shows pagination buttons if showPagination = true', () => {
-            expect(wrapper.find('ul.pagination').exists()).toBe(true)
-          })
+      describe('next page button clicked', () => {
+        beforeEach(async () => {
+          jest.clearAllMocks()
+          await wrapper.findComponent({ name: 'BPagination' }).vm.$emit('input', 2)
+        })
+
+        it('emits update transactions', () => {
+          expect(wrapper.emitted('update-transactions')).toEqual(
+            expect.arrayContaining([[{ currentPage: 2, pageSize: 25 }]]),
+          )
         })
       })
     })
 
-    describe('change of 1 currentPage', () => {
+    describe('show no pagination', () => {
       beforeEach(async () => {
-        wrapper.setData({ currentPage: 1 })
+        await wrapper.setProps({
+          transactions: [],
+          transactionCount: 2,
+          decayStartBlock,
+          pageSize: 25,
+          showPagination: false,
+        })
       })
 
-      describe('pagination buttons', () => {
-        describe('updates transactionCount < 25', () => {
-          beforeEach(async () => {
-            const decayStartBlock = new Date(2001, 8, 9)
-            await wrapper.setProps({
-              transactions: [],
-              transactionCount: 2,
-              decayStartBlock,
-              pageSize: 25,
-              showPagination: false,
-            })
-          })
-          it('updates transaction transactionCount', () => {
-            expect(wrapper.vm.transactionCount).toBe(2)
-          })
-          it('shows pagination buttons if showPagination = true', () => {
-            expect(wrapper.find('ul.pagination').exists()).toBe(false)
-          })
-        })
+      it('shows no pagination buttons', () => {
+        expect(wrapper.find('ul.pagination').exists()).toBe(false)
       })
     })
   })
diff --git a/frontend/src/components/GdtTransactionList.spec.js b/frontend/src/components/GdtTransactionList.spec.js
index 7871b6750..c1b9a7cc9 100644
--- a/frontend/src/components/GdtTransactionList.spec.js
+++ b/frontend/src/components/GdtTransactionList.spec.js
@@ -155,8 +155,8 @@ describe('GdtTransactionList ', () => {
     describe('change of currentPage', () => {
       it('calls the API after currentPage changes', async () => {
         jest.clearAllMocks()
-        wrapper.setData({ currentPage: 2 })
-        await wrapper.vm.$nextTick()
+        await wrapper.setData({ transactionGdtCount: 42 })
+        await wrapper.findComponent({ name: 'BPagination' }).vm.$emit('input', 2)
         expect(apolloMock).toBeCalledWith(
           expect.objectContaining({
             variables: {
@@ -180,6 +180,7 @@ describe('GdtTransactionList ', () => {
             })
             wrapper = Wrapper()
           })
+
           it('shows the pagination buttons', () => {
             expect(wrapper.find('ul.pagination').exists()).toBe(true)
           })
@@ -197,6 +198,7 @@ describe('GdtTransactionList ', () => {
             })
             wrapper = Wrapper()
           })
+
           it('shows no pagination buttons', () => {
             expect(wrapper.find('ul.pagination').exists()).toBe(false)
           })

From ddeb936634bdbb07eca6c674479ddee8246a3806 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Tue, 5 Apr 2022 13:30:06 +0200
Subject: [PATCH 16/17] remove unused pagination component

---
 .../src/components/PaginationButtons.spec.js  | 49 -----------------
 frontend/src/components/PaginationButtons.vue | 53 -------------------
 2 files changed, 102 deletions(-)
 delete mode 100644 frontend/src/components/PaginationButtons.spec.js
 delete mode 100644 frontend/src/components/PaginationButtons.vue

diff --git a/frontend/src/components/PaginationButtons.spec.js b/frontend/src/components/PaginationButtons.spec.js
deleted file mode 100644
index f2badd082..000000000
--- a/frontend/src/components/PaginationButtons.spec.js
+++ /dev/null
@@ -1,49 +0,0 @@
-import { mount } from '@vue/test-utils'
-import PaginationButtons from './PaginationButtons'
-
-const localVue = global.localVue
-
-const propsData = {
-  totalRows: 42,
-  perPage: 12,
-  value: 1,
-}
-
-describe('PaginationButtons', () => {
-  let wrapper
-
-  const mocks = {
-    $t: jest.fn((t) => t),
-  }
-
-  const Wrapper = () => {
-    return mount(PaginationButtons, { localVue, mocks, propsData })
-  }
-
-  describe('mount', () => {
-    beforeEach(() => {
-      wrapper = Wrapper()
-    })
-
-    it('renders the component', () => {
-      expect(wrapper.find('div.pagination-buttons').exists()).toBeTruthy()
-    })
-
-    describe('with active buttons', () => {
-      it('emits input next page button is clicked', async () => {
-        wrapper.find('button.next-page').trigger('click')
-        await wrapper.vm.$nextTick()
-        expect(wrapper.emitted().input[0]).toEqual([2])
-      })
-
-      it('emits input when previous page button is clicked', async () => {
-        wrapper.setProps({ value: 2 })
-        wrapper.setData({ currentValue: 2 })
-        await wrapper.vm.$nextTick()
-        wrapper.find('button.previous-page').trigger('click')
-        await wrapper.vm.$nextTick()
-        expect(wrapper.emitted().input[0]).toEqual([1])
-      })
-    })
-  })
-})
diff --git a/frontend/src/components/PaginationButtons.vue b/frontend/src/components/PaginationButtons.vue
deleted file mode 100644
index e5e465032..000000000
--- a/frontend/src/components/PaginationButtons.vue
+++ /dev/null
@@ -1,53 +0,0 @@
-<template>
-  <div class="pagination-buttons" v-if="totalRows > perPage">
-    <b-row class="m-4">
-      <b-col class="text-right">
-        <b-button class="previous-page" :disabled="!hasPrevious" @click="currentValue--">
-          <b-icon icon="chevron-left" variant="primary"></b-icon>
-        </b-button>
-      </b-col>
-      <b-col cols="3">
-        <p class="text-center pt-2">{{ value }} {{ $t('math.div') }} {{ totalPages }}</p>
-      </b-col>
-      <b-col>
-        <b-button class="next-page" :disabled="!hasNext" @click="currentValue++">
-          <b-icon icon="chevron-right" variant="primary"></b-icon>
-        </b-button>
-      </b-col>
-    </b-row>
-  </div>
-</template>
-<script>
-export default {
-  name: 'PaginationButtons',
-  props: {
-    totalRows: { required: true },
-    perPage: { type: Number, required: true },
-    value: { type: Number, required: true },
-  },
-  data() {
-    return {
-      currentValue: { type: Number, default: 1 },
-    }
-  },
-  computed: {
-    hasNext() {
-      return this.value * this.perPage < this.totalRows
-    },
-    hasPrevious() {
-      return this.value > 1
-    },
-    totalPages() {
-      return Math.ceil(this.totalRows / this.perPage)
-    },
-  },
-  created() {
-    this.currentValue = this.value
-  },
-  watch: {
-    currentValue() {
-      if (this.currentValue !== this.value) this.$emit('input', this.currentValue)
-    },
-  },
-}
-</script>

From e942cd206970785ac1ac5c97d91958dfebebab07 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Tue, 5 Apr 2022 14:35:35 +0200
Subject: [PATCH 17/17] remove unused locale due to deletion of pagination
 component

---
 frontend/src/locales/de.json | 1 -
 frontend/src/locales/en.json | 1 -
 2 files changed, 2 deletions(-)

diff --git a/frontend/src/locales/de.json b/frontend/src/locales/de.json
index 80f7ded25..600b36e65 100644
--- a/frontend/src/locales/de.json
+++ b/frontend/src/locales/de.json
@@ -143,7 +143,6 @@
   "login": "Anmeldung",
   "math": {
     "aprox": "~",
-    "div": "/",
     "equal": "=",
     "exclaim": "!",
     "pipe": "|"
diff --git a/frontend/src/locales/en.json b/frontend/src/locales/en.json
index 500cceaae..ef9a14c0a 100644
--- a/frontend/src/locales/en.json
+++ b/frontend/src/locales/en.json
@@ -143,7 +143,6 @@
   "login": "Login",
   "math": {
     "aprox": "~",
-    "div": "/",
     "equal": "=",
     "exclaim": "!",
     "pipe": "|"