From ca3c07b0d82b1f85c985691625008d0b5db90d85 Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Fri, 4 Mar 2022 12:51:30 +0100
Subject: [PATCH] use forEach instead of for loop in transactions, simplified
 code

---
 .../src/graphql/resolver/TransactionResolver.ts   | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts
index 969a64e32..eae7f738d 100644
--- a/backend/src/graphql/resolver/TransactionResolver.ts
+++ b/backend/src/graphql/resolver/TransactionResolver.ts
@@ -119,16 +119,13 @@ export class TransactionResolver {
     }
 
     // transactions
-    for (let i = 0; i < userTransactions.length; i++) {
-      const userTransaction = userTransactions[i]
-      let linkedUser = null
-      if (userTransaction.typeId === TransactionTypeId.CREATION) {
-        linkedUser = communityUser
-      } else {
-        linkedUser = involvedUsers.find((u) => u.id === userTransaction.linkedUserId)
-      }
+    userTransactions.forEach((userTransaction) => {
+      const linkedUser =
+        userTransaction.typeId === TransactionTypeId.CREATION
+          ? communityUser
+          : involvedUsers.find((u) => u.id === userTransaction.linkedUserId)
       transactions.push(new Transaction(userTransaction, self, linkedUser))
-    }
+    })
 
     // Construct Result
     return new TransactionList(