IT4Change/gradido
3
0
Fork 0
mirror of https://github.com/IT4Change/gradido.git synced 2025-12-13 07:45:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

deleteTransactionLink mutation returns boolean, no more to does

Browse Source
This commit is contained in:
Moriz Wahl 2022-03-10 18:25:54 +01:00
parent ff9dde8870
commit cb4e6da317
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
backend/src/graphql/resolver/TransactionLinkResolver.ts
View File

@ -69,11 +69,8 @@ export class TransactionLinkResolver {
}
@Authorized([RIGHTS.DELETE_TRANSACTION_LINK])
@Mutation(() => Date, { nullable: true })
async deleteTransactionLink(
@Arg('id') id: number,
@Ctx() context: any,
): Promise<Date | null | undefined> {
@Mutation(() => Boolean)
async deleteTransactionLink(@Arg('id') id: number, @Ctx() context: any): Promise<boolean> {
const userRepository = getCustomRepository(UserRepository)
const user = await userRepository.findByPubkeyHex(context.pubKey)
@ -82,7 +79,6 @@ export class TransactionLinkResolver {
throw new Error('Transaction Link not found!')
}
// TODO: admin can delete links?
if (transactionLink.userId !== user.id) {
throw new Error('Transaction Link cannot be deleted!')
}
@ -91,8 +87,10 @@ export class TransactionLinkResolver {
throw new Error('Transaction Link already redeemed!')
}
await transactionLink.softRemove()
const newLink = await dbTransactionLink.findOne({ id }, { withDeleted: true })
return newLink ? newLink.deletedAt : null
await transactionLink.softRemove().catch(() => {
throw new Error('Transaction Link could not be deleted!')
})
return true
}
}