From d21996a045853deea3e29b5ba48a7c67bc1ddf6f Mon Sep 17 00:00:00 2001
From: Ulf Gebhardt <ulf.gebhardt@webcraft-media.de>
Date: Fri, 17 Feb 2023 23:10:31 +0100
Subject: [PATCH] externalize transactionLinkList function into utils folder

---
 .../resolver/TransactionLinkResolver.ts       | 34 +----------------
 .../resolver/util/transactionLinkList.ts      | 37 +++++++++++++++++++
 2 files changed, 39 insertions(+), 32 deletions(-)
 create mode 100644 backend/src/graphql/resolver/util/transactionLinkList.ts

diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.ts b/backend/src/graphql/resolver/TransactionLinkResolver.ts
index 174134aa6..e0c12d7a7 100644
--- a/backend/src/graphql/resolver/TransactionLinkResolver.ts
+++ b/backend/src/graphql/resolver/TransactionLinkResolver.ts
@@ -1,7 +1,7 @@
 import { randomBytes } from 'crypto'
 import Decimal from 'decimal.js-light'
 
-import { getConnection, MoreThan } from '@dbTools/typeorm'
+import { getConnection } from '@dbTools/typeorm'
 
 import { TransactionLink as DbTransactionLink } from '@entity/TransactionLink'
 import { User as DbUser } from '@entity/User'
@@ -13,7 +13,6 @@ import { User } from '@model/User'
 import { ContributionLink } from '@model/ContributionLink'
 import { Decay } from '@model/Decay'
 import { TransactionLink, TransactionLinkResult } from '@model/TransactionLink'
-import { Order } from '@enum/Order'
 import { ContributionType } from '@enum/ContributionType'
 import { ContributionStatus } from '@enum/ContributionStatus'
 import { TransactionTypeId } from '@enum/TransactionTypeId'
@@ -35,6 +34,7 @@ import { TRANSACTIONS_LOCK } from '@/util/TRANSACTIONS_LOCK'
 import LogError from '@/server/LogError'
 
 import { getLastTransaction } from './util/getLastTransaction'
+import transactionLinkList from './util/transactionLinkList'
 
 // TODO: do not export, test it inside the resolver
 export const transactionLinkCode = (date: Date): string => {
@@ -350,33 +350,3 @@ export class TransactionLinkResolver {
     return transactionLinkList(paginated, filters, await DbUser.findOneOrFail({ id: userId }))
   }
 }
-
-const transactionLinkList = async (
-  { currentPage = 1, pageSize = 5, order = Order.DESC }: Paginated,
-  filters: TransactionLinkFilters | null,
-  user: DbUser,
-): Promise<TransactionLinkResult> => {
-  const { withDeleted, withExpired, withRedeemed } = filters || {
-    withDeleted: false,
-    withExpired: false,
-    withRedeemed: false,
-  }
-  const [transactionLinks, count] = await DbTransactionLink.findAndCount({
-    where: {
-      user: user.id,
-      ...(!withRedeemed && { redeemedBy: null }),
-      ...(!withExpired && { validUntil: MoreThan(new Date()) }),
-    },
-    withDeleted,
-    order: {
-      createdAt: order,
-    },
-    skip: (currentPage - 1) * pageSize,
-    take: pageSize,
-  })
-
-  return {
-    count,
-    links: transactionLinks.map((tl) => new TransactionLink(tl, user)),
-  }
-}
diff --git a/backend/src/graphql/resolver/util/transactionLinkList.ts b/backend/src/graphql/resolver/util/transactionLinkList.ts
new file mode 100644
index 000000000..48a91920d
--- /dev/null
+++ b/backend/src/graphql/resolver/util/transactionLinkList.ts
@@ -0,0 +1,37 @@
+import { MoreThan } from '@dbTools/typeorm'
+import { TransactionLink as DbTransactionLink } from '@entity/TransactionLink'
+import { User as DbUser } from '@entity/User'
+import { Order } from '@enum/Order'
+import Paginated from '@arg/Paginated'
+import TransactionLinkFilters from '@arg/TransactionLinkFilters'
+import { TransactionLink, TransactionLinkResult } from '@model/TransactionLink'
+
+export default async function transactionLinkList(
+  { currentPage = 1, pageSize = 5, order = Order.DESC }: Paginated,
+  filters: TransactionLinkFilters | null,
+  user: DbUser,
+): Promise<TransactionLinkResult> {
+  const { withDeleted, withExpired, withRedeemed } = filters || {
+    withDeleted: false,
+    withExpired: false,
+    withRedeemed: false,
+  }
+  const [transactionLinks, count] = await DbTransactionLink.findAndCount({
+    where: {
+      user: user.id,
+      ...(!withRedeemed && { redeemedBy: null }),
+      ...(!withExpired && { validUntil: MoreThan(new Date()) }),
+    },
+    withDeleted,
+    order: {
+      createdAt: order,
+    },
+    skip: (currentPage - 1) * pageSize,
+    take: pageSize,
+  })
+
+  return {
+    count,
+    links: transactionLinks.map((tl) => new TransactionLink(tl, user)),
+  }
+}