From d5782735896c61abc774292a4a9bdea2b192711e Mon Sep 17 00:00:00 2001 From: Moriz Wahl Date: Mon, 3 Apr 2023 14:17:42 +0200 Subject: [PATCH] correct calculation of previuos balance --- backend/src/graphql/model/Transaction.ts | 2 +- backend/src/graphql/resolver/TransactionResolver.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/backend/src/graphql/model/Transaction.ts b/backend/src/graphql/model/Transaction.ts index dc20a5c83..50ca7d098 100644 --- a/backend/src/graphql/model/Transaction.ts +++ b/backend/src/graphql/model/Transaction.ts @@ -52,7 +52,7 @@ export class Transaction { this.linkId = transaction.contribution ? transaction.contribution.contributionLinkId : transaction.transactionLinkId || null - this.previousBalance = previuosBalance + this.previousBalance = previuosBalance.toDecimalPlaces(2, Decimal.ROUND_DOWN) } @Field(() => Int) diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts index 8c51c6681..72e919dad 100644 --- a/backend/src/graphql/resolver/TransactionResolver.ts +++ b/backend/src/graphql/resolver/TransactionResolver.ts @@ -288,7 +288,8 @@ export class TransactionResolver { userTransaction.typeId === TransactionTypeId.CREATION ? communityUser : involvedUsers.find((u) => u.id === userTransaction.linkedUserId) - const previousBalance = idx ? userTransactions[idx - 1].balance : new Decimal(0) + const previousBalance = + idx < userTransactions.length - 1 ? userTransactions[idx + 1].balance : new Decimal(0) transactions.push(new Transaction(userTransaction, self, linkedUser, previousBalance)) }) logger.debug(`TransactionTypeId.CREATION: transactions=${transactions}`)