From d642bff68324b836e206edef3dc18f080d83c8a4 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Mon, 1 Nov 2021 00:08:53 +0100 Subject: [PATCH] optimization: save private key always --- backend/src/graphql/resolver/UserResolver.ts | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/backend/src/graphql/resolver/UserResolver.ts b/backend/src/graphql/resolver/UserResolver.ts index 8089fc677..8ca10b748 100644 --- a/backend/src/graphql/resolver/UserResolver.ts +++ b/backend/src/graphql/resolver/UserResolver.ts @@ -120,11 +120,7 @@ const KeyPairEd25519Create = (passphrase: string[]): Buffer[] => { return [pubKey, privKey] } -const generateKeys = async ( - email: string, - savePrivkey: boolean, - savePassphrase: boolean, -): Promise => { +const generateKeys = async (email: string, savePassphrase: boolean): Promise => { const mNewUser = await LoginUser.findOneOrFail({ email }) const lang = mNewUser.language /* @@ -150,10 +146,7 @@ const generateKeys = async ( const gradidoKeyPair = KeyPairEd25519Create(passphrase) mNewUser.pubKey = gradidoKeyPair[0] - - if (savePrivkey) { - mNewUser.privKey = gradidoKeyPair[1] - } + mNewUser.privKey = gradidoKeyPair[1] await mNewUser.save().catch(() => { throw new Error(`Error saving new generated pub/priv keys, email: ${email}`) @@ -307,7 +300,7 @@ export class UserResolver { throw new Error('insert user failed') }) - const keys = await generateKeys(email, true, true) + const keys = await generateKeys(email, true) const pubkey = keys[0] // TODO: we do not login the user as before, since session management is not yet ported