From e461b792ca8870f2728244eb0fd6408fe88237c6 Mon Sep 17 00:00:00 2001 From: Dario Rekowski on RockPI Date: Wed, 19 Feb 2020 09:24:19 +0000 Subject: [PATCH] update error reporting --- src/Model/Transactions/TransactionCreation.php | 5 +++++ src/Model/Transactions/TransactionTransfer.php | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/src/Model/Transactions/TransactionCreation.php b/src/Model/Transactions/TransactionCreation.php index 2864a4266..a2d6e2a08 100644 --- a/src/Model/Transactions/TransactionCreation.php +++ b/src/Model/Transactions/TransactionCreation.php @@ -172,6 +172,11 @@ class TransactionCreation extends TransactionBase { $emailViewBuilder = $email->viewBuilder(); $emailViewBuilder->setTemplate('notificationCreation') ->setVars(['user' => $receiverUser, 'gdd_cent' => $this->getAmount(), 'memo' => $memo]); + $receiverNames = $receiverUser->getNames(); + if($receiverNames == '' || $receiverUser->email == '') { + $this->addError('TransactionCreation::sendNotificationEmail', 'to email is empty for user: ' . $receiverUser->id); + return false; + } $email->setFrom([$noReplyEmail => 'Nicht antworten']) ->setTo([$receiverUser->email => $receiverUser->getNames()]) ->setSubject(__('Gradido Schöpfung erhalten')) diff --git a/src/Model/Transactions/TransactionTransfer.php b/src/Model/Transactions/TransactionTransfer.php index a82173a28..c89a0f175 100644 --- a/src/Model/Transactions/TransactionTransfer.php +++ b/src/Model/Transactions/TransactionTransfer.php @@ -232,7 +232,11 @@ class TransactionTransfer extends TransactionBase { 'senderUser' => $senderUser, 'gdd_cent' => $receiverAmount->getAmount(), 'memo' => $memo]); - + $receiverNames = $receiverUser->getNames(); + if($receiverNames == '' || $receiverUser->email == '') { + $this->addError('TransactionCreation::sendNotificationEmail', 'to email is empty for user: ' . $receiverUser->id); + return false; + } $email->setFrom([$serverAdminEmail => $senderUser->getNames() . ' via Gradido Community']) ->setTo([$receiverUser->email => $receiverUser->getNames()]) ->setReplyTo($senderUser->email)