From a7e34ca6af8bbe8a4182dd5c1ea37528ae065e9d Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Tue, 30 May 2023 09:44:41 +0200 Subject: [PATCH 1/3] remove function getSeed --- dht-node/src/dht_node/index.ts | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/dht-node/src/dht_node/index.ts b/dht-node/src/dht_node/index.ts index 36291904a..d0ae1e67b 100644 --- a/dht-node/src/dht_node/index.ts +++ b/dht-node/src/dht_node/index.ts @@ -8,11 +8,6 @@ import { Community as DbCommunity } from '@entity/Community' import { v4 as uuidv4 } from 'uuid' const KEY_SECRET_SEEDBYTES = 32 -const getSeed = (): Buffer | null => { - return CONFIG.FEDERATION_DHT_SEED - ? Buffer.alloc(KEY_SECRET_SEEDBYTES, CONFIG.FEDERATION_DHT_SEED) - : null -} const POLLTIME = 20000 const SUCCESSTIME = 120000 @@ -32,7 +27,9 @@ export type CommunityApi = { export const startDHT = async (topic: string): Promise => { try { const TOPIC = DHT.hash(Buffer.from(topic)) - const keyPair = DHT.keyPair(getSeed()) + const keyPair = DHT.keyPair(CONFIG.FEDERATION_DHT_SEED + ? Buffer.alloc(KEY_SECRET_SEEDBYTES, CONFIG.FEDERATION_DHT_SEED) + : null) const pubKeyString = keyPair.publicKey.toString('hex') logger.info(`keyPairDHT: publicKey=${pubKeyString}`) logger.debug(`keyPairDHT: secretKey=${keyPair.secretKey.toString('hex')}`) From 24df41365a37571c0693d897ac3b21b79f1ce4bd Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Tue, 30 May 2023 09:51:33 +0200 Subject: [PATCH 2/3] linting --- dht-node/src/dht_node/index.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/dht-node/src/dht_node/index.ts b/dht-node/src/dht_node/index.ts index d0ae1e67b..75cecc3a7 100644 --- a/dht-node/src/dht_node/index.ts +++ b/dht-node/src/dht_node/index.ts @@ -27,9 +27,11 @@ export type CommunityApi = { export const startDHT = async (topic: string): Promise => { try { const TOPIC = DHT.hash(Buffer.from(topic)) - const keyPair = DHT.keyPair(CONFIG.FEDERATION_DHT_SEED - ? Buffer.alloc(KEY_SECRET_SEEDBYTES, CONFIG.FEDERATION_DHT_SEED) - : null) + const keyPair = DHT.keyPair( + CONFIG.FEDERATION_DHT_SEED + ? Buffer.alloc(KEY_SECRET_SEEDBYTES, CONFIG.FEDERATION_DHT_SEED) + : null, + ) const pubKeyString = keyPair.publicKey.toString('hex') logger.info(`keyPairDHT: publicKey=${pubKeyString}`) logger.debug(`keyPairDHT: secretKey=${keyPair.secretKey.toString('hex')}`) From adc6998617899a9b22880023d4144777c6acaafc Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Tue, 6 Jun 2023 11:09:22 +0200 Subject: [PATCH 3/3] include comment to explain key pair tenary --- dht-node/src/dht_node/index.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/dht-node/src/dht_node/index.ts b/dht-node/src/dht_node/index.ts index 75cecc3a7..ca00a5cee 100644 --- a/dht-node/src/dht_node/index.ts +++ b/dht-node/src/dht_node/index.ts @@ -27,6 +27,7 @@ export type CommunityApi = { export const startDHT = async (topic: string): Promise => { try { const TOPIC = DHT.hash(Buffer.from(topic)) + // uses a config defined seed or null, which will generate a random seed for the key pair const keyPair = DHT.keyPair( CONFIG.FEDERATION_DHT_SEED ? Buffer.alloc(KEY_SECRET_SEEDBYTES, CONFIG.FEDERATION_DHT_SEED)