From e8114e40837aafa62266821ac8c39d5ecc4f7d70 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Tue, 14 Mar 2023 20:04:28 +0100 Subject: [PATCH] remove mul -1 for congruency --- backend/src/graphql/resolver/TransactionResolver.ts | 3 +-- database/migrations/0061-event_refactoring.ts | 5 +++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts index 3145a999e..c3f4b5d48 100644 --- a/backend/src/graphql/resolver/TransactionResolver.ts +++ b/backend/src/graphql/resolver/TransactionResolver.ts @@ -142,8 +142,7 @@ export const executeTransaction = async ( sender, recipient, transactionSend, - // TODO why mul -1? - transactionSend.amount.mul(-1), + transactionSend.amount, ) await EVENT_TRANSACTION_RECEIVE( diff --git a/database/migrations/0061-event_refactoring.ts b/database/migrations/0061-event_refactoring.ts index eec403acc..019d3272b 100644 --- a/database/migrations/0061-event_refactoring.ts +++ b/database/migrations/0061-event_refactoring.ts @@ -58,6 +58,8 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis 'UPDATE `events` SET acting_user_id=involved_user_id WHERE `type` = "TRANSACTION_RECEIVE";', ) + await queryFn('UPDATE `events` SET amount = amount * -1 WHERE `type` = "TRANSACTION_SEND";') + await queryFn( 'ALTER TABLE `events` MODIFY COLUMN `created_at` datetime(3) NOT NULL DEFAULT CURRENT_TIMESTAMP(3);', ) @@ -67,6 +69,9 @@ export async function downgrade(queryFn: (query: string, values?: any[]) => Prom await queryFn( 'ALTER TABLE `events` MODIFY COLUMN `created_at` datetime NOT NULL DEFAULT CURRENT_TIMESTAMP();', ) + + await queryFn('UPDATE `events` SET amount = amount * -1 WHERE `type` = "TRANSACTION_SEND";') + await queryFn( 'UPDATE `events` SET involved_user_id=acting_user_id WHERE `type` = "ADMIN_CONTRIBUTION_DENY";', )