From ebcc73c153a4a25400494fc2284170b842b9d92b Mon Sep 17 00:00:00 2001
From: ogerly <fridolin@tutanota.com>
Date: Fri, 11 Mar 2022 10:34:39 +0100
Subject: [PATCH] change review from Ulf, rename File Memo.vue to MemoRow.vue,
 add required on props

---
 frontend/src/components/GddTransactionList.vue     |  4 ++++
 frontend/src/components/GdtTransactionList.vue     |  5 -----
 .../components/TransactionRows/AmountAndName.vue   | 14 ++++++++++++--
 .../components/TransactionRows/CollapseIcon.vue    |  1 +
 .../src/components/TransactionRows/DateRow.vue     |  1 +
 .../src/components/TransactionRows/DecayRow.vue    |  1 +
 .../TransactionRows/{Memo.vue => MemoRow.vue}      |  5 +++--
 .../src/components/TransactionRows/TypeIcon.vue    |  2 ++
 .../Transactions/TransactionCreation.vue           |  6 +++---
 .../components/Transactions/TransactionReceive.vue |  6 +++---
 .../components/Transactions/TransactionSend.vue    |  6 +++---
 11 files changed, 33 insertions(+), 18 deletions(-)
 rename frontend/src/components/TransactionRows/{Memo.vue => MemoRow.vue} (83%)

diff --git a/frontend/src/components/GddTransactionList.vue b/frontend/src/components/GddTransactionList.vue
index c3f3d4d7e..3b4cd961d 100644
--- a/frontend/src/components/GddTransactionList.vue
+++ b/frontend/src/components/GddTransactionList.vue
@@ -108,6 +108,10 @@ export default {
 }
 </script>
 <style>
+collaps-icon {
+  width: 95%;
+  position: absolute;
+}
 .el-table .cell {
   padding-left: 0px;
   padding-right: 0px;
diff --git a/frontend/src/components/GdtTransactionList.vue b/frontend/src/components/GdtTransactionList.vue
index 168bf6ae7..0c061ed06 100644
--- a/frontend/src/components/GdtTransactionList.vue
+++ b/frontend/src/components/GdtTransactionList.vue
@@ -89,11 +89,6 @@ export default {
 }
 </script>
 <style>
-collaps-icon {
-  width: 95%;
-  position: absolute;
-}
-
 .el-table .cell {
   padding-left: 0px;
   padding-right: 0px;
diff --git a/frontend/src/components/TransactionRows/AmountAndName.vue b/frontend/src/components/TransactionRows/AmountAndName.vue
index 24cbe8d1c..36a079846 100644
--- a/frontend/src/components/TransactionRows/AmountAndName.vue
+++ b/frontend/src/components/TransactionRows/AmountAndName.vue
@@ -10,7 +10,7 @@
       </b-col>
       <b-col cols="7">
         <div class="gdd-transaction-list-item-name">
-          {{ linkedUser ? linkedUser.firstName + ' ' + linkedUser.lastName : text }}
+          {{ itemText }}
         </div>
       </b-col>
     </b-row>
@@ -18,16 +18,26 @@
 </template>
 <script>
 export default {
-  name: 'AmountAndName',
+  name: 'Amount-And-Name',
   props: {
     amount: {
       type: String,
+      required: true,
     },
     linkedUser: {
       type: Object,
+      required: false,
     },
     text: {
       type: String,
+      required: false,
+    },
+  },
+  computed: {
+    itemText() {
+      return this.linkedUser
+        ? this.linkedUser.firstName + ' ' + this.linkedUser.lastName
+        : this.text
     },
   },
 }
diff --git a/frontend/src/components/TransactionRows/CollapseIcon.vue b/frontend/src/components/TransactionRows/CollapseIcon.vue
index a51efd640..f2032243f 100644
--- a/frontend/src/components/TransactionRows/CollapseIcon.vue
+++ b/frontend/src/components/TransactionRows/CollapseIcon.vue
@@ -12,6 +12,7 @@ export default {
   props: {
     visible: {
       type: Boolean,
+      required: true,
     },
   },
 }
diff --git a/frontend/src/components/TransactionRows/DateRow.vue b/frontend/src/components/TransactionRows/DateRow.vue
index 7883507db..87f2d2dcd 100644
--- a/frontend/src/components/TransactionRows/DateRow.vue
+++ b/frontend/src/components/TransactionRows/DateRow.vue
@@ -19,6 +19,7 @@ export default {
   props: {
     balanceDate: {
       type: String,
+      required: true,
     },
   },
 }
diff --git a/frontend/src/components/TransactionRows/DecayRow.vue b/frontend/src/components/TransactionRows/DecayRow.vue
index d8b969706..f805379d4 100644
--- a/frontend/src/components/TransactionRows/DecayRow.vue
+++ b/frontend/src/components/TransactionRows/DecayRow.vue
@@ -24,6 +24,7 @@ export default {
   props: {
     decay: {
       type: Object,
+      required: false,
     },
   },
 }
diff --git a/frontend/src/components/TransactionRows/Memo.vue b/frontend/src/components/TransactionRows/MemoRow.vue
similarity index 83%
rename from frontend/src/components/TransactionRows/Memo.vue
rename to frontend/src/components/TransactionRows/MemoRow.vue
index a25892e80..61e025d1d 100644
--- a/frontend/src/components/TransactionRows/Memo.vue
+++ b/frontend/src/components/TransactionRows/MemoRow.vue
@@ -1,5 +1,5 @@
 <template>
-  <div class="memo">
+  <div class="memo-row">
     <b-row>
       <b-col cols="5">
         <div class="text-right">{{ $t('form.memo') }}</div>
@@ -12,10 +12,11 @@
 </template>
 <script>
 export default {
-  name: 'Memo',
+  name: 'Memo-Row',
   props: {
     memo: {
       type: String,
+      required: false,
     },
   },
 }
diff --git a/frontend/src/components/TransactionRows/TypeIcon.vue b/frontend/src/components/TransactionRows/TypeIcon.vue
index 00dedd77a..199a6436c 100644
--- a/frontend/src/components/TransactionRows/TypeIcon.vue
+++ b/frontend/src/components/TransactionRows/TypeIcon.vue
@@ -11,9 +11,11 @@ export default {
   props: {
     icon: {
       type: String,
+      required: true,
     },
     color: {
       type: String,
+      required: true,
     },
   },
 }
diff --git a/frontend/src/components/Transactions/TransactionCreation.vue b/frontend/src/components/Transactions/TransactionCreation.vue
index 8801e4f20..980360cb4 100644
--- a/frontend/src/components/Transactions/TransactionCreation.vue
+++ b/frontend/src/components/Transactions/TransactionCreation.vue
@@ -16,7 +16,7 @@
             <amount-and-name :amount="amount" :linkedUser="linkedUser" />
 
             <!-- Nachricht Memo -->
-            <memo :memo="memo" />
+            <memo-row :memo="memo" />
 
             <!-- Datum -->
             <date-row :balanceDate="balanceDate" />
@@ -42,7 +42,7 @@
 import CollapseIcon from '../TransactionRows/CollapseIcon'
 import TypeIcon from '../TransactionRows/TypeIcon'
 import AmountAndName from '../TransactionRows/AmountAndName'
-import Memo from '../TransactionRows/Memo'
+import MemoRow from '../TransactionRows/MemoRow'
 import DateRow from '../TransactionRows/DateRow'
 import DecayRow from '../TransactionRows/DecayRow'
 import DecayInformation from '../DecayInformations/DecayInformation'
@@ -53,7 +53,7 @@ export default {
     CollapseIcon,
     TypeIcon,
     AmountAndName,
-    Memo,
+    MemoRow,
     DateRow,
     DecayRow,
     DecayInformation,
diff --git a/frontend/src/components/Transactions/TransactionReceive.vue b/frontend/src/components/Transactions/TransactionReceive.vue
index 215b7cee3..b57fcc3b1 100644
--- a/frontend/src/components/Transactions/TransactionReceive.vue
+++ b/frontend/src/components/Transactions/TransactionReceive.vue
@@ -16,7 +16,7 @@
             <amount-and-name :amount="amount" :linkedUser="linkedUser" />
 
             <!-- Nachricht Memo -->
-            <memo :memo="memo" />
+            <memo-row :memo="memo" />
 
             <!-- Datum -->
             <date-row :balanceDate="balanceDate" />
@@ -42,7 +42,7 @@
 import CollapseIcon from '../TransactionRows/CollapseIcon'
 import TypeIcon from '../TransactionRows/TypeIcon'
 import AmountAndName from '../TransactionRows/AmountAndName'
-import Memo from '../TransactionRows/Memo'
+import MemoRow from '../TransactionRows/MemoRow'
 import DateRow from '../TransactionRows/DateRow'
 import DecayRow from '../TransactionRows/DecayRow'
 import DecayInformation from '../DecayInformations/DecayInformation'
@@ -53,7 +53,7 @@ export default {
     CollapseIcon,
     TypeIcon,
     AmountAndName,
-    Memo,
+    MemoRow,
     DateRow,
     DecayRow,
     DecayInformation,
diff --git a/frontend/src/components/Transactions/TransactionSend.vue b/frontend/src/components/Transactions/TransactionSend.vue
index b59d2571f..8ce6e44d0 100644
--- a/frontend/src/components/Transactions/TransactionSend.vue
+++ b/frontend/src/components/Transactions/TransactionSend.vue
@@ -16,7 +16,7 @@
             <amount-and-name :amount="amount" :linkedUser="linkedUser" />
 
             <!-- Memo -->
-            <memo :memo="memo" />
+            <memo-row :memo="memo" />
 
             <!-- Datum -->
             <date-row :balanceDate="balanceDate" />
@@ -42,7 +42,7 @@
 import CollapseIcon from '../TransactionRows/CollapseIcon'
 import TypeIcon from '../TransactionRows/TypeIcon'
 import AmountAndName from '../TransactionRows/AmountAndName'
-import Memo from '../TransactionRows/Memo'
+import MemoRow from '../TransactionRows/MemoRow'
 import DateRow from '../TransactionRows/DateRow'
 import DecayRow from '../TransactionRows/DecayRow'
 import DecayInformation from '../DecayInformations/DecayInformation'
@@ -53,7 +53,7 @@ export default {
     CollapseIcon,
     TypeIcon,
     AmountAndName,
-    Memo,
+    MemoRow,
     DateRow,
     DecayRow,
     DecayInformation,