From 4c3a0728e891ac7a41bcc2458646885b6b09e198 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Wed, 7 Jun 2023 13:43:18 +0200 Subject: [PATCH 1/3] enable eslint comments linting --- database/.eslintrc.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/database/.eslintrc.js b/database/.eslintrc.js index 587506ecc..dacb123ea 100644 --- a/database/.eslintrc.js +++ b/database/.eslintrc.js @@ -13,7 +13,7 @@ module.exports = { // 'plugin:import/recommended', // 'plugin:import/typescript', // 'plugin:security/recommended', - // 'plugin:@eslint-community/eslint-comments/recommended', + 'plugin:@eslint-community/eslint-comments/recommended', ], settings: { 'import/parsers': { @@ -155,10 +155,10 @@ module.exports = { // 'promise/prefer-await-to-callbacks': 'error', // 'promise/no-multiple-resolved': 'error', // eslint comments - // '@eslint-community/eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }], - // '@eslint-community/eslint-comments/no-restricted-disable': 'error', - // '@eslint-community/eslint-comments/no-use': 'off', - // '@eslint-community/eslint-comments/require-description': 'off', + '@eslint-community/eslint-comments/disable-enable-pair': ['error', { allowWholeFile: true }], + '@eslint-community/eslint-comments/no-restricted-disable': 'error', + '@eslint-community/eslint-comments/no-use': 'off', + '@eslint-community/eslint-comments/require-description': 'off', }, overrides: [ // only for ts files From a2f22e0c5ca1d392f01537b9da668159a28d8e40 Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Wed, 7 Jun 2023 13:43:25 +0200 Subject: [PATCH 2/3] fix comment linting --- database/migrations/0054-recalculate_balance_and_decay.ts | 3 +-- database/migrations/0055-consistent_deleted_users.ts | 3 +-- database/migrations/0056-consistent_transactions_table.ts | 3 +-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/database/migrations/0054-recalculate_balance_and_decay.ts b/database/migrations/0054-recalculate_balance_and_decay.ts index b2add3a58..acbe345f0 100644 --- a/database/migrations/0054-recalculate_balance_and_decay.ts +++ b/database/migrations/0054-recalculate_balance_and_decay.ts @@ -156,6 +156,5 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis } } -/* eslint-disable @typescript-eslint/no-empty-function */ -/* eslint-disable-next-line @typescript-eslint/no-unused-vars */ +/* eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/no-empty-function */ export async function downgrade(queryFn: (query: string, values?: any[]) => Promise>) {} diff --git a/database/migrations/0055-consistent_deleted_users.ts b/database/migrations/0055-consistent_deleted_users.ts index 561e0541a..93d5cb575 100644 --- a/database/migrations/0055-consistent_deleted_users.ts +++ b/database/migrations/0055-consistent_deleted_users.ts @@ -11,6 +11,5 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis AND users.deleted_at IS NOT NULL;`) } -/* eslint-disable @typescript-eslint/no-empty-function */ -/* eslint-disable-next-line @typescript-eslint/no-unused-vars */ +/* eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/no-empty-function */ export async function downgrade(queryFn: (query: string, values?: any[]) => Promise>) {} diff --git a/database/migrations/0056-consistent_transactions_table.ts b/database/migrations/0056-consistent_transactions_table.ts index 02ed3b7be..0d8721f07 100644 --- a/database/migrations/0056-consistent_transactions_table.ts +++ b/database/migrations/0056-consistent_transactions_table.ts @@ -34,6 +34,5 @@ export async function upgrade(queryFn: (query: string, values?: any[]) => Promis } } -/* eslint-disable @typescript-eslint/no-empty-function */ -/* eslint-disable-next-line @typescript-eslint/no-unused-vars */ +/* eslint-disable-next-line @typescript-eslint/no-unused-vars, @typescript-eslint/no-empty-function */ export async function downgrade(queryFn: (query: string, values?: any[]) => Promise>) {} From 414640048f16ac905199848d9527668477761142 Mon Sep 17 00:00:00 2001 From: elweyn Date: Thu, 15 Jun 2023 13:44:49 +0200 Subject: [PATCH 3/3] change location of eslint-disable. --- database/migrations/0028-decimal_types.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/database/migrations/0028-decimal_types.ts b/database/migrations/0028-decimal_types.ts index e79d120a8..ff92c5698 100644 --- a/database/migrations/0028-decimal_types.ts +++ b/database/migrations/0028-decimal_types.ts @@ -20,7 +20,6 @@ /* eslint-disable @typescript-eslint/explicit-module-boundary-types */ /* eslint-disable @typescript-eslint/no-explicit-any */ -/* eslint-disable no-unused-vars */ import Decimal from 'decimal.js-light' @@ -41,11 +40,13 @@ interface Decay { duration: number | null } +/* eslint-disable no-unused-vars */ export enum TransactionTypeId { CREATION = 1, SEND = 2, RECEIVE = 3, } +/* eslint-enable no-unused-vars */ function decayFormula(value: Decimal, seconds: number): Decimal { return value.mul(new Decimal('0.99999997803504048973201202316767079413460520837376').pow(seconds))