From fc90df97656e06dc416b3130c42e0494a20ac068 Mon Sep 17 00:00:00 2001 From: Claus-Peter Huebner Date: Thu, 27 Jul 2023 02:17:55 +0200 Subject: [PATCH] shift dltTx-creation in send-function --- backend/src/graphql/resolver/ContributionResolver.ts | 8 +------- .../src/graphql/resolver/TransactionLinkResolver.ts | 8 +------- backend/src/graphql/resolver/TransactionResolver.ts | 12 +----------- 3 files changed, 3 insertions(+), 25 deletions(-) diff --git a/backend/src/graphql/resolver/ContributionResolver.ts b/backend/src/graphql/resolver/ContributionResolver.ts index 4e66552be..94c47d279 100644 --- a/backend/src/graphql/resolver/ContributionResolver.ts +++ b/backend/src/graphql/resolver/ContributionResolver.ts @@ -536,16 +536,10 @@ export class ContributionResolver { contribution.contributionStatus = ContributionStatus.CONFIRMED await queryRunner.manager.update(DbContribution, { id: contribution.id }, contribution) - const dltTx = DltTransaction.create() - dltTx.transactionId = transaction.id - await DltTransaction.save(dltTx) - await queryRunner.commitTransaction() // trigger to send transaction via dlt-connector - sendTransactionsToDltConnector().catch((e) => { - logger.error('error on sending transactions to DltConnector:', e) - }) + void sendTransactionsToDltConnector() logger.info('creation commited successfuly.') void sendContributionConfirmedEmail({ diff --git a/backend/src/graphql/resolver/TransactionLinkResolver.ts b/backend/src/graphql/resolver/TransactionLinkResolver.ts index 3ea65cadb..910f6a5b0 100644 --- a/backend/src/graphql/resolver/TransactionLinkResolver.ts +++ b/backend/src/graphql/resolver/TransactionLinkResolver.ts @@ -291,10 +291,6 @@ export class TransactionLinkResolver { contribution.transactionId = transaction.id await queryRunner.manager.update(DbContribution, { id: contribution.id }, contribution) - const dltTx = DltTransaction.create() - dltTx.transactionId = transaction.id - await DltTransaction.save(dltTx) - await queryRunner.commitTransaction() await EVENT_CONTRIBUTION_LINK_REDEEM( @@ -314,9 +310,7 @@ export class TransactionLinkResolver { releaseLock() } // trigger to send transaction via dlt-connector - sendTransactionsToDltConnector().catch((e) => { - logger.error('error on sending transactions to DltConnector:', e) - }) + void sendTransactionsToDltConnector() return true } else { const now = new Date() diff --git a/backend/src/graphql/resolver/TransactionResolver.ts b/backend/src/graphql/resolver/TransactionResolver.ts index 12308edba..aa93461c0 100644 --- a/backend/src/graphql/resolver/TransactionResolver.ts +++ b/backend/src/graphql/resolver/TransactionResolver.ts @@ -141,14 +141,6 @@ export const executeTransaction = async ( ) } - const dltTxSend = DltTransaction.create() - dltTxSend.transactionId = transactionSend.id - await DltTransaction.save(dltTxSend) - - const dltTxRec = DltTransaction.create() - dltTxRec.transactionId = transactionReceive.id - await DltTransaction.save(dltTxRec) - await queryRunner.commitTransaction() logger.info(`commit Transaction successful...`) @@ -162,9 +154,7 @@ export const executeTransaction = async ( ) // trigger to send transaction via dlt-connector - sendTransactionsToDltConnector().catch((e) => { - logger.error('error on sending transactions to DltConnector:', e) - }) + void sendTransactionsToDltConnector() } catch (e) { await queryRunner.rollbackTransaction() throw new LogError('Transaction was not successful', e)