From 2d3589e13ab7a997bb2b2d6dbdb39297fb9e1773 Mon Sep 17 00:00:00 2001 From: Michael Schramm Date: Mon, 28 Feb 2022 22:48:39 +0100 Subject: [PATCH] fix form delete --- CHANGELOG.md | 1 + src/service/form/form.delete.service.ts | 16 +++++++--------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e4eb95e..3023479 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/). ### Fixed - only update user fields in update mutation if they changed +- form delete ### Security diff --git a/src/service/form/form.delete.service.ts b/src/service/form/form.delete.service.ts index 13f9c3f..93e3785 100644 --- a/src/service/form/form.delete.service.ts +++ b/src/service/form/form.delete.service.ts @@ -14,15 +14,13 @@ export class FormDeleteService { ) { } - async delete(id: string): Promise { - await this.submissionRepository.createQueryBuilder('s') - .delete() - .where('s.form = :form', { form: id }) - .execute() + async delete(id: number): Promise { + await this.submissionRepository.delete({ + form: new FormEntity({ id }), + }) - await this.formRepository.createQueryBuilder('f') - .delete() - .where('f.id = :form', { form: id }) - .execute() + await this.formRepository.delete({ + id, + }) } }