IT4Change/ohmyform
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

got tests for send-email-notification template logic to pass

Browse Source
This commit is contained in:
David Baldwynn 2017-11-01 13:38:42 -07:00
parent cc62f6db3a
commit a7c0cdc056
3 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/libs/constants.js
View File

@ -77,5 +77,5 @@ module.exports = {
templateVariable: /<var(.*)id(.*)>(.|\n)*?<\/var>/g
},
varFormat: ['<var(.*)id="field:', '"(.*)>(.|\n)*?</var>'],
varFormat: ['<var([^<>]+)id=["\']{1}field:', '["\']{1}>([^<>]+)*?<\/var>'],
};

2
app/libs/send-email-notifications.js
View File

@ -20,7 +20,7 @@ module.exports = {
var resolvedTemplate = emailTemplate;
var that = this;
Object.keys(emailAttrs).forEach(function (key) {
resolvedTemplate = that.replaceTemplateVal(key, emailAttrs[key], resolvedTemplate);
resolvedTemplate = that.replaceTemplateVal(key, emailAttrs[key], resolvedTemplate, varFormat);
});
return resolvedTemplate;
},

12
app/tests/libs/send-email-notifications.test.js
View File

@ -54,12 +54,20 @@ describe('Send Email Notification Unit Tests', function() {
describe('Method parseTemplate', function(){
it('should be properly render a template given a valid field dict', function() {
var actualRenderedTemplate = parseTemplate(htmlTemplate, validFieldDict, constants.varFormat);
actualRenderedTemplate.should.equal(renderedTemplate);
var actualRenderedTemplate = emailNotifications.parseTemplate(htmlTemplate, validFieldDict, constants.varFormat).replace((/ |\r\n|\n|\r|\t/gm),'');
actualRenderedTemplate.should.equal(renderedTemplate.replace((/ |\r\n|\n|\r|\t/gm),''));
});
});
describe('Method replaceTemplateVal', function() {
it('should be properly replace a template var in a valid template', function() {
var expectedHtml = '<p>John Smith \
<br><var class="tag" id="field:5c9e22028e907634f45f59a6">Your Website</var> \
<br><var class="tag" id="field:56e90745f5934fc9e22028a6">Your Age</var></p>';
var actualRenderedTemplate = emailNotifications.replaceTemplateVal('56340745f59a6fc9e22028e9', validFieldDict['56340745f59a6fc9e22028e9'], htmlTemplate, constants.varFormat).replace((/ |\r\n|\n|\r|\t/gm),'');
actualRenderedTemplate.should.equal(expectedHtml.replace((/ |\r\n|\n|\r|\t/gm),''));
});
});
describe('Method send', function() {