From 1d6c4de01ae2d3539d64f4a6b494908eaef6120a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Tue, 18 Jan 2022 12:36:43 +0100 Subject: [PATCH 1/5] Refactor to configure 'COOKIE_EXPIRE_TIME' --- deployment/kubernetes/templates/webapp/ConfigMap.yml | 1 + deployment/kubernetes/values.template.yaml | 1 + 2 files changed, 2 insertions(+) diff --git a/deployment/kubernetes/templates/webapp/ConfigMap.yml b/deployment/kubernetes/templates/webapp/ConfigMap.yml index eb378f4..685f676 100644 --- a/deployment/kubernetes/templates/webapp/ConfigMap.yml +++ b/deployment/kubernetes/templates/webapp/ConfigMap.yml @@ -14,5 +14,6 @@ data: HOST: "0.0.0.0" PUBLIC_REGISTRATION: "{{ .Values.PUBLIC_REGISTRATION }}" INVITE_REGISTRATION: "{{ .Values.INVITE_REGISTRATION }}" + COOKIE_EXPIRE_TIME: "{{ .Values.COOKIE_EXPIRE_TIME }}" WEBSOCKETS_URI: "{{ .Values.WEBAPP.WEBSOCKETS_URI }}" GRAPHQL_URI: "http://{{ .Release.Name }}-backend:4000" \ No newline at end of file diff --git a/deployment/kubernetes/values.template.yaml b/deployment/kubernetes/values.template.yaml index d5f92a8..9904344 100644 --- a/deployment/kubernetes/values.template.yaml +++ b/deployment/kubernetes/values.template.yaml @@ -3,6 +3,7 @@ # change all the below if needed PUBLIC_REGISTRATION: false INVITE_REGISTRATION: false +COOKIE_EXPIRE_TIME: 730 # days (730 days, two years by default in main code, if not set here) BACKEND: # change all the below if needed From b7908e617c6f30bc55c8420a3f5f4ef63414ae6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Tue, 18 Jan 2022 12:59:47 +0100 Subject: [PATCH 2/5] Comment the new setting out, because it's the default value --- deployment/kubernetes/values.template.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployment/kubernetes/values.template.yaml b/deployment/kubernetes/values.template.yaml index 9904344..5908e3e 100644 --- a/deployment/kubernetes/values.template.yaml +++ b/deployment/kubernetes/values.template.yaml @@ -3,7 +3,7 @@ # change all the below if needed PUBLIC_REGISTRATION: false INVITE_REGISTRATION: false -COOKIE_EXPIRE_TIME: 730 # days (730 days, two years by default in main code, if not set here) +# COOKIE_EXPIRE_TIME: 730 # days (730 days, two years by default in main code, if not set here) BACKEND: # change all the below if needed From adc9f0967e4860f48ff4c218224d4d91f19f5344 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Tue, 18 Jan 2022 13:12:55 +0100 Subject: [PATCH 3/5] Revert "Comment the new setting out, because it's the default value" This reverts commit b7908e617c6f30bc55c8420a3f5f4ef63414ae6d. - I revert, because it looks like that an undefined .env variable becomes an empty string. To handle this with if statements seems to uncertain to me without intense testing! --- deployment/kubernetes/values.template.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployment/kubernetes/values.template.yaml b/deployment/kubernetes/values.template.yaml index 5908e3e..9904344 100644 --- a/deployment/kubernetes/values.template.yaml +++ b/deployment/kubernetes/values.template.yaml @@ -3,7 +3,7 @@ # change all the below if needed PUBLIC_REGISTRATION: false INVITE_REGISTRATION: false -# COOKIE_EXPIRE_TIME: 730 # days (730 days, two years by default in main code, if not set here) +COOKIE_EXPIRE_TIME: 730 # days (730 days, two years by default in main code, if not set here) BACKEND: # change all the below if needed From 96c640af0fa33df3b6c9b818ad1595823066b369 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Tue, 18 Jan 2022 13:14:49 +0100 Subject: [PATCH 4/5] Adjust comment --- deployment/kubernetes/values.template.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deployment/kubernetes/values.template.yaml b/deployment/kubernetes/values.template.yaml index 9904344..921ce3c 100644 --- a/deployment/kubernetes/values.template.yaml +++ b/deployment/kubernetes/values.template.yaml @@ -3,7 +3,7 @@ # change all the below if needed PUBLIC_REGISTRATION: false INVITE_REGISTRATION: false -COOKIE_EXPIRE_TIME: 730 # days (730 days, two years by default in main code, if not set here) +COOKIE_EXPIRE_TIME: 730 # days (730 days, two years is the default in main code) BACKEND: # change all the below if needed From 518ec8ffef001720fec36e827274b79d290d9055 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Thu, 20 Jan 2022 18:37:01 +0100 Subject: [PATCH 5/5] Add 'TODO-next-update.md' --- TODO-next-update.md | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 TODO-next-update.md diff --git a/TODO-next-update.md b/TODO-next-update.md new file mode 100644 index 0000000..a2608d5 --- /dev/null +++ b/TODO-next-update.md @@ -0,0 +1,13 @@ +# Todo For Next Update + +When you overtake this deploy and rebrand repo to your network you have to recognize the following changes and doings … + +## This Latest Version > 1.0.7 with 'ocelotDockerVersionTag' 1.0.7-171 + +### PR – feat: 🍰 Configure Cookie Expire Time #43 + +- You have to add the `COOKIE_EXPIRE_TIME` from the `deployment/kubernetes/values.template.yaml` to your `deployment/kubernetes/values.yaml` and set it to your prevered value. + +## Version 1.0.7 with 'ocelotDockerVersionTag' 1.0.7-171 + +- No informations.