Merge pull request #36 from utopia-os/lint-catchall

feat(other): lint catchall

.eslintrc.js

@@ -25,7 +25,7 @@ module.exports = {
     'import',
     'promise',
     // 'security',
-    // 'no-catch-all',
+    'no-catch-all',
     'react',
     'react-hooks',
   ],
@@ -44,7 +44,7 @@ module.exports = {
     'react-hooks/rules-of-hooks': 'error', // Checks rules of Hooks
     'react-hooks/exhaustive-deps': 'warn', // Checks effect dependencies
     'react/react-in-jsx-scope': 'off', // Disable requirement for React import
-    //     'no-catch-all/no-catch-all': 'error',
+    'no-catch-all/no-catch-all': 'error',
     'no-console': 'error',
     'no-debugger': 'error',
     camelcase: 'error',

package-lock.json

@@ -45,6 +45,7 @@
         "eslint-import-resolver-typescript": "^3.6.3",
         "eslint-plugin-import": "^2.31.0",
         "eslint-plugin-json": "^3.1.0",
+        "eslint-plugin-no-catch-all": "^1.1.0",
         "eslint-plugin-prettier": "^5.2.1",
         "eslint-plugin-promise": "^6.1.1",
         "eslint-plugin-react": "^7.31.8",
@@ -2372,6 +2373,16 @@
         "node": ">=10"
       }
     },
+    "node_modules/eslint-plugin-no-catch-all": {
+      "version": "1.1.0",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-no-catch-all/-/eslint-plugin-no-catch-all-1.1.0.tgz",
+      "integrity": "sha512-VkP62jLTmccPrFGN/W6V7a3SEwdtTZm+Su2k4T3uyJirtkm0OMMm97h7qd8pRFAHus/jQg9FpUpLRc7sAylBEQ==",
+      "dev": true,
+      "license": "MIT",
+      "peerDependencies": {
+        "eslint": ">=2.0.0"
+      }
+    },
     "node_modules/eslint-plugin-prettier": {
       "version": "5.2.1",
       "resolved": "https://registry.npmjs.org/eslint-plugin-prettier/-/eslint-plugin-prettier-5.2.1.tgz",

package.json

@@ -33,6 +33,7 @@
     "eslint-import-resolver-typescript": "^3.6.3",
     "eslint-plugin-import": "^2.31.0",
     "eslint-plugin-json": "^3.1.0",
+    "eslint-plugin-no-catch-all": "^1.1.0",
     "eslint-plugin-prettier": "^5.2.1",
     "eslint-plugin-promise": "^6.1.1",
     "eslint-plugin-react": "^7.31.8",

src/Components/AppShell/ContextWrapper.tsx

@@ -28,6 +28,7 @@ export const ContextWrapper = ({ children }) => {
   try {
     // eslint-disable-next-line react-hooks/rules-of-hooks
     location = useLocation()
+    // eslint-disable-next-line no-catch-all/no-catch-all
   } catch (e) {
     location = null
   }

src/Components/Auth/useAuth.tsx

@@ -69,6 +69,7 @@ export const AuthProvider = ({ userApi, children }: AuthProviderProps) => {
         setLoading(false)
         return me
       } else return undefined
+      // eslint-disable-next-line no-catch-all/no-catch-all
     } catch (error) {
       setLoading(false)
       return undefined

src/Components/Map/Subcomponents/Controls/SearchControl.tsx

@@ -63,6 +63,7 @@ export const SearchControl = () => {
         try {
           const { data } = await axios.get(`https://photon.komoot.io/api/?q=${value}&limit=5`)
           setGeoResults(data.features)
+          // eslint-disable-next-line no-catch-all/no-catch-all
         } catch (error) {
           // eslint-disable-next-line no-console
           console.log(error)

src/Components/Map/Subcomponents/ItemFormPopup.tsx

@@ -70,6 +70,7 @@ export function ItemFormPopup(props: ItemFormPopupProps) {
       try {
         await props.layer.api?.updateItem!({ ...formItem, id: props.item.id })
         success = true
+        // eslint-disable-next-line no-catch-all/no-catch-all
       } catch (error) {
         toast.error(error.toString())
       }
@@ -101,6 +102,7 @@ export function ItemFormPopup(props: ItemFormPopupProps) {
             name: formItem.name ? formItem.name : user?.first_name,
           }))
         success = true
+        // eslint-disable-next-line no-catch-all/no-catch-all
       } catch (error) {
         toast.error(error.toString())
       }

src/Components/Map/Subcomponents/ItemViewPopup.tsx

@@ -63,6 +63,7 @@ export const ItemViewPopup = forwardRef((props: ItemViewPopupProps, ref: any) =>
       props.item.layer?.onlyOnePerOwner &&
         (await props.item.layer.api?.updateItem!({ id: props.item.id, position: null }))
       success = true
+      // eslint-disable-next-line no-catch-all/no-catch-all
     } catch (error) {
       toast.error(error.toString())
     }

src/Components/Map/hooks/useSelectPosition.tsx

@@ -89,6 +89,7 @@ function useSelectPositionManager(): {
           position: null,
         })
         success = true
+        // eslint-disable-next-line no-catch-all/no-catch-all
       } catch (error) {
         toast.error(error.toString())
       }
@@ -113,6 +114,7 @@ function useSelectPositionManager(): {
         position: updatedItem.position,
       })
       success = true
+      // eslint-disable-next-line no-catch-all/no-catch-all
     } catch (error) {
       toast.error(error.toString())
     }
@@ -134,6 +136,7 @@ function useSelectPositionManager(): {
         try {
           await markerClicked.layer?.api?.updateItem!(updatedItem)
           success = true
+          // eslint-disable-next-line no-catch-all/no-catch-all
         } catch (error) {
           toast.error(error.toString())
         }

src/Components/Profile/itemFunctions.ts

@@ -63,6 +63,7 @@ export const submitNewItem = async (
     await layer?.api?.createItem!({ ...formItem, id: uuid, type, parent: item.id })
     await linkItem(uuid)
     success = true
+    // eslint-disable-next-line no-catch-all/no-catch-all
   } catch (error) {
     toast.error(error.toString())
   }
@@ -84,6 +85,7 @@ export const linkItem = async (id: string, item, updateItem) => {
   try {
     await item?.layer?.api?.updateItem!(updatedItem)
     success = true
+    // eslint-disable-next-line no-catch-all/no-catch-all
   } catch (error) {
     toast.error(error.toString())
   }
@@ -101,6 +103,7 @@ export const unlinkItem = async (id: string, item, updateItem) => {
   try {
     await item?.layer?.api?.updateItem!(updatedItem)
     success = true
+    // eslint-disable-next-line no-catch-all/no-catch-all
   } catch (error) {
     toast.error(error.toString())
   }
@@ -124,6 +127,7 @@ export const handleDelete = async (
   try {
     await item.layer?.api?.deleteItem!(item.id)
     success = true
+    // eslint-disable-next-line no-catch-all/no-catch-all
   } catch (error) {
     toast.error(error.toString())
   }

src/Components/Templates/OverlayItemsIndexPage.tsx

@@ -91,6 +91,7 @@ export const OverlayItemsIndexPage = ({
     try {
       await layer?.api?.createItem!({ ...formItem, id: uuid })
       success = true
+      // eslint-disable-next-line no-catch-all/no-catch-all
     } catch (error) {
       toast.error(error.toString())
     }
@@ -108,6 +109,7 @@ export const OverlayItemsIndexPage = ({
     try {
       await layer?.api?.deleteItem!(item.id)
       success = true
+      // eslint-disable-next-line no-catch-all/no-catch-all
     } catch (error) {
       toast.error(error.toString())
     }

src/Utils/ReverseGeocoder.ts

@@ -34,6 +34,7 @@ export async function reverseGeocode(lat: number, lon: number): Promise<string>
     // Formatiere die Adresse
     const formattedAddress = `${street} ${houseNumber}, ${city}`.trim()
     return formattedAddress || ''
+    // eslint-disable-next-line no-catch-all/no-catch-all
   } catch (error) {
     // eslint-disable-next-line no-console
     console.error('Error:', error)