Refactore and cleanup backend tests

- Removed double declarations.
- Put assignments in 'beforeEach'.

backend/src/schema/resolvers/users.spec.js

@@ -18,35 +18,6 @@ let variables
 const driver = getDriver()
 const neode = getNeode()
 
-const deleteUserMutation = gql`
-  mutation($id: ID!, $resource: [Deletable]) {
-    DeleteUser(id: $id, resource: $resource) {
-      id
-      name
-      about
-      deleted
-      contributions {
-        id
-        content
-        contentExcerpt
-        deleted
-        comments {
-          id
-          content
-          contentExcerpt
-          deleted
-        }
-      }
-      comments {
-        id
-        content
-        contentExcerpt
-        deleted
-      }
-    }
-  }
-`
-
 beforeAll(() => {
   const { server } = createServer({
     context: () => {
@@ -67,18 +38,22 @@ beforeEach(async () => {
 
 describe('User', () => {
   describe('query by email address', () => {
-    beforeEach(async () => {
+    let userQuery
-      await Factory.build('user', { name: 'Johnny' }, { email: 'any-email-address@example.org' })
-    })
 
-    const userQuery = gql`
+    beforeEach(async () => {
+      userQuery = gql`
         query($email: String) {
           User(email: $email) {
             name
           }
         }
       `
-    const variables = { email: 'any-email-address@example.org' }
+      variables = {
+        email: 'any-email-address@example.org',
+      }
+
+      await Factory.build('user', { name: 'Johnny' }, { email: 'any-email-address@example.org' })
+    })
 
     it('is forbidden', async () => {
       await expect(query({ query: userQuery, variables })).resolves.toMatchObject({
@@ -127,16 +102,10 @@ describe('User', () => {
 })
 
 describe('UpdateUser', () => {
-  let variables
+  let updateUserMutation
 
   beforeEach(async () => {
-    variables = {
+    updateUserMutation = gql`
-      id: 'u47',
-      name: 'John Doughnut',
-    }
-  })
-
-  const updateUserMutation = gql`
       mutation(
         $id: ID!
         $name: String
@@ -157,7 +126,11 @@ describe('UpdateUser', () => {
         }
       }
     `
-  beforeEach(async () => {
+    variables = {
+      id: 'u47',
+      name: 'John Doughnut',
+    }
+
     user = await Factory.build(
       'user',
       {
@@ -276,7 +249,37 @@ describe('UpdateUser', () => {
 })
 
 describe('Delete a user', () => {
+  let deleteUserMutation
+
   beforeEach(async () => {
+    deleteUserMutation = gql`
+      mutation($id: ID!, $resource: [Deletable]) {
+        DeleteUser(id: $id, resource: $resource) {
+          id
+          name
+          about
+          deleted
+          contributions {
+            id
+            content
+            contentExcerpt
+            deleted
+            comments {
+              id
+              content
+              contentExcerpt
+              deleted
+            }
+          }
+          comments {
+            id
+            content
+            contentExcerpt
+            deleted
+          }
+        }
+      }
+    `
     variables = { id: ' u343', resource: [] }
 
     user = await Factory.build('user', {
@@ -348,7 +351,7 @@ describe('Delete a user', () => {
 
       describe('deleting a user account', () => {
         beforeEach(() => {
-          variables = { ...variables, id: 'u343' }
+          variables = { id: 'u343' }
         })
 
         describe('given posts and comments', () => {