From 1f93c690beee31713002c0451936eca555260356 Mon Sep 17 00:00:00 2001
From: Alina Beck <alina.beck@mail.com>
Date: Wed, 2 Oct 2019 18:05:29 +0200
Subject: [PATCH] only display available data

---
 webapp/components/Editor/Editor.vue     |  7 +++++++
 webapp/components/Editor/nodes/Embed.js | 11 ++++++++---
 2 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/webapp/components/Editor/Editor.vue b/webapp/components/Editor/Editor.vue
index 0f96607ee..2b65131a8 100644
--- a/webapp/components/Editor/Editor.vue
+++ b/webapp/components/Editor/Editor.vue
@@ -406,4 +406,11 @@ li > p {
     margin-right: $space-small;
   }
 }
+
+.embed-close-button {
+  position: absolute;
+  top: $space-x-small;
+  right: $space-x-small;
+  background-color: rgba(250, 249, 250, 0.6);
+}
 </style>
diff --git a/webapp/components/Editor/nodes/Embed.js b/webapp/components/Editor/nodes/Embed.js
index 1275fe3d2..fb24eadd1 100644
--- a/webapp/components/Editor/nodes/Embed.js
+++ b/webapp/components/Editor/nodes/Embed.js
@@ -8,9 +8,9 @@ const template = `
   <ds-container width="small" class="embed-container">
     <section class="embed-content">
       <div v-if="showEmbed" v-html="embedHtml" class="embed-html" />
-      <img v-else :src="embedImage" class="embed-preview-image" @click.prevent="openOverlay()" />
-      <h4>{{embedTitle}}</h4>
-      <p>{{embedDescription}}</p>
+      <img v-else-if="embedImage" :src="embedImage" class="embed-preview-image" @click.prevent="openOverlay()" />
+      <h4 v-if="embedTitle">{{embedTitle}}</h4>
+      <p v-if="embedDescription">{{embedDescription}}</p>
       <a class="embed" :href="dataEmbedUrl" rel="noopener noreferrer nofollow" target="_blank">{{dataEmbedUrl}}</a>
     </section>
     <aside v-if="showOverlay" class="embed-overlay">
@@ -25,6 +25,7 @@ const template = `
         <span>Inhalte von Drittanbietern immer zulassen</span>
       </label>
     </aside>
+    <ds-button icon="close" ghost size="small" class="embed-close-button" @click.prevent="removeEmbed()" />
   </ds-container>
 `
 
@@ -153,6 +154,10 @@ export default class Embed extends Node {
             this.updateEmbedSettings(this.checkedAlwaysAllowEmbeds)
           }
         },
+        removeEmbed() {
+          // TODO: replace the whole Embed with a proper Link node
+          console.log('I want to be a Link!')
+        },
         async updateEmbedSettings(allowEmbedIframes) {
           try {
             await this.$apollo.mutate({