diff --git a/backend/src/graphql/resolvers/messages.ts b/backend/src/graphql/resolvers/messages.ts index 622ead120..61b6154fb 100644 --- a/backend/src/graphql/resolvers/messages.ts +++ b/backend/src/graphql/resolvers/messages.ts @@ -115,9 +115,7 @@ export default { content, }) - const [message] = await createMessageTxResponse.records.map((record) => - record.get('message'), - ) + const [message] = createMessageTxResponse.records.map((record) => record.get('message')) // this is the case if the room doesn't exist - requires refactoring for implicit rooms if (!message) { @@ -149,7 +147,7 @@ export default { context.logger.error('CreateMessage', error) throw new Error(error) } finally { - session.close() + await session.close() } }, MarkMessagesAsSeen: async (_parent, params, context, _resolveInfo) => { diff --git a/backend/src/graphql/resolvers/registration.spec.ts b/backend/src/graphql/resolvers/registration.spec.ts index fe8dc40e0..684439b0c 100644 --- a/backend/src/graphql/resolvers/registration.spec.ts +++ b/backend/src/graphql/resolvers/registration.spec.ts @@ -14,6 +14,12 @@ import createServer, { getContext } from '@src/server' let variables +const loggerErrorMock: (e) => void = jest.fn() + +jest.mock('@src/logger', () => ({ + error: (e) => loggerErrorMock(e), +})) + const database = databaseContext() let server: ApolloServer diff --git a/backend/src/graphql/resolvers/registration.ts b/backend/src/graphql/resolvers/registration.ts index db24ed7d0..a9e40d335 100644 --- a/backend/src/graphql/resolvers/registration.ts +++ b/backend/src/graphql/resolvers/registration.ts @@ -19,7 +19,7 @@ const neode = getNeode() export default { Mutation: { - Signup: async (_parent, args, context) => { + Signup: async (_parent, args, context: Context) => { args.nonce = generateNonce() args.email = normalizeEmail(args.email) let emailAddress = await existingEmailAddress({ args, context }) @@ -33,6 +33,7 @@ export default { emailAddress = await neode.create('EmailAddress', args) return emailAddress.toJson() } catch (e) { + context.logger.error('Signup mutation', e) throw new UserInputError(e.message) } }, @@ -111,7 +112,8 @@ export default { } catch (e) { if (e.code === 'Neo.ClientError.Schema.ConstraintValidationFailed') throw new UserInputError('User with this slug already exists!') - throw new UserInputError(e.message) + context.logger.error('SignupVerification mutation', e) + throw new Error(e.message) } finally { await session.close() }