From 30bb0c4596690b01d5a9ea5e8740e1e9874dc70a Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Fri, 3 Feb 2023 20:16:32 +0100
Subject: [PATCH] use lodash instead of homebrewn stuff, fix typo

---
 .github/workflows/test.yml |  2 +-
 webapp/pages/map.vue       | 13 ++++++-------
 webapp/utils/utils.js      |  5 -----
 3 files changed, 7 insertions(+), 13 deletions(-)
 delete mode 100644 webapp/utils/utils.js

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 277f9d0b6..4b310a20b 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -269,7 +269,7 @@ jobs:
           report_name: Coverage Webapp
           type: lcov
           result_path: ./coverage/lcov.info
-          min_coverage: 61
+          min_coverage: 63
           token: ${{ github.token }}
 
   ##############################################################################
diff --git a/webapp/pages/map.vue b/webapp/pages/map.vue
index f7b3efe18..f5082904a 100644
--- a/webapp/pages/map.vue
+++ b/webapp/pages/map.vue
@@ -44,12 +44,11 @@
 </template>
 
 <script>
-import isEmpty from 'lodash/isEmpty'
+import { isEmpty, toArray } from 'lodash'
 import mapboxgl from 'mapbox-gl'
 import MapboxGeocoder from '@mapbox/mapbox-gl-geocoder'
 import '@mapbox/mapbox-gl-geocoder/dist/mapbox-gl-geocoder.css'
 import { mapGetters } from 'vuex'
-import { objectValuesToArray } from '~/utils/utils'
 import { profileUserQuery, mapUserQuery } from '~/graphql/User'
 import { groupQuery } from '~/graphql/groups'
 import mobile from '~/mixins/mobile'
@@ -127,7 +126,7 @@ export default {
       )
     },
     styles() {
-      return objectValuesToArray(this.availableStyles)
+      return toArray(this.availableStyles)
     },
     availableStyles() {
       // https://docs.mapbox.com/api/maps/styles/
@@ -187,7 +186,7 @@ export default {
         // Triggered when `setStyle` is called.
         this.markers.isImagesLoaded = false
         this.markers.isSourceAndLayerAdded = false
-        this.loadMarkesIconsAndAddMarkers()
+        this.loadMarkersIconsAndAddMarkers()
       })
 
       // add search field for locations
@@ -241,7 +240,7 @@ export default {
               <a href="${markerProfileLink}" target="_blank">${markerProfileLinkTitle}</a>
             </div>
           </div>
-        `
+           `
         description +=
           e.features[0].properties.about && e.features[0].properties.about.length > 0
             ? `
@@ -272,7 +271,7 @@ export default {
         }
       })
 
-      this.loadMarkesIconsAndAddMarkers()
+      this.loadMarkersIconsAndAddMarkers()
     },
     language(map) {
       // example in mapbox-gl-language: https://github.com/mapbox/mapbox-gl-language/blob/master/index.js
@@ -288,7 +287,7 @@ export default {
       this.map.setStyle(url)
       this.activeStyle = url
     },
-    loadMarkesIconsAndAddMarkers() {
+    loadMarkersIconsAndAddMarkers() {
       Promise.all(
         this.markers.icons.map(
           (marker) =>
diff --git a/webapp/utils/utils.js b/webapp/utils/utils.js
deleted file mode 100644
index d82799d87..000000000
--- a/webapp/utils/utils.js
+++ /dev/null
@@ -1,5 +0,0 @@
-export const objectValuesToArray = (obj) => {
-  return Object.keys(obj).map(function (key) {
-    return obj[key]
-  })
-}