From 30870d832b0897236a474c30b37463917ca4bbed Mon Sep 17 00:00:00 2001
From: roschaefer <git@roschaefer.de>
Date: Tue, 10 Dec 2019 01:55:00 +0100
Subject: [PATCH 1/2] Quick fix for null pointer error

`this.openMenu` is not a function`
---
 webapp/components/User/User.vue                              | 5 +----
 .../features/FiledReportsTable/FiledReportsTable.vue         | 1 +
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/webapp/components/User/User.vue b/webapp/components/User/User.vue
index ade52ea5e..a1d636d7f 100644
--- a/webapp/components/User/User.vue
+++ b/webapp/components/User/User.vue
@@ -8,7 +8,7 @@
   <dropdown v-else :class="{ 'disabled-content': user.disabled }" placement="top-start" offset="0">
     <template slot="default" slot-scope="{ openMenu, closeMenu, isOpen }">
       <nuxt-link :to="userLink" :class="['user', isOpen && 'active']">
-        <div @mouseover="openInfoMenu" @mouseleave="closeMenu(true)">
+        <div @mouseover="showCounts ? openMenu(true) : () => {}" @mouseleave="closeMenu(true)">
           <hc-avatar v-if="showAvatar" class="avatar" :user="user" />
           <div>
             <ds-text class="userinfo">
@@ -143,9 +143,6 @@ export default {
       this.user.followedByCount = followedByCount
       this.user.followedByCurrentUser = followedByCurrentUser
     },
-    openInfoMenu() {
-      if (this.showCounts) this.openMenu(true)
-    },
   },
 }
 </script>
diff --git a/webapp/components/features/FiledReportsTable/FiledReportsTable.vue b/webapp/components/features/FiledReportsTable/FiledReportsTable.vue
index d54d1116e..9a17cf327 100644
--- a/webapp/components/features/FiledReportsTable/FiledReportsTable.vue
+++ b/webapp/components/features/FiledReportsTable/FiledReportsTable.vue
@@ -10,6 +10,7 @@
       <hc-user
         :user="scope.row.submitter"
         :showAvatar="false"
+        :showCounts="false"
         :trunc="30"
         data-test="filing-user"
       />

From 9703066699feae022aa384dcde6792fabd0293d5 Mon Sep 17 00:00:00 2001
From: mattwr18 <mattwr18@gmail.com>
Date: Tue, 10 Dec 2019 14:37:05 +0100
Subject: [PATCH 2/2] Rename prop name following @roschaefer suggestion

- missed in previous PR
---
 webapp/components/User/User.vue                             | 6 +++---
 .../features/FiledReportsTable/FiledReportsTable.vue        | 2 +-
 webapp/components/features/ReportRow/ReportRow.vue          | 6 +++---
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/webapp/components/User/User.vue b/webapp/components/User/User.vue
index a1d636d7f..6bd084dc8 100644
--- a/webapp/components/User/User.vue
+++ b/webapp/components/User/User.vue
@@ -8,7 +8,7 @@
   <dropdown v-else :class="{ 'disabled-content': user.disabled }" placement="top-start" offset="0">
     <template slot="default" slot-scope="{ openMenu, closeMenu, isOpen }">
       <nuxt-link :to="userLink" :class="['user', isOpen && 'active']">
-        <div @mouseover="showCounts ? openMenu(true) : () => {}" @mouseleave="closeMenu(true)">
+        <div @mouseover="showPopover ? openMenu(true) : () => {}" @mouseleave="closeMenu(true)">
           <hc-avatar v-if="showAvatar" class="avatar" :user="user" />
           <div>
             <ds-text class="userinfo">
@@ -26,7 +26,7 @@
         </div>
       </nuxt-link>
     </template>
-    <template slot="popover" v-if="showCounts">
+    <template slot="popover" v-if="showPopover">
       <div style="min-width: 250px">
         <hc-badges v-if="user.badges && user.badges.length" :badges="user.badges" />
         <ds-text
@@ -106,7 +106,7 @@ export default {
     showAvatar: { type: Boolean, default: true },
     trunc: { type: Number, default: 18 }, // "-1" is no trunc
     dateTime: { type: [Date, String], default: null },
-    showCounts: { type: Boolean, default: true },
+    showPopover: { type: Boolean, default: true },
   },
   computed: {
     ...mapGetters({
diff --git a/webapp/components/features/FiledReportsTable/FiledReportsTable.vue b/webapp/components/features/FiledReportsTable/FiledReportsTable.vue
index 9a17cf327..71c7d39a5 100644
--- a/webapp/components/features/FiledReportsTable/FiledReportsTable.vue
+++ b/webapp/components/features/FiledReportsTable/FiledReportsTable.vue
@@ -10,7 +10,7 @@
       <hc-user
         :user="scope.row.submitter"
         :showAvatar="false"
-        :showCounts="false"
+        :showPopover="false"
         :trunc="30"
         data-test="filing-user"
       />
diff --git a/webapp/components/features/ReportRow/ReportRow.vue b/webapp/components/features/ReportRow/ReportRow.vue
index e5391d311..bf0cce7a7 100644
--- a/webapp/components/features/ReportRow/ReportRow.vue
+++ b/webapp/components/features/ReportRow/ReportRow.vue
@@ -19,7 +19,7 @@
       <!-- Content Column -->
       <td class="ds-table-col" data-test="report-content">
         <client-only v-if="isUser">
-          <hc-user :user="report.resource" :showAvatar="false" :trunc="30" :showCounts="false" />
+          <hc-user :user="report.resource" :showAvatar="false" :trunc="30" :showPopover="false" />
         </client-only>
         <nuxt-link v-else class="title" :to="linkTarget">
           {{ linkText | truncate(50) }}
@@ -33,7 +33,7 @@
             :user="report.resource.author"
             :showAvatar="false"
             :trunc="30"
-            :showCounts="false"
+            :showPopover="false"
           />
         </client-only>
         <span v-else>—</span>
@@ -51,7 +51,7 @@
             :showAvatar="false"
             :trunc="30"
             :date-time="report.updatedAt"
-            :showCounts="false"
+            :showPopover="false"
           />
         </client-only>
       </td>