From 6d26bc3cc5116bb4d65aeb8fccae618f4e1768b3 Mon Sep 17 00:00:00 2001 From: mahula Date: Wed, 16 Apr 2025 22:46:14 +0200 Subject: [PATCH] e2e: rework follow notification feature files --- cypress/e2e/Group.Notification.feature | 35 ++++++++++---------- cypress/e2e/Post.Follow.Notification.feature | 5 +-- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/cypress/e2e/Group.Notification.feature b/cypress/e2e/Group.Notification.feature index a9a8e6b61..df90ceef2 100644 --- a/cypress/e2e/Group.Notification.feature +++ b/cypress/e2e/Group.Notification.feature @@ -4,7 +4,7 @@ Feature: Notifications for Groups To stay informed about the group's activity When absent or offline I get notified via e-mail - No notifications or emails are send regarding posts from users I have blocked or muted + # No notifications or emails are send regarding posts from users I have blocked or muted Background: Given the following "users" are in the database: @@ -13,8 +13,8 @@ Feature: Notifications for Groups | Jenny Rostock | jenny-rostock | user@example.org | 1234 | u3 | 0.0.4 | | Nathan Narrator | nathan-narrator | narrator@example.org | abcd | u_nn | 0.0.4 | | Billy Block | billy-block | billy@example.org | 4321 | u_bb | 0.0.4 | - And "Bob der Baumeister" mutes "Nathan Narrator" - And "Bob der Baumeister" blocks "Billy Block" + # And "Bob der Baumeister" mutes "Nathan Narrator" + # And "Bob der Baumeister" blocks "Billy Block" Given "Bob der Baumeister" creates the group "Bob's Group" And "Jenny Rostock" joins the group "Bob's Group" And "Nathan Narrator" joins the group "Bob's Group" @@ -24,23 +24,22 @@ Feature: Notifications for Groups Scenario: In-app notification Given "Bob der Baumeister" posts to group "Jenny's Group" + Then "Jenny Rostock" receives an email about a new post in group "Jenny's Group" + And the email contains a deep link to the post When I am logged in as "Jenny Rostock" Then I see a notification about the new post in the dashboard - Scenario: Email notification - Given "Bob der Baumeister" posts to group "Jenny's Group" - Then "Jenny Rostock" receives an email about a new post in group "Jenny's Group" - And the email contains a deep link to the post + # omit these scenarios as the different ways to deactivate notifications for groups are covered in unit testing - Scenario: No notification from muted group - Given "Jenny Rostock" has muted group "Bob's Group" - And "Bob der Baumeister" posts to group "Bob's Group" - When I am logged in as "Jenny Rostock" - Then I don't see a notification in the dashboard - And I don't receive any email regarding "Bob's Group" + # Scenario: No notification from muted group + # Given "Jenny Rostock" has muted group "Bob's Group" + # And "Bob der Baumeister" posts to group "Bob's Group" + # When I am logged in as "Jenny Rostock" + # Then I don't see a notification in the dashboard + # And I don't receive any email regarding "Bob's Group" - Scenario: Never get notifications for own posts - Given I am logged in as "Jenny Rostock" - When I write a post in group "Jenny's Group" - Then I don't see a notification in the dashboard - And I don't receive an email either \ No newline at end of file + # Scenario: Never get notifications for own posts + # Given I am logged in as "Jenny Rostock" + # When I write a post in group "Jenny's Group" + # Then I don't see a notification in the dashboard + # And I don't receive an email either \ No newline at end of file diff --git a/cypress/e2e/Post.Follow.Notification.feature b/cypress/e2e/Post.Follow.Notification.feature index 7386b134e..7f888acb9 100644 --- a/cypress/e2e/Post.Follow.Notification.feature +++ b/cypress/e2e/Post.Follow.Notification.feature @@ -4,7 +4,8 @@ Feature: Notifications Posts In order to get notified about new comments on a post When absent or offline I get notified via e-mail - # For users I have blocked or muted no notifications or emails are send + # No notifications or emails are send regarding comments from users I have blocked or muted + Background: Given the following "users" are in the database: @@ -27,7 +28,7 @@ Feature: Notifications Posts When I am logged in as "Bob der Baumeister" Then a notification about the new post is displayed in the nav menu - # TODO: omit hese scenario as the different ways into observin /unobserving apost shouldbecovered in unit testing + # omit these scenarios as the different ways into observing /unobserving a post should be covered in unit testing # Scenario: Unfollow a post and receive no more notifications about it # Given I follow a post