From 790f767b6ef5da8f4154109abfae821551c3276f Mon Sep 17 00:00:00 2001 From: Moriz Wahl Date: Thu, 26 Jun 2025 16:46:58 +0200 Subject: [PATCH] log room resolver errors --- backend/src/graphql/resolvers/rooms.ts | 11 +++++++---- backend/src/middleware/permissionsMiddleware.ts | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/backend/src/graphql/resolvers/rooms.ts b/backend/src/graphql/resolvers/rooms.ts index e3422a5ce..29b53d501 100644 --- a/backend/src/graphql/resolvers/rooms.ts +++ b/backend/src/graphql/resolvers/rooms.ts @@ -4,10 +4,12 @@ /* eslint-disable @typescript-eslint/no-unsafe-return */ /* eslint-disable @typescript-eslint/no-unsafe-assignment */ /* eslint-disable @typescript-eslint/no-unsafe-member-access */ +import { UserInputError } from 'apollo-server' import { withFilter } from 'graphql-subscriptions' import { neo4jgraphql } from 'neo4j-graphql-js' import { ROOM_COUNT_UPDATED } from '@constants/subscriptions' +import type { Context } from '@src/server' import Resolver from './helpers/Resolver' @@ -58,13 +60,13 @@ export default { }, }, Mutation: { - CreateRoom: async (_parent, params, context, _resolveInfo) => { + CreateRoom: async (_parent, params, context: Context, _resolveInfo) => { const { userId } = params const { user: { id: currentUserId }, } = context if (userId === currentUserId) { - throw new Error('Cannot create a room with self') + throw new UserInputError('Cannot create a room with self') } const session = context.driver.session() const writeTxResultPromise = session.writeTransaction(async (transaction) => { @@ -91,7 +93,7 @@ export default { userId, currentUserId, }) - const [room] = await createRommTxResponse.records.map((record) => record.get('room')) + const [room] = createRommTxResponse.records.map((record) => record.get('room')) return room }) try { @@ -101,9 +103,10 @@ export default { } return room } catch (error) { + context.logger.error('CreateRoom mutation', error) throw new Error(error) } finally { - session.close() + await session.close() } }, }, diff --git a/backend/src/middleware/permissionsMiddleware.ts b/backend/src/middleware/permissionsMiddleware.ts index cc70fc00b..d1fcc8653 100644 --- a/backend/src/middleware/permissionsMiddleware.ts +++ b/backend/src/middleware/permissionsMiddleware.ts @@ -11,7 +11,7 @@ import SocialMedia from '@db/models/SocialMedia' import { getNeode } from '@db/neo4j' // eslint-disable-next-line import/no-cycle import { validateInviteCode } from '@graphql/resolvers/inviteCodes' -import { Context } from '@src/server' +import type { Context } from '@src/server' const debug = !!CONFIG.DEBUG const allowExternalErrors = true