From 79a8fc5f5fdf5b6d2cf486e2b7b13aeee1e126e5 Mon Sep 17 00:00:00 2001 From: roschaefer Date: Thu, 15 Aug 2019 15:46:29 +0200 Subject: [PATCH] Fix javascript runtime errors I could see a warning about duplicate keys on the `Chip` page, also there seems to be a missing check if a param is null (I used a default). --- .../components/ComponentOptionsDoc.vue | 2 +- src/system/components/typography/Chip/demo.md | 22 +++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/src/styleguide/components/ComponentOptionsDoc.vue b/src/styleguide/components/ComponentOptionsDoc.vue index b2848a4d1..53390bca8 100755 --- a/src/styleguide/components/ComponentOptionsDoc.vue +++ b/src/styleguide/components/ComponentOptionsDoc.vue @@ -202,7 +202,7 @@ export default { } return attributes }, - getAttributesFromComment(comment) { + getAttributesFromComment(comment = '') { const attributes = {} const optionsMatch = comment.match(/@options[ ]+(\S[ \S]*)\n/) if (optionsMatch) { diff --git a/src/system/components/typography/Chip/demo.md b/src/system/components/typography/Chip/demo.md index af57221f1..f144c6dd3 100644 --- a/src/system/components/typography/Chip/demo.md +++ b/src/system/components/typography/Chip/demo.md @@ -32,16 +32,9 @@ A chip can be deletable. v-for="(tag, index) in tags" @remove="removeTag(index)" removable - :key="tag"> - {{ tag }} - - - {{ tag }} + :key="index" + :color="tag.color"> + {{ tag.label }} @@ -49,7 +42,14 @@ A chip can be deletable. export default { data() { return { - tags: ['Dog', 'Cat', 'Duck'] + tags: [ + {label: 'Dog'}, + {label: 'Cat'}, + {label: 'Duck'}, + {label: 'Mouse', color: "primary"}, + {label: 'Bird', color: "primary"}, + {label: 'Elephant', color: "primary"}, + ], } }, methods: {