From 7d4a75a94c31b00c1af40cd271c3e82b5293341c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= <wolle.huss@pjannto.com>
Date: Fri, 1 Dec 2023 15:02:25 +0100
Subject: [PATCH] Refine checking of definition of variables

---
 deployment/scripts/cluster.backup.sh                   | 2 +-
 deployment/scripts/cluster.maintenance.sh              | 2 +-
 deployment/scripts/cluster.neo4j.sh                    | 2 +-
 deployment/scripts/clusters.backup-multiple-servers.sh | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/deployment/scripts/cluster.backup.sh b/deployment/scripts/cluster.backup.sh
index 7da493e4b..2d3bf156e 100755
--- a/deployment/scripts/cluster.backup.sh
+++ b/deployment/scripts/cluster.backup.sh
@@ -9,7 +9,7 @@ SCRIPT_PATH=$(realpath $0)
 SCRIPT_DIR=$(dirname $SCRIPT_PATH)
 
 # check CONFIGURATION
-if [[ -z ${CONFIGURATION} ]]; then
+if [[ -z "$CONFIGURATION" ]] || [[ $CONFIGURATION == "" ]]; then
   echo "!!! You must provide a CONFIGURATION via environment variable !!!"
   exit 1
 fi
diff --git a/deployment/scripts/cluster.maintenance.sh b/deployment/scripts/cluster.maintenance.sh
index 33c52254d..780b81bd6 100755
--- a/deployment/scripts/cluster.maintenance.sh
+++ b/deployment/scripts/cluster.maintenance.sh
@@ -5,7 +5,7 @@ SCRIPT_PATH=$(realpath $0)
 SCRIPT_DIR=$(dirname $SCRIPT_PATH)
 
 # check CONFIGURATION
-if [ -z ${CONFIGURATION} ]; then
+if [[ -z "$CONFIGURATION" ]] || [[ $CONFIGURATION == "" ]]; then
   echo "You must provide a `CONFIGURATION` via environment variable"
   exit 1
 fi
diff --git a/deployment/scripts/cluster.neo4j.sh b/deployment/scripts/cluster.neo4j.sh
index ae539b314..3b284c0b7 100755
--- a/deployment/scripts/cluster.neo4j.sh
+++ b/deployment/scripts/cluster.neo4j.sh
@@ -5,7 +5,7 @@ SCRIPT_PATH=$(realpath $0)
 SCRIPT_DIR=$(dirname $SCRIPT_PATH)
 
 # check CONFIGURATION
-if [ -z ${CONFIGURATION} ]; then
+if [[ -z "$CONFIGURATION" ]] || [[ $CONFIGURATION == "" ]]; then
   echo "You must provide a `CONFIGURATION` via environment variable"
   exit 1
 fi
diff --git a/deployment/scripts/clusters.backup-multiple-servers.sh b/deployment/scripts/clusters.backup-multiple-servers.sh
index 3dfcb1d79..e81165457 100755
--- a/deployment/scripts/clusters.backup-multiple-servers.sh
+++ b/deployment/scripts/clusters.backup-multiple-servers.sh
@@ -17,7 +17,7 @@ source ${SCRIPT_DIR}/../.env
 set +a
 
 # check BACKUP_CONFIGURATIONS
-if [[ -z ${BACKUP_CONFIGURATIONS} ]]; then
+if [[ -z "$BACKUP_CONFIGURATIONS" ]] || [[ $BACKUP_CONFIGURATIONS == "" ]]; then
   #%! echo "You must provide a BACKUP_CONFIGURATIONS via environment variable"
   printf "!!! You must provide a BACKUP_CONFIGURATIONS via environment variable !!!\n"
   exit 1