ocelot-Social-Community/Ocelot-Social
1
0
Fork 0
mirror of https://github.com/Ocelot-Social-Community/Ocelot-Social.git synced 2025-12-13 07:46:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

test that existing emails do not throw anymore

Browse Source
This commit is contained in:
Moriz Wahl 2023-01-27 16:03:27 +01:00
parent 78b8d18c4e
commit 88de09b1ba
4 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
backend/src/middleware/login/loginMiddleware.js
View File

@ -33,7 +33,9 @@ const sendPasswordResetMail = async (resolve, root, args, context, resolveInfo)
const sendEmailVerificationMail = async (resolve, root, args, context, resolveInfo) => { const sendEmailVerificationMail = async (resolve, root, args, context, resolveInfo) => {
const response = await resolve(root, args, context, resolveInfo) const response = await resolve(root, args, context, resolveInfo)
const { email, nonce, name } = response const { email, nonce, name } = response
if (nonce) {
await sendMail(emailVerificationTemplate({ email, variables: { nonce, name } })) await sendMail(emailVerificationTemplate({ email, variables: { nonce, name } }))
}
delete response.nonce delete response.nonce
return response return response
} }

4
backend/src/schema/resolvers/emails.js
View File

@ -40,7 +40,9 @@ export default {
} }
// check email does not belong to anybody // check email does not belong to anybody
await existingEmailAddress({ args, context }) const existingEmail = await existingEmailAddress({ args, context })
if (existingEmail && existingEmail.alreadyExistingEmail && existingEmail.user)
return existingEmail.alreadyExistingEmail
const nonce = generateNonce() const nonce = generateNonce()
const { const {

12
backend/src/schema/resolvers/emails.spec.js
View File

@ -134,11 +134,17 @@ describe('AddEmailAddress', () => {
}) })
describe('but if another user owns an `EmailAddress` already with that email', () => { describe('but if another user owns an `EmailAddress` already with that email', () => {
it('throws UserInputError because of unique constraints', async () => { it('does not throw UserInputError', async () => {
await Factory.build('user', {}, { email: 'new-email@example.org' }) await Factory.build('user', {}, { email: 'new-email@example.org' })
await expect(mutate({ mutation, variables })).resolves.toMatchObject({ await expect(mutate({ mutation, variables })).resolves.toMatchObject({
data: { AddEmailAddress: null }, data: {
errors: [{ message: 'A user account with this email already exists.' }], AddEmailAddress: {
createdAt: expect.any(String),
verifiedAt: null,
email: 'new-email@example.org',
},
},
errors: undefined,
}) })
}) })
}) })

4
backend/src/schema/resolvers/registration.spec.js
View File

@ -118,9 +118,9 @@ describe('Signup', () => {
await emailAddress.relateTo(user, 'belongsTo') await emailAddress.relateTo(user, 'belongsTo')
}) })
it('throws UserInputError error because of unique constraint violation', async () => { it('does not throw UserInputError error', async () => {
await expect(mutate({ mutation, variables })).resolves.toMatchObject({ await expect(mutate({ mutation, variables })).resolves.toMatchObject({
errors: [{ message: 'A user account with this email already exists.' }], data: { Signup: { email: 'someuser@example.org' } },
}) })
}) })
}) })