ocelot-Social-Community/Ocelot-Social
1
0
Fork 0
mirror of https://github.com/Ocelot-Social-Community/Ocelot-Social.git synced 2025-12-13 07:46:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Prever FileReader over URL.createObjectUrl

Browse Source 
Apparently, URL.createObjectUrl is not supported in JSDom, see:
https://github.com/jsdom/jsdom/issues/1721

With FileReader we have the option to avoid it altogether.
This commit is contained in:
roschaefer 2020-02-20 15:42:47 +01:00
parent 9c98e30bb8
commit 9241305d43
3 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webapp/components/ContributionForm/ContributionForm.spec.js
View File

@ -233,10 +233,13 @@ describe('ContributionForm.vue', () => {
})
it('supports adding a teaser image', async () => {
const spy = jest.spyOn(FileReader.prototype, 'readAsDataURL').mockImplementation(() => {})
expectedParams.variables.imageUpload = imageUpload
wrapper.find(ImageUploader).vm.$emit('addHeroImage', imageUpload)
await wrapper.find('form').trigger('submit')
expect(mocks.$apollo.mutate).toHaveBeenCalledWith(expect.objectContaining(expectedParams))
expect(spy).toHaveBeenCalledWith(imageUpload)
spy.mockReset()
})
it('content is valid with just a link', async () => {

9
webapp/components/ContributionForm/ContributionForm.vue
View File

@ -194,8 +194,15 @@ export default {
this.$refs.contributionForm.update('content', value)
},
addHeroImage(file) {
this.formData.image = null
if (file) {
const reader = new FileReader()
reader.onload = ({ target }) => {
this.formData.image = target.result
}
this.imageUpload = file
this.formData.image = file ? URL.createObjectURL(file) : null
reader.readAsDataURL(file)
}
},
addImageAspectRatio(aspectRatio) {
this.formData.imageAspectRatio = aspectRatio

2
webapp/components/PostTeaser/PostTeaser.spec.js
View File

@ -66,7 +66,7 @@ describe('PostTeaser', () => {
}
it('has no validation errors', () => {
const spy = jest.spyOn(global.console, 'error');
const spy = jest.spyOn(global.console, 'error')
Wrapper()
expect(spy).not.toBeCalled()
spy.mockReset()