From 11f5ce746a20ff13b3f3155863472e9fcac13c0e Mon Sep 17 00:00:00 2001 From: ogerly Date: Mon, 17 Oct 2022 16:47:37 +0200 Subject: [PATCH 01/10] search input for invite user in group --- webapp/components/Group/GroupMember.vue | 27 +++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/webapp/components/Group/GroupMember.vue b/webapp/components/Group/GroupMember.vue index 28412d33a..525c95127 100644 --- a/webapp/components/Group/GroupMember.vue +++ b/webapp/components/Group/GroupMember.vue @@ -1,5 +1,24 @@ @@ -44,5 +44,11 @@ export default { fetchPolicy: 'cache-and-network', }, }, + methods: { + loadGroupMembers(){ + this.$apollo.queries.GroupMembers.refetch() + console.log('loadGroupMembers this.GroupMembers', this.GroupMembers) + } + }, } From 3c4d4bb8ebc8a7284c327d8c500feabea92e6a0f Mon Sep 17 00:00:00 2001 From: ogerly Date: Tue, 18 Oct 2022 14:43:29 +0200 Subject: [PATCH 05/10] style flex find user per slug --- webapp/components/Group/GroupMember.vue | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/webapp/components/Group/GroupMember.vue b/webapp/components/Group/GroupMember.vue index 97ba73b13..cb181a1eb 100644 --- a/webapp/components/Group/GroupMember.vue +++ b/webapp/components/Group/GroupMember.vue @@ -20,10 +20,18 @@
Kein User mit diesem Slug gefunden!
- {{slugUser}} - - {{ $t('group.addMemberToGroup') }} - + + + + {{ slugUser[0].name }} + {{ slugUser[0].slug }} + + + {{ $t('group.addMemberToGroup') }} + + + +
From 79644cb60a0169886d1198a58d9df28790b5b976 Mon Sep 17 00:00:00 2001 From: ogerly Date: Tue, 18 Oct 2022 19:29:48 +0200 Subject: [PATCH 06/10] add locals for group member --- webapp/components/Group/GroupMember.vue | 30 +++++++++++++++---------- webapp/locales/de.json | 4 +++- webapp/locales/en.json | 4 +++- webapp/pages/group/edit/_id/members.vue | 11 +++++---- 4 files changed, 31 insertions(+), 18 deletions(-) diff --git a/webapp/components/Group/GroupMember.vue b/webapp/components/Group/GroupMember.vue index cb181a1eb..e508d4719 100644 --- a/webapp/components/Group/GroupMember.vue +++ b/webapp/components/Group/GroupMember.vue @@ -1,20 +1,20 @@ @@ -45,10 +49,9 @@ export default { }, }, methods: { - loadGroupMembers(){ + loadGroupMembers() { this.$apollo.queries.GroupMembers.refetch() - console.log('loadGroupMembers this.GroupMembers', this.GroupMembers) - } + }, }, } From 43bf1ae79d99ae726d2a733856f758ee4f17c7cd Mon Sep 17 00:00:00 2001 From: Moriz Wahl Date: Wed, 19 Oct 2022 13:44:17 +0200 Subject: [PATCH 07/10] refactor: Category Filter in Filter Menu --- webapp/components/FilterMenu/FilterMenu.vue | 8 ++++++++ webapp/layouts/default.vue | 11 ----------- 2 files changed, 8 insertions(+), 11 deletions(-) diff --git a/webapp/components/FilterMenu/FilterMenu.vue b/webapp/components/FilterMenu/FilterMenu.vue index 9e211ccf9..74265803b 100644 --- a/webapp/components/FilterMenu/FilterMenu.vue +++ b/webapp/components/FilterMenu/FilterMenu.vue @@ -14,6 +14,7 @@

{{ $t('filter-menu.filter-by') }}

+

{{ $t('filter-menu.order-by') }}

@@ -28,12 +29,19 @@ import Dropdown from '~/components/Dropdown' import { mapGetters } from 'vuex' import FollowingFilter from './FollowingFilter' import OrderByFilter from './OrderByFilter' +import CategoriesFilter from './CategoriesFilter' export default { components: { Dropdown, FollowingFilter, OrderByFilter, + CategoriesFilter, + }, + data() { + return { + categoriesActive: this.$env.CATEGORIES_ACTIVE, + } }, props: { placement: { type: String }, diff --git a/webapp/layouts/default.vue b/webapp/layouts/default.vue index 8a0e7aa34..48279efd1 100644 --- a/webapp/layouts/default.vue +++ b/webapp/layouts/default.vue @@ -28,15 +28,6 @@ - - - - - Date: Thu, 20 Oct 2022 07:45:50 +0200 Subject: [PATCH 08/10] Lower webapp coverage from 65% to 64% --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 9564aa2f7..de171cc61 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -267,7 +267,7 @@ jobs: report_name: Coverage Webapp type: lcov result_path: ./coverage/lcov.info - min_coverage: 65 + min_coverage: 64 token: ${{ github.token }} ############################################################################## From af5447e83021f120095f2ecb4b03f73f4fe0417f Mon Sep 17 00:00:00 2001 From: ogerly Date: Thu, 20 Oct 2022 15:58:34 +0200 Subject: [PATCH 09/10] coverage 65.14%, add specs GroupList.spec, GroupMember.spec --- webapp/components/Group/GroupList.spec.js | 34 ++++++++++++++++++++ webapp/components/Group/GroupList.vue | 2 +- webapp/components/Group/GroupMember.spec.js | 35 +++++++++++++++++++++ webapp/components/Group/GroupMember.vue | 2 +- 4 files changed, 71 insertions(+), 2 deletions(-) create mode 100644 webapp/components/Group/GroupList.spec.js create mode 100644 webapp/components/Group/GroupMember.spec.js diff --git a/webapp/components/Group/GroupList.spec.js b/webapp/components/Group/GroupList.spec.js new file mode 100644 index 000000000..b0b3c9473 --- /dev/null +++ b/webapp/components/Group/GroupList.spec.js @@ -0,0 +1,34 @@ +import { config, mount } from '@vue/test-utils' +import GroupList from './GroupList.vue' + +const localVue = global.localVue + + +const propsData = { + groups: [], +} + +describe('GroupList', () => { + let wrapper + let mocks + + beforeEach(() => { + mocks = { + $t: jest.fn(), + } + }) + + describe('mount', () => { + const Wrapper = () => { + return mount(GroupList, { propsData, mocks, localVue }) + } + + beforeEach(() => { + wrapper = Wrapper() + }) + + it('renders', () => { + expect(wrapper.findAll('.group-list')).toHaveLength(1) + }) + }) +}) diff --git a/webapp/components/Group/GroupList.vue b/webapp/components/Group/GroupList.vue index 645f670d2..7618e5b57 100644 --- a/webapp/components/Group/GroupList.vue +++ b/webapp/components/Group/GroupList.vue @@ -1,5 +1,5 @@