test check test WIP

This commit is contained in:
ogerly 2020-08-03 14:49:50 +02:00
parent d2e6280059
commit a4be3f7adf

View File

@ -29,17 +29,17 @@ beforeAll(() => {
mutate = createTestClient(server).mutate
})
beforeEach(async () => {
beforeEach(async() => {
await cleanDatabase()
})
describe('User', () => {
describe('query by email address', () => {
beforeEach(async () => {
beforeEach(async() => {
await Factory.build('user', { name: 'Johnny' }, { email: 'any-email-address@example.org' })
})
const userQuery = gql`
const userQuery = gql `
query($email: String) {
User(email: $email) {
name
@ -48,20 +48,18 @@ describe('User', () => {
`
const variables = { email: 'any-email-address@example.org' }
it('is forbidden', async () => {
it('is forbidden', async() => {
await expect(query({ query: userQuery, variables })).resolves.toMatchObject({
errors: [{ message: 'Not Authorised!' }],
})
})
describe('as admin', () => {
beforeEach(async () => {
beforeEach(async() => {
const admin = await Factory.build(
'user',
{
'user', {
role: 'admin',
},
{
}, {
email: 'admin@example.org',
password: '1234',
},
@ -69,14 +67,14 @@ describe('User', () => {
authenticatedUser = await admin.toJson()
})
it('is permitted', async () => {
it('is permitted', async() => {
await expect(query({ query: userQuery, variables })).resolves.toMatchObject({
data: { User: [{ name: 'Johnny' }] },
errors: undefined,
})
})
it('non-existing email address, issue #2294', async () => {
it('non-existing email address, issue #2294', async() => {
// see: https://github.com/Human-Connection/Human-Connection/issues/2294
await expect(
query({
@ -97,14 +95,14 @@ describe('User', () => {
describe('UpdateUser', () => {
let variables
beforeEach(async () => {
beforeEach(async() => {
variables = {
id: 'u47',
name: 'John Doughnut',
}
})
const updateUserMutation = gql`
const updateUserMutation = gql `
mutation(
$id: ID!
$name: String
@ -126,30 +124,26 @@ describe('UpdateUser', () => {
}
`
beforeEach(async () => {
beforeEach(async() => {
user = await Factory.build(
'user',
{
'user', {
id: 'u47',
name: 'John Doe',
termsAndConditionsAgreedVersion: null,
termsAndConditionsAgreedAt: null,
allowEmbedIframes: false,
},
{
}, {
email: 'user@example.org',
},
)
})
describe('as another user', () => {
beforeEach(async () => {
beforeEach(async() => {
const someoneElse = await Factory.build(
'user',
{
'user', {
name: 'James Doe',
},
{
}, {
email: 'someone-else@example.org',
},
)
@ -157,18 +151,18 @@ describe('UpdateUser', () => {
authenticatedUser = await someoneElse.toJson()
})
it('is not allowed to change other user accounts', async () => {
it('is not allowed to change other user accounts', async() => {
const { errors } = await mutate({ mutation: updateUserMutation, variables })
expect(errors[0]).toHaveProperty('message', 'Not Authorised!')
})
})
describe('as the same user', () => {
beforeEach(async () => {
beforeEach(async() => {
authenticatedUser = await user.toJson()
})
it('updates the name', async () => {
it('updates the name', async() => {
const expected = {
data: {
UpdateUser: {
@ -184,10 +178,10 @@ describe('UpdateUser', () => {
})
describe('given a new agreed version of terms and conditions', () => {
beforeEach(async () => {
variables = { ...variables, termsAndConditionsAgreedVersion: '0.0.2' }
beforeEach(async() => {
variables = {...variables, termsAndConditionsAgreedVersion: '0.0.2' }
})
it('update termsAndConditionsAgreedVersion', async () => {
it('update termsAndConditionsAgreedVersion', async() => {
const expected = {
data: {
UpdateUser: expect.objectContaining({
@ -205,10 +199,10 @@ describe('UpdateUser', () => {
})
describe('given any attribute other than termsAndConditionsAgreedVersion', () => {
beforeEach(async () => {
variables = { ...variables, name: 'any name' }
beforeEach(async() => {
variables = {...variables, name: 'any name' }
})
it('update termsAndConditionsAgreedVersion', async () => {
it('update termsAndConditionsAgreedVersion', async() => {
const expected = {
data: {
UpdateUser: expect.objectContaining({
@ -225,7 +219,7 @@ describe('UpdateUser', () => {
})
})
it('rejects if version of terms and conditions has wrong format', async () => {
it('rejects if version of terms and conditions has wrong format', async() => {
variables = {
...variables,
termsAndConditionsAgreedVersion: 'invalid version format',
@ -234,8 +228,8 @@ describe('UpdateUser', () => {
expect(errors[0]).toHaveProperty('message', 'Invalid version format!')
})
it('supports updating location', async () => {
variables = { ...variables, locationName: 'Hamburg, New Jersey, United States of America' }
it('supports updating location', async() => {
variables = {...variables, locationName: 'Hamburg, New Jersey, United States of America' }
await expect(mutate({ mutation: updateUserMutation, variables })).resolves.toMatchObject({
data: { UpdateUser: { locationName: 'Hamburg, New Jersey, United States of America' } },
errors: undefined,
@ -244,37 +238,9 @@ describe('UpdateUser', () => {
})
})
describe('DeleteUser', () => {
const deleteUserMutation = gql`
mutation($id: ID!, $resource: [Deletable]) {
DeleteUser(id: $id, resource: $resource) {
id
name
about
deleted
contributions {
id
content
contentExcerpt
deleted
comments {
id
content
contentExcerpt
deleted
}
}
comments {
id
content
contentExcerpt
deleted
}
}
}
`
describe('as another user', () => {
beforeEach(async () => {
describe('Delete a User as another user', () => {
beforeEach(async() => {
variables = { id: ' u343', resource: [] }
user = await Factory.build('user', {
@ -284,13 +250,11 @@ describe('DeleteUser', () => {
})
})
beforeEach(async () => {
const anotherUser = await Factory.build(
'user',
{
beforeEach(async() => {
anotherUser = await Factory.build(
'user', {
role: 'user',
},
{
}, {
email: 'user@example.org',
password: '1234',
},
@ -299,14 +263,14 @@ describe('DeleteUser', () => {
authenticatedUser = await anotherUser.toJson()
})
it("an ordinary user has no authorization to delete another user's account", async () => {
it("an ordinary user has no authorization to delete another user's account", async() => {
const { errors } = await mutate({ mutation: deleteUserMutation, variables })
expect(errors[0]).toHaveProperty('message', 'Not Authorised!')
})
})
})
describe('as moderator', () => {
beforeEach(async () => {
describe('Delete a User as moderator', () => {
beforeEach(async() => {
variables = { id: ' u343', resource: [] }
user = await Factory.build('user', {
@ -316,13 +280,11 @@ describe('DeleteUser', () => {
})
})
beforeEach(async () => {
const moderator = await Factory.build(
'user',
{
beforeEach(async() => {
moderator = await Factory.build(
'user', {
role: 'moderator',
},
{
}, {
email: 'moderator@example.org',
password: '1234',
},
@ -331,14 +293,14 @@ describe('DeleteUser', () => {
authenticatedUser = await moderator.toJson()
})
it('moderator is not allowed to delete other user accounts', async () => {
it('moderator is not allowed to delete other user accounts', async() => {
const { errors } = await mutate({ mutation: deleteUserMutation, variables })
expect(errors[0]).toHaveProperty('message', 'Not Authorised!')
})
})
})
describe('as admin', () => {
beforeEach(async () => {
describe('Delete a User as admin', () => {
beforeEach(async() => {
variables = { id: ' u343', resource: [] }
user = await Factory.build('user', {
@ -349,13 +311,11 @@ describe('DeleteUser', () => {
})
describe('authenticated as Admin', () => {
beforeEach(async () => {
const admin = await Factory.build(
'user',
{
beforeEach(async() => {
admin = await Factory.build(
'user', {
role: 'admin',
},
{
}, {
email: 'admin@example.org',
password: '1234',
},
@ -365,50 +325,44 @@ describe('DeleteUser', () => {
describe('deleting a user account', () => {
beforeEach(() => {
variables = { ...variables, id: 'u343' }
variables = {...variables, id: 'u343' }
})
describe('given posts and comments', () => {
beforeEach(async () => {
beforeEach(async() => {
await Factory.build('category', {
id: 'cat9',
name: 'Democracy & Politics',
icon: 'university',
})
await Factory.build(
'post',
{
'post', {
id: 'p139',
content: 'Post by user u343',
},
{
}, {
author: user,
categoryIds,
},
)
await Factory.build(
'comment',
{
'comment', {
id: 'c155',
content: 'Comment by user u343',
},
{
}, {
author: user,
},
)
await Factory.build(
'comment',
{
'comment', {
id: 'c156',
content: "A comment by someone else on user u343's post",
},
{
}, {
postId: 'p139',
},
)
})
it("deletes account, but doesn't delete posts or comments by default", async () => {
it("deletes account, but doesn't delete posts or comments by default", async() => {
const expectedResponse = {
data: {
DeleteUser: {
@ -416,46 +370,39 @@ describe('DeleteUser', () => {
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
contributions: [{
id: 'p139',
content: 'Post by user u343',
contentExcerpt: 'Post by user u343',
deleted: false,
comments: [
{
comments: [{
id: 'c156',
content: "A comment by someone else on user u343's post",
contentExcerpt: "A comment by someone else on user u343's post",
deleted: false,
},
],
},
],
comments: [
{
}, ],
}, ],
comments: [{
id: 'c155',
content: 'Comment by user u343',
contentExcerpt: 'Comment by user u343',
deleted: false,
},
],
}, ],
},
},
errors: undefined,
}
await expect(
mutate({ mutation: deleteUserMutation, variables }),
).resolves.toMatchObject(expectedResponse)
await expect(mutate({ mutation: deleteUserMutation, variables })).resolves.toMatchObject(
expectedResponse,
)
})
describe('deletion of all post requested', () => {
beforeEach(() => {
variables = { ...variables, resource: ['Post'] }
variables = {...variables, resource: ['Post'] }
})
describe("marks user's posts as deleted", () => {
it('on request', async () => {
it('on request', async() => {
const expectedResponse = {
data: {
DeleteUser: {
@ -463,30 +410,24 @@ describe('DeleteUser', () => {
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
contributions: [{
id: 'p139',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
comments: [
{
comments: [{
id: 'c156',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
},
],
comments: [
{
}, ],
}, ],
comments: [{
id: 'c155',
content: 'Comment by user u343',
contentExcerpt: 'Comment by user u343',
deleted: false,
},
],
}, ],
},
},
errors: undefined,
@ -496,20 +437,19 @@ describe('DeleteUser', () => {
).resolves.toMatchObject(expectedResponse)
})
it('deletes user avatar and post hero images', async () => {
it('deletes user avatar and post hero images', async() => {
await expect(neode.all('Image')).resolves.toHaveLength(22)
await mutate({ mutation: deleteUserMutation, variables })
await expect(neode.all('Image')).resolves.toHaveLength(20)
})
})
})
describe('deletion of all comments requested', () => {
beforeEach(() => {
variables = { ...variables, resource: ['Comment'] }
variables = {...variables, resource: ['Comment'] }
})
it('marks comments as deleted', async () => {
it('marks comments as deleted', async() => {
const expectedResponse = {
data: {
DeleteUser: {
@ -517,30 +457,24 @@ describe('DeleteUser', () => {
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
contributions: [{
id: 'p139',
content: 'Post by user u343',
contentExcerpt: 'Post by user u343',
deleted: false,
comments: [
{
comments: [{
id: 'c156',
content: "A comment by someone else on user u343's post",
contentExcerpt: "A comment by someone else on user u343's post",
deleted: false,
},
],
},
],
comments: [
{
}, ],
}, ],
comments: [{
id: 'c155',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
}, ],
},
},
errors: undefined,
@ -553,10 +487,10 @@ describe('DeleteUser', () => {
describe('deletion of all posts and comments requested', () => {
beforeEach(() => {
variables = { ...variables, resource: ['Post', 'Comment'] }
variables = {...variables, resource: ['Comment', 'Post'] }
})
it('marks posts and comments as deleted', async () => {
it('marks posts and comments as deleted', async() => {
const expectedResponse = {
data: {
DeleteUser: {
@ -564,30 +498,24 @@ describe('DeleteUser', () => {
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
contributions: [{
id: 'p139',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
comments: [
{
comments: [{
id: 'c156',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
},
],
comments: [
{
}, ],
}, ],
comments: [{
id: 'c155',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
}, ],
},
},
errors: undefined,
@ -600,20 +528,21 @@ describe('DeleteUser', () => {
})
describe('connected `EmailAddress` nodes', () => {
it('will be removed completely', async () => {
it('will be removed completely', async() => {
await expect(neode.all('EmailAddress')).resolves.toHaveLength(2)
await mutate({ mutation: deleteUserMutation, variables })
await expect(neode.all('EmailAddress')).resolves.toHaveLength(1)
})
})
describe('connected `SocialMedia` nodes', () => {
beforeEach(async () => {
beforeEach(async() => {
const socialMedia = await Factory.build('socialMedia')
await socialMedia.relateTo(user, 'ownedBy')
})
it('will be removed completely', async () => {
it('will be removed completely', async() => {
await expect(neode.all('SocialMedia')).resolves.toHaveLength(1)
await mutate({ mutation: deleteUserMutation, variables })
await expect(neode.all('SocialMedia')).resolves.toHaveLength(0)
@ -621,300 +550,4 @@ describe('DeleteUser', () => {
})
})
})
})
describe('user deletes his own account', () => {
beforeEach(async () => {
variables = { id: 'u343', resource: [] }
user = await Factory.build('user', {
name: 'My name should be deleted',
about: 'along with my about',
id: 'u343',
})
await Factory.build(
'user',
{
id: 'not-my-account',
},
{
email: 'friends-account@example.org',
},
)
})
describe('authenticated', () => {
beforeEach(async () => {
authenticatedUser = await user.toJson()
})
describe("attempting to delete another user's account", () => {
beforeEach(() => {
variables = { ...variables, id: 'not-my-account' }
})
it('throws an authorization error', async () => {
const { errors } = await mutate({ mutation: deleteUserMutation, variables })
expect(errors[0]).toHaveProperty('message', 'Not Authorised!')
})
})
describe('attempting to delete my own account', () => {
beforeEach(() => {
variables = { ...variables, id: 'u343' }
})
describe('given posts and comments', () => {
beforeEach(async () => {
await Factory.build('category', {
id: 'cat9',
name: 'Democracy & Politics',
icon: 'university',
})
await Factory.build(
'post',
{
id: 'p139',
content: 'Post by user u343',
},
{
author: user,
categoryIds,
},
)
await Factory.build(
'comment',
{
id: 'c155',
content: 'Comment by user u343',
},
{
author: user,
},
)
await Factory.build(
'comment',
{
id: 'c156',
content: "A comment by someone else on user u343's post",
},
{
postId: 'p139',
},
)
})
it("deletes my account, but doesn't delete posts or comments by default", async () => {
const expectedResponse = {
data: {
DeleteUser: {
id: 'u343',
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
id: 'p139',
content: 'Post by user u343',
contentExcerpt: 'Post by user u343',
deleted: false,
comments: [
{
id: 'c156',
content: "A comment by someone else on user u343's post",
contentExcerpt: "A comment by someone else on user u343's post",
deleted: false,
},
],
},
],
comments: [
{
id: 'c155',
content: 'Comment by user u343',
contentExcerpt: 'Comment by user u343',
deleted: false,
},
],
},
},
errors: undefined,
}
await expect(
mutate({ mutation: deleteUserMutation, variables }),
).resolves.toMatchObject(expectedResponse)
})
describe('deletion of all post requested', () => {
beforeEach(() => {
variables = { ...variables, resource: ['Post'] }
})
describe("marks user's posts as deleted", () => {
it('posts on request', async () => {
const expectedResponse = {
data: {
DeleteUser: {
id: 'u343',
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
id: 'p139',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
comments: [
{
id: 'c156',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
},
],
comments: [
{
id: 'c155',
content: 'Comment by user u343',
contentExcerpt: 'Comment by user u343',
deleted: false,
},
],
},
},
errors: undefined,
}
await expect(
mutate({ mutation: deleteUserMutation, variables }),
).resolves.toMatchObject(expectedResponse)
})
it('deletes user avatar and post hero images', async () => {
await expect(neode.all('Image')).resolves.toHaveLength(22)
await mutate({ mutation: deleteUserMutation, variables })
await expect(neode.all('Image')).resolves.toHaveLength(20)
})
})
})
describe('deletion of all comments requested', () => {
beforeEach(() => {
variables = { ...variables, resource: ['Comment'] }
})
it('marks comments as deleted', async () => {
const expectedResponse = {
data: {
DeleteUser: {
id: 'u343',
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
id: 'p139',
content: 'Post by user u343',
contentExcerpt: 'Post by user u343',
deleted: false,
comments: [
{
id: 'c156',
content: "A comment by someone else on user u343's post",
contentExcerpt: "A comment by someone else on user u343's post",
deleted: false,
},
],
},
],
comments: [
{
id: 'c155',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
},
},
errors: undefined,
}
await expect(
mutate({ mutation: deleteUserMutation, variables }),
).resolves.toMatchObject(expectedResponse)
})
})
describe('deletion of all post and comments requested', () => {
beforeEach(() => {
variables = { ...variables, resource: ['Post', 'Comment'] }
})
it('marks posts and comments as deleted', async () => {
const expectedResponse = {
data: {
DeleteUser: {
id: 'u343',
name: 'UNAVAILABLE',
about: 'UNAVAILABLE',
deleted: true,
contributions: [
{
id: 'p139',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
comments: [
{
id: 'c156',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
},
],
comments: [
{
id: 'c155',
content: 'UNAVAILABLE',
contentExcerpt: 'UNAVAILABLE',
deleted: true,
},
],
},
},
errors: undefined,
}
await expect(
mutate({ mutation: deleteUserMutation, variables }),
).resolves.toMatchObject(expectedResponse)
})
})
})
})
})
describe('connected `EmailAddress` nodes', () => {
it('will be removed completely', async () => {
await expect(neode.all('EmailAddress')).resolves.toHaveLength(2)
await mutate({ mutation: deleteUserMutation, variables })
await expect(neode.all('EmailAddress')).resolves.toHaveLength(1)
})
})
describe('connected `SocialMedia` nodes', () => {
beforeEach(async () => {
const socialMedia = await Factory.build('socialMedia')
await socialMedia.relateTo(user, 'ownedBy')
})
it('will be removed completely', async () => {
await expect(neode.all('SocialMedia')).resolves.toHaveLength(1)
await mutate({ mutation: deleteUserMutation, variables })
await expect(neode.all('SocialMedia')).resolves.toHaveLength(0)
})
})
})
})