ocelot-Social-Community/Ocelot-Social
1
0
Fork 0
mirror of https://github.com/Ocelot-Social-Community/Ocelot-Social.git synced 2025-12-13 07:46:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid 'else' cases after exit in the 'if' case

Browse Source 
- Remove todo.
This commit is contained in:
Wolfgang Huß 2023-11-29 10:03:29 +01:00
parent 69c8740f35
commit aeb1432630
1 changed files with 16 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
deployment/scripts/clusters.backup-multiple-servers.sh
View File

@ -21,16 +21,6 @@ if [[ -z ${BACKUP_CONFIGURATIONS} ]]; then
#%! echo "You must provide a BACKUP_CONFIGURATIONS via environment variable" #%! echo "You must provide a BACKUP_CONFIGURATIONS via environment variable"
printf "!!! You must provide a BACKUP_CONFIGURATIONS via environment variable !!!\n" printf "!!! You must provide a BACKUP_CONFIGURATIONS via environment variable !!!\n"
exit 1 exit 1
else
# convert configurations to array
IFS=' ' read -a CONFIGURATIONS_ARRAY <<< "$BACKUP_CONFIGURATIONS"
# display the clusters
printf "Backup the clusters:\n"
for i in "${CONFIGURATIONS_ARRAY[@]}"
do
echo " $i"
done
fi fi
# check BACKUP_SAVED_BACKUPS_NUMBER # check BACKUP_SAVED_BACKUPS_NUMBER
@ -38,13 +28,23 @@ if [[ -z ${BACKUP_SAVED_BACKUPS_NUMBER} ]]; then
#%! echo "You must provide a BACKUP_SAVED_BACKUPS_NUMBER via environment variable" #%! echo "You must provide a BACKUP_SAVED_BACKUPS_NUMBER via environment variable"
printf "!!! You must provide a BACKUP_SAVED_BACKUPS_NUMBER via environment variable !!!\n" printf "!!! You must provide a BACKUP_SAVED_BACKUPS_NUMBER via environment variable !!!\n"
exit 1 exit 1
fi
# convert configurations to array
IFS=' ' read -a CONFIGURATIONS_ARRAY <<< "$BACKUP_CONFIGURATIONS"
# display the clusters
printf "Backup the clusters:\n"
for i in "${CONFIGURATIONS_ARRAY[@]}"
do
echo " $i"
done
# deleting backups?
if (( BACKUP_SAVED_BACKUPS_NUMBER >= 1 )); then
printf "Keep the last %d backups for all networks.\n" $BACKUP_SAVED_BACKUPS_NUMBER
else else
# deleting backups? echo "!!! ATTENTION: No backups are deleted !!!"
if (( BACKUP_SAVED_BACKUPS_NUMBER >= 1 )); then
printf "Keep the last %d backups for all networks.\n" $BACKUP_SAVED_BACKUPS_NUMBER
else
echo "!!! ATTENTION: No backups are deleted !!!"
fi
fi fi
echo "Cancel by ^C. You have 15 seconds" echo "Cancel by ^C. You have 15 seconds"
@ -70,8 +70,6 @@ do
printf "In\n '$path'\n remove:\n" printf "In\n '$path'\n remove:\n"
while [ `ls -1 | wc -l` -gt $keep ]; do while [ `ls -1 | wc -l` -gt $keep ]; do
# TODO: because 'ls' is not always relyable the same on different shells maybe replace 'ls' by 'find . -type d -maxdepth 1'? description: https://unix.stackexchange.com/questions/28939/how-to-delete-the-oldest-directory-in-a-given-directory
# I tested this, but 'find' is crutial to use, because of shell compatibilities
oldest=`ls -c1 | sort -n | head -1` oldest=`ls -c1 | sort -n | head -1`
printf " %s\n" $oldest printf " %s\n" $oldest
rm -rf $oldest rm -rf $oldest