From b09766a0a2c0e722e2f15cbc61a7da0457e728f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= <wolle.huss@pjannto.com>
Date: Wed, 10 Feb 2021 18:23:33 +0100
Subject: [PATCH] Fix linting and clean up

---
 .../ComponentSlider/ComponentSlider.vue         |  2 --
 .../RegistrationItemCreateUserAccount.vue       |  4 ++--
 .../Registration/RegistrationItemEnterEmail.vue | 17 ++++++++---------
 .../RegistrationItemEnterInvite.vue             |  4 +---
 .../Registration/RegistrationItemEnterNonce.vue |  3 +--
 .../Registration/RegistrationSlider.story.js    |  6 ++----
 .../Registration/RegistrationSlider.vue         |  3 ---
 7 files changed, 14 insertions(+), 25 deletions(-)

diff --git a/webapp/components/ComponentSlider/ComponentSlider.vue b/webapp/components/ComponentSlider/ComponentSlider.vue
index ececc1aa8..6a1111f54 100644
--- a/webapp/components/ComponentSlider/ComponentSlider.vue
+++ b/webapp/components/ComponentSlider/ComponentSlider.vue
@@ -58,8 +58,6 @@ export default {
       return this.sliderData.sliderIndex // have a shorter notation
     },
   },
-  methods: {
-  },
 }
 </script>
 
diff --git a/webapp/components/Registration/RegistrationItemCreateUserAccount.vue b/webapp/components/Registration/RegistrationItemCreateUserAccount.vue
index 3c945c7d2..f76dfba98 100644
--- a/webapp/components/Registration/RegistrationItemCreateUserAccount.vue
+++ b/webapp/components/Registration/RegistrationItemCreateUserAccount.vue
@@ -37,7 +37,8 @@
       @input="handleInput"
       @input-valid="handleInputValid"
     >
-      <!-- <template v-slot="{ errors }"> --> <!-- leave this here in case the scoped variable is needed in the future nobody would remember this -->
+      <!-- leave this here in case the scoped variable is needed in the future nobody would remember this -->
+      <!-- <template v-slot="{ errors }"> -->
       <template>
         <ds-input
           id="name"
@@ -238,7 +239,6 @@ export default {
         this.minimumAge &&
         this.noCommercial &&
         this.noPolitical
-      console.log('valid : ', isValid)
       return isValid
     },
   },
diff --git a/webapp/components/Registration/RegistrationItemEnterEmail.vue b/webapp/components/Registration/RegistrationItemEnterEmail.vue
index 30daea695..b381f57a1 100644
--- a/webapp/components/Registration/RegistrationItemEnterEmail.vue
+++ b/webapp/components/Registration/RegistrationItemEnterEmail.vue
@@ -14,7 +14,10 @@
             : $t('components.registration.signup.title', metadata)
         }}
       </h1> -->
-      <ds-text v-if="token" v-html="$t('registration.signup.form.invitation-code', { code: token })" />
+      <ds-text
+        v-if="token"
+        v-html="$t('registration.signup.form.invitation-code', { code: token })"
+      />
       <ds-text>
         {{
           invitation
@@ -127,23 +130,19 @@ export default {
       return this.$t('components.registration.signup.form.success', { email })
     },
     valid() {
-      let isValid
-      if (isEmail(this.formData.email)) {
-        this.formData.email = normalizeEmail(this.formData.email)
-        isValid = true
-      } else {
-        isValid = false
-      }
+      const isValid = isEmail(this.formData.email)
       return isValid
     },
   },
   methods: {
     sendValidation() {
+      if (this.formData.email && isEmail(this.formData.email)) {
+        this.formData.email = normalizeEmail(this.formData.email)
+      }
       const { email } = this.formData
       const value = {
         email,
       }
-      // console.log('sendValidation !!! value: ', value)
       this.sliderData.validateCallback(this.valid, value)
     },
     handleInput() {
diff --git a/webapp/components/Registration/RegistrationItemEnterInvite.vue b/webapp/components/Registration/RegistrationItemEnterInvite.vue
index b2848ad81..f0f0ccdfe 100644
--- a/webapp/components/Registration/RegistrationItemEnterInvite.vue
+++ b/webapp/components/Registration/RegistrationItemEnterInvite.vue
@@ -46,7 +46,6 @@ export default {
   mounted: function () {
     this.$nextTick(function () {
       // Code that will run only after the entire view has been rendered
-      console.log('mounted !!! this.sliderData.collectedInputData.inviteCode: ', this.sliderData.collectedInputData.inviteCode)
       this.formData.inviteCode = this.sliderData.collectedInputData.inviteCode
         ? this.sliderData.collectedInputData.inviteCode
         : ''
@@ -55,8 +54,7 @@ export default {
   },
   computed: {
     valid() {
-      const isValid =
-        this.formData.inviteCode.length === 6
+      const isValid = this.formData.inviteCode.length === 6
       return isValid
     },
   },
diff --git a/webapp/components/Registration/RegistrationItemEnterNonce.vue b/webapp/components/Registration/RegistrationItemEnterNonce.vue
index 25006779c..367d0fc17 100644
--- a/webapp/components/Registration/RegistrationItemEnterNonce.vue
+++ b/webapp/components/Registration/RegistrationItemEnterNonce.vue
@@ -64,8 +64,7 @@ export default {
   },
   computed: {
     valid() {
-      const isValid =
-        this.formData.nonce.length === 6
+      const isValid = this.formData.nonce.length === 6
       return isValid
     },
   },
diff --git a/webapp/components/Registration/RegistrationSlider.story.js b/webapp/components/Registration/RegistrationSlider.story.js
index fe5ad9b5d..25422b324 100644
--- a/webapp/components/Registration/RegistrationSlider.story.js
+++ b/webapp/components/Registration/RegistrationSlider.story.js
@@ -11,8 +11,7 @@ storiesOf('RegistrationSlider', module)
   .add('invite-code empty', () => ({
     components: { RegistrationSlider },
     store: helpers.store,
-    data: () => ({
-    }),
+    data: () => ({}),
     template: `
       <registration-slider registrationType="invite-code" />
     `,
@@ -48,8 +47,7 @@ storiesOf('RegistrationSlider', module)
   .add('public-registration empty', () => ({
     components: { RegistrationSlider },
     store: helpers.store,
-    data: () => ({
-    }),
+    data: () => ({}),
     template: `
       <registration-slider registrationType="public-registration" />
     `,
diff --git a/webapp/components/Registration/RegistrationSlider.vue b/webapp/components/Registration/RegistrationSlider.vue
index 0a639145b..d073c1132 100644
--- a/webapp/components/Registration/RegistrationSlider.vue
+++ b/webapp/components/Registration/RegistrationSlider.vue
@@ -60,7 +60,6 @@
 import links from '~/constants/links.js'
 import metadata from '~/constants/metadata.js'
 import ComponentSlider from '~/components/ComponentSlider/ComponentSlider'
-import HcEmpty from '~/components/Empty/Empty'
 import LocaleSwitch from '~/components/LocaleSwitch/LocaleSwitch'
 import RegistrationItemCreateUserAccount from './RegistrationItemCreateUserAccount'
 import RegistrationItemEnterEmail from '~/components/Registration/RegistrationItemEnterEmail'
@@ -71,7 +70,6 @@ export default {
   name: 'RegistrationSlider',
   components: {
     ComponentSlider,
-    HcEmpty,
     LocaleSwitch,
     RegistrationItemCreateUserAccount,
     RegistrationItemEnterEmail,
@@ -198,7 +196,6 @@ export default {
     },
     buttonCallback() {
       if (this.sliderData.sliders[this.sliderIndex].name === 'enter-email') {
-        console.log('buttonCallback !!! enter-email')
         this.sliderData.collectedInputData.emailSend = true
         this.sliderData.sliders[this.sliderIndex].button.title = 'Resend E-Mail' // Wolle
       }