From bcbce2a34a5f73d7b157a63dd93b686e51fbf61f Mon Sep 17 00:00:00 2001
From: mattwr18 <mattwr18@gmail.com>
Date: Mon, 2 Dec 2019 20:50:55 +0100
Subject: [PATCH] Refactor modalData to use mapMutations, computed

- clean it up some
---
 .../_new/features/ReportList/ReportList.vue   | 93 ++++++++++---------
 1 file changed, 49 insertions(+), 44 deletions(-)

diff --git a/webapp/components/_new/features/ReportList/ReportList.vue b/webapp/components/_new/features/ReportList/ReportList.vue
index 2a141a875..c4269ac13 100644
--- a/webapp/components/_new/features/ReportList/ReportList.vue
+++ b/webapp/components/_new/features/ReportList/ReportList.vue
@@ -15,6 +15,7 @@
   </ds-card>
 </template>
 <script>
+import { mapMutations } from 'vuex'
 import DropdownFilter from '~/components/DropdownFilter/DropdownFilter'
 import ReportsTable from '~/components/_new/features/ReportsTable/ReportsTable'
 import { reportsListQuery, reviewMutation } from '~/graphql/Moderation.js'
@@ -46,8 +47,55 @@ export default {
         { label: this.$t('moderation.reports.filterLabel.closed'), value: this.closedReports },
       ]
     },
+    modalData() {
+      return function(report) {
+        const identStart =
+          'moderation.reports.decideModal.' +
+          report.resource.__typename +
+          '.' +
+          (report.resource.disabled ? 'disable' : 'enable')
+        return {
+          name: 'confirm',
+          data: {
+            type: report.resource.__typename,
+            resource: report.resource,
+            modalData: {
+              titleIdent: identStart + '.title',
+              messageIdent: identStart + '.message',
+              messageParams: {
+                name:
+                  report.resource.name ||
+                  this.$filters.truncate(report.resource.title, 30) ||
+                  this.$filters.truncate(
+                    this.$filters.removeHtml(report.resource.contentExcerpt),
+                    30,
+                  ),
+              },
+              buttons: {
+                confirm: {
+                  danger: true,
+                  icon: report.resource.disabled ? 'eye-slash' : 'eye',
+                  textIdent: 'moderation.reports.decideModal.submit',
+                  callback: () => {
+                    this.confirmCallback(report.resource)
+                  },
+                },
+                cancel: {
+                  icon: 'close',
+                  textIdent: 'moderation.reports.decideModal.cancel',
+                  callback: () => {},
+                },
+              },
+            },
+          },
+        }
+      }
+    },
   },
   methods: {
+    ...mapMutations({
+      commitModalData: 'modal/SET_OPEN',
+    }),
     filter(option) {
       this.reports = option.value
       this.selected = option.label
@@ -69,50 +117,7 @@ export default {
         .catch(error => this.$toast.error(error.message))
     },
     openModal(report) {
-      const identStart =
-        'moderation.reports.decideModal.' +
-        report.resource.__typename +
-        '.' +
-        (report.resource.disabled ? 'disable' : 'enable')
-      this.$store.commit('modal/SET_OPEN', {
-        name: 'confirm',
-        data: {
-          type: report.resource.__typename,
-          resource: report.resource,
-          modalData: {
-            titleIdent: identStart + '.title',
-            messageIdent: identStart + '.message',
-            messageParams: {
-              name:
-                report.resource.__typename === 'User'
-                  ? report.resource.name
-                  : report.resource.__typename === 'Post'
-                  ? this.$filters.truncate(report.resource.title, 30)
-                  : report.resource.__typename === 'Comment'
-                  ? this.$filters.truncate(
-                      this.$filters.removeHtml(report.resource.contentExcerpt),
-                      30,
-                    )
-                  : '',
-            },
-            buttons: {
-              confirm: {
-                danger: true,
-                icon: report.resource.disabled ? 'eye-slash' : 'eye',
-                textIdent: 'moderation.reports.decideModal.submit',
-                callback: () => {
-                  this.confirmCallback(report.resource)
-                },
-              },
-              cancel: {
-                icon: 'close',
-                textIdent: 'moderation.reports.decideModal.cancel',
-                callback: () => {},
-              },
-            },
-          },
-        },
-      })
+      this.commitModalData(this.modalData(report))
     },
   },
   apollo: {