From c22a6330aadf560ce84f30c443b0a2b93ade543c Mon Sep 17 00:00:00 2001 From: roschaefer Date: Thu, 16 Jan 2020 20:53:09 +0100 Subject: [PATCH] refactor(translations): Fix keys for muting Provide the correct German translation. Remove "" and use `null` for Italian. @mattwr18 we really have to make sure not to add empty strings to our translations because we disable the fallback in that case. Also, if we want, we could replace the other translations with `null` in order to make sure that we have the better (though untranslated) explanation. @mattwr18 I had a look into `notificationsMiddleware.js`. I think that we can still keep the tests and the behaviour although there is no `BLOCKED` relationship anymore, right? --- webapp/locales/de.json | 21 +++++++++------------ webapp/locales/en.json | 5 +---- webapp/locales/es.json | 7 ++----- webapp/locales/fr.json | 5 +---- webapp/locales/it.json | 27 ++++++++++++--------------- webapp/locales/pt.json | 5 +---- webapp/locales/ru.json | 3 --- webapp/pages/profile/_id/_slug.vue | 2 +- webapp/pages/settings/muted-users.vue | 11 +---------- 9 files changed, 28 insertions(+), 58 deletions(-) diff --git a/webapp/locales/de.json b/webapp/locales/de.json index 56027910c..63b22e450 100644 --- a/webapp/locales/de.json +++ b/webapp/locales/de.json @@ -146,25 +146,22 @@ "successDelete": "Social-Media gelöscht. Profil aktualisiert!" }, "muted-users": { - "name": "Blockierte Benutzer", + "name": "Stummgeschaltete Benutzer", "explanation": { - "intro": "Wenn ein anderer Benutzer von dir blockiert wurde, dann passiert folgendes:", - "your-perspective": "In deiner Beitragsübersicht tauchen keine Beiträge der blockierten Person mehr auf.", - "their-perspective": "Umgekehrt das gleiche: Die blockierte Person sieht deine Beiträge auch nicht mehr in ihrer Übersicht.", - "search": "Die Beiträge von blockierten Personen verschwinden aus deinen Suchergebnissen.", - "notifications": "Von dir blockierte Personen erhalten keine Benachrichtigungen mehr, wenn sie in deinen Beiträgen erwähnt werden.", - "closing": "Das sollte fürs Erste genügen, damit blockierte Benutzer dich nicht mehr länger belästigen können." + "intro": "Wenn ein anderer Benutzer von dir stummgeschaltet wurde, dann passiert folgendes:", + "your-perspective": "In deiner Beitragsübersicht tauchen keine Beiträge der stummgeschalteten Person mehr auf.", + "search": "Die Beiträge von stummgeschalteten Personen verschwinden aus deinen Suchergebnissen." }, "columns": { "name": "Name", "slug": "Alias", "unmute": "Entsperren" }, - "empty": "Bislang hast du niemanden blockiert.", - "how-to": "Du kannst andere Benutzer auf deren Profilseite über das Inhaltsmenü blockieren.", - "mute": "Nutzer blockieren", - "unmute": "Nutzer entblocken", - "unblocked": "{name} ist wieder entsperrt" + "empty": "Bislang hast du niemanden stummgeschaltet.", + "how-to": "Du kannst andere Benutzer auf deren Profilseite über das Inhaltsmenü stummschalten.", + "mute": "Stumm schalten", + "unmute": "Stummschaltung aufheben", + "unmuted": "{name} ist nicht mehr stummgeschaltet" }, "privacy": { "name": "Privatsphäre", diff --git a/webapp/locales/en.json b/webapp/locales/en.json index 6acc40797..03876c8c2 100644 --- a/webapp/locales/en.json +++ b/webapp/locales/en.json @@ -318,10 +318,7 @@ "explanation": { "intro": "If another user has been muted by you, this is what happens:", "your-perspective": "The muted person's posts will no longer appear in your news feed.", - "their-perspective": "However: The muted person will still be able to see your posts in their news feed.", - "search": "Posts of muted people disappear from your search results.", - "notifications": "Muted users will still receive notifications if they are mentioned in your posts.", - "closing": "This should be sufficient for filtering out content from muted users." + "search": "Posts of muted people disappear from your search results." }, "columns": { "name": "Name", diff --git a/webapp/locales/es.json b/webapp/locales/es.json index a8928626c..04a4fe233 100644 --- a/webapp/locales/es.json +++ b/webapp/locales/es.json @@ -150,10 +150,7 @@ "explanation": { "intro": "Si otro usuario ha sido bloqueado por usted, esto es lo que sucede:", "your-perspective": "Las contribuciones de la persona bloqueada no aparecerán más en su canal de noticias.", - "their-perspective": "Viceversa: la persona bloqueada tampoco verá más sus contribuciones en sus noticias.", - "search": "Las contribuciones de personas bloqueadas desaparecen de los resultados de búsqueda.", - "notifications": "Los usuarios bloqueados no recibirán más notificaciones si se mencionan en sus contribuciones.", - "closing": "Esto debería ser suficiente por ahora para que los usuarios bloqueados no puedan molestarle más." + "search": "Las contribuciones de personas bloqueadas desaparecen de los resultados de búsqueda." }, "columns": { "name": "Nombre", @@ -164,7 +161,7 @@ "how-to": "Puede bloquear a otros usuarios en la página de perfil de aquellos a través del menú de contenido.", "mute": "Bloquear usuario", "unmute": "Desbloquear usuario", - "unblocked": "{name} está desbloqueado nuevamente" + "unmuted": "{name} está desbloqueado nuevamente" }, "privacy": { "name": "Privacidad", diff --git a/webapp/locales/fr.json b/webapp/locales/fr.json index 2215c8b12..822de7a5b 100644 --- a/webapp/locales/fr.json +++ b/webapp/locales/fr.json @@ -150,10 +150,7 @@ "explanation": { "intro": "Si vous avez bloqué un autre utilisateur, voici ce qui se passe:", "your-perspective": "Les postes de la personne bloquée n'apparaîtront dans votre fil d'actualités.", - "their-perspective": "Vice versa: la personne bloquée ne verra plus non plus vos postes dans son fil d'actualités.", - "search": "Les postes des personnes bloquées disparaissent de vos résultats de recherche.", - "notifications": "Les utilisateurs bloqués ne recevront plus de notifications s'ils sont mentionnés dans vos postes.", - "closing": "Ceci devrait être suffisant pour le moment afin que les utilisateurs bloqués ne puissent plus vous déranger." + "search": "Les postes des personnes bloquées disparaissent de vos résultats de recherche." }, "columns": { "name": "Nom", diff --git a/webapp/locales/it.json b/webapp/locales/it.json index 337e2a960..5d44fc706 100644 --- a/webapp/locales/it.json +++ b/webapp/locales/it.json @@ -146,25 +146,22 @@ "successDelete": "Social media cancellati. Profilo utente aggiornato!" }, "muted-users": { - "name": "", + "name": null, "explanation": { - "intro": "", - "your-perspective": "", - "their-perspective": "", - "search": "", - "notifications": "", - "closing": "" + "intro": null, + "your-perspective": null, + "search": null }, "columns": { - "name": "", - "slug": "", - "unmute": "" + "name": null, + "slug": null, + "unmute": null }, - "empty": "", - "how-to": "", - "mute": "", - "unmute": "", - "unmuted": "" + "empty": null, + "how-to": null, + "mute": null, + "unmute": null, + "unmuted": null }, "privacy": { "name": "", diff --git a/webapp/locales/pt.json b/webapp/locales/pt.json index e6d381aba..ad60b31a8 100644 --- a/webapp/locales/pt.json +++ b/webapp/locales/pt.json @@ -150,10 +150,7 @@ "explanation": { "intro": "Se outro usuário foi bloqueado por você, isto é o que acontece:", "your-perspective": "As mensagens da pessoa bloqueada não aparecerão mais no seu feed de notícias.", - "their-perspective": "Vice versa: A pessoa bloqueada também não verá mais suas mensagens em seu feed de notícias.", - "search": "Publicações de pessoas bloqueadas desaparecem dos resultados da sua pesquisa.", - "notifications": "Usuários bloqueados não receberão mais notificações se forem mencionados em suas mensagens.", - "closing": "Isso deve ser suficiente por enquanto para que os usuários bloqueados não possam mais incomodá-lo." + "search": "Publicações de pessoas bloqueadas desaparecem dos resultados da sua pesquisa." }, "columns": { "name": "Nome", diff --git a/webapp/locales/ru.json b/webapp/locales/ru.json index bbf3211db..83f97cb22 100644 --- a/webapp/locales/ru.json +++ b/webapp/locales/ru.json @@ -605,11 +605,8 @@ }, "empty": "Вы пока никого не блокировали.", "explanation": { - "closing": "На данный момент этого должно быть достаточно, чтобы заблокированные пользователи больше вас не беспокоили.", "intro": "Если блокируете другого пользователя, происходит следующее:", - "notifications": "Заблокированные пользователи больше не будут получать уведомления об упоминаниях в ваших постах.", "search": "Посты заблокированных пользователей не отображаются в результатах поиска.", - "their-perspective": "И наоборот — заблокированный пользователь больше не видит ваши посты в своей ленте.", "your-perspective": "Посты заблокированного пользователя не отображаются в персональной ленте." }, "how-to": "Вы можете блокировать других пользователей на странице их профиля с помощью меню профиля.", diff --git a/webapp/pages/profile/_id/_slug.vue b/webapp/pages/profile/_id/_slug.vue index 84142029e..94e1f4204 100644 --- a/webapp/pages/profile/_id/_slug.vue +++ b/webapp/pages/profile/_id/_slug.vue @@ -74,7 +74,7 @@ @update="updateFollow" /> - {{ $t('settings.blocked-users.unblock') }} + {{ $t('settings.muted-users.unmute') }} diff --git a/webapp/pages/settings/muted-users.vue b/webapp/pages/settings/muted-users.vue index b40f6b5ed..ccef6678b 100644 --- a/webapp/pages/settings/muted-users.vue +++ b/webapp/pages/settings/muted-users.vue @@ -9,19 +9,10 @@ {{ $t('settings.muted-users.explanation.your-perspective') }} - - {{ $t('settings.muted-users.explanation.their-perspective') }} - {{ $t('settings.muted-users.explanation.search') }} - - {{ $t('settings.muted-users.explanation.notifications') }} - - - {{ $t('settings.muted-users.explanation.closing') }} - @@ -111,7 +102,7 @@ export default { }) this.$apollo.queries.mutedUsers.refetch() const { name } = user.row - this.$toast.success(this.$t('settings.muted-users.unblocked', { name })) + this.$toast.success(this.$t('settings.muted-users.unmuted', { name })) }, }, }