From c69e5915f1ef1c10f34cb2fa82d1629b565848fe Mon Sep 17 00:00:00 2001 From: Ulf Gebhardt Date: Sat, 18 May 2019 15:07:02 +0200 Subject: [PATCH] backend pretier, more linting rules --- backend/.eslintrc.js | 38 ++++++++++++++++++++++---------------- backend/.prettierrc.js | 9 +++++++++ backend/package.json | 1 + webapp/.eslintrc.js | 4 +++- 4 files changed, 35 insertions(+), 17 deletions(-) create mode 100644 backend/.prettierrc.js diff --git a/backend/.eslintrc.js b/backend/.eslintrc.js index 0fdbfd52d..7f22883a7 100644 --- a/backend/.eslintrc.js +++ b/backend/.eslintrc.js @@ -1,20 +1,26 @@ module.exports = { - "extends": "standard", - "parser": "babel-eslint", - "env": { - "es6": true, - "node": true, - "jest/globals": true + env: { + es6: true, + node: true, + 'jest/globals': true }, - "rules": { - "indent": [ - "error", - 2 - ], - "quotes": [ - "error", - "single" - ] + parserOptions: { + parser: 'babel-eslint' + }, + extends: [ + 'standard', + 'plugin:vue/recommended', + 'plugin:prettier/recommended' + ], + plugins: [ + 'jest' + ] + rules: { + 'indent': [ 'error', 2 ], + 'quotes': [ "error", "single"], + // 'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off', + 'no-console': ['error'], + 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off', + 'prettier/prettier': ['error'], }, - "plugins": ["jest"] }; diff --git a/backend/.prettierrc.js b/backend/.prettierrc.js new file mode 100644 index 000000000..e2cf91e91 --- /dev/null +++ b/backend/.prettierrc.js @@ -0,0 +1,9 @@ + +module.exports = { + semi: false, + printWidth: 100, + singleQuote: true, + trailingComma: "all", + tabWidth: 2, + bracketSpacing: true +}; diff --git a/backend/package.json b/backend/package.json index d940937a8..b3d69f415 100644 --- a/backend/package.json +++ b/backend/package.json @@ -99,6 +99,7 @@ "eslint-plugin-import": "~2.17.2", "eslint-plugin-jest": "~22.5.1", "eslint-plugin-node": "~9.0.1", + "eslint-plugin-prettier": "~3.1.0", "eslint-plugin-promise": "~4.1.1", "eslint-plugin-standard": "~4.0.0", "graphql-request": "~1.8.2", diff --git a/webapp/.eslintrc.js b/webapp/.eslintrc.js index f95b5c186..c70682986 100644 --- a/webapp/.eslintrc.js +++ b/webapp/.eslintrc.js @@ -8,6 +8,7 @@ module.exports = { parser: 'babel-eslint' }, extends: [ + 'standard', 'plugin:vue/recommended', 'plugin:prettier/recommended' ], @@ -18,7 +19,8 @@ module.exports = { ], // add your custom rules here rules: { - 'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off', + //'no-console': process.env.NODE_ENV === 'production' ? 'error' : 'off', + 'no-console': ['error'], 'no-debugger': process.env.NODE_ENV === 'production' ? 'error' : 'off', 'vue/component-name-in-template-casing': ['error', 'kebab-case'], 'prettier/prettier': ['error'],