From d049ad5d3ea7bbecd566f4ab869233fada608ed3 Mon Sep 17 00:00:00 2001
From: Moriz Wahl <moriz.wahl@gmx.de>
Date: Thu, 24 Sep 2020 13:14:35 +0200
Subject: [PATCH] changes requested by review
 https://github.com/Human-Connection/Human-Connection/pull/3271

---
 .../_new/features/SearchResults/SearchResults.vue        | 9 +++++----
 .../_new/generic/PaginationButtons/PaginationButtons.vue | 8 ++++----
 webapp/locales/de.json                                   | 3 ++-
 webapp/locales/en.json                                   | 3 ++-
 webapp/pages/search/search-results.vue                   | 2 +-
 5 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/webapp/components/_new/features/SearchResults/SearchResults.vue b/webapp/components/_new/features/SearchResults/SearchResults.vue
index 0471860c9..8d29fdbea 100644
--- a/webapp/components/_new/features/SearchResults/SearchResults.vue
+++ b/webapp/components/_new/features/SearchResults/SearchResults.vue
@@ -28,10 +28,10 @@
           :hasPrevious="hasPrevious"
           :activePage="activePage"
           :activeResourceCount="activeResourceCount"
-          @back="previousResults"
-          @next="nextResults"
           :key="'Top'"
           :pageSize="pageSize"
+          @back="previousResults"
+          @next="nextResults"
         />
         <masonry-grid v-if="activeTab === 'Post'">
           <masonry-grid-item v-for="resource in activeResources" :key="resource.key">
@@ -46,6 +46,7 @@
             </base-card>
           </li>
         </ul>
+
         <ul v-if="activeTab === 'Hashtag'" class="hashtag-list">
           <li v-for="resource in activeResources" :key="resource.key" class="item">
             <base-card :wideContent="true">
@@ -61,11 +62,11 @@
           :activePage="activePage"
           :showPageCounter="true"
           :activeResourceCount="activeResourceCount"
-          @back="previousResults"
-          @next="nextResults"
           :key="'Bottom'"
           :pageSize="pageSize"
           :srollTo="'#search-results'"
+          @back="previousResults"
+          @next="nextResults"
         />
       </template>
     </section>
diff --git a/webapp/components/_new/generic/PaginationButtons/PaginationButtons.vue b/webapp/components/_new/generic/PaginationButtons/PaginationButtons.vue
index 0af6dd1cd..c1fe252d6 100644
--- a/webapp/components/_new/generic/PaginationButtons/PaginationButtons.vue
+++ b/webapp/components/_new/generic/PaginationButtons/PaginationButtons.vue
@@ -1,11 +1,11 @@
 <template>
   <div class="pagination-buttons">
     <base-button
-      v-if="hasPrevious"
-      @click="$emit('back')"
+      :disabled="!hasPrevious"
       icon="arrow-left"
       circle
       class="previous-button"
+      @click="$emit('back')"
     />
 
     <span v-if="showPageCounter" class="pagination-pageCount">
@@ -14,11 +14,11 @@
     </span>
 
     <base-button
-      v-if="hasNext"
-      @click="$emit('next')"
+      :disabled="!hasNext"
       icon="arrow-right"
       circle
       class="next-button"
+      @click="$emit('next')"
     />
   </div>
 </template>
diff --git a/webapp/locales/de.json b/webapp/locales/de.json
index fe2293ead..2cc78aca2 100644
--- a/webapp/locales/de.json
+++ b/webapp/locales/de.json
@@ -599,7 +599,8 @@
     "no-results": "Keine Ergebnisse für \"{search}\" gefunden. Versuch' es mit einem anderen Begriff!",
     "page": "Seite",
     "placeholder": "Suchen",
-    "results": "Ergebniss gefunden ::: Ergebnisse gefunden"
+    "results": "Ergebnis gefunden ::: Ergebnisse gefunden",
+    "title": "Suchergebnisse"
   },
   "settings": {
     "blocked-users": {
diff --git a/webapp/locales/en.json b/webapp/locales/en.json
index 16b2cbff3..3aa60b0ab 100644
--- a/webapp/locales/en.json
+++ b/webapp/locales/en.json
@@ -599,7 +599,8 @@
     "no-results": "No results found for \"{search}\". Try a different search term!",
     "page": "Page",
     "placeholder": "Search",
-    "results": "result found ::: results found"
+    "results": "result found ::: results found",
+    "title": "Search Results"
   },
   "settings": {
     "blocked-users": {
diff --git a/webapp/pages/search/search-results.vue b/webapp/pages/search/search-results.vue
index be6cd9d8a..8a8170a16 100644
--- a/webapp/pages/search/search-results.vue
+++ b/webapp/pages/search/search-results.vue
@@ -10,7 +10,7 @@ export default {
   watchQuery: ['search'],
   head() {
     return {
-      title: 'SearchResults',
+      title: this.$t('search.title'),
     }
   },
   components: {