From d4e7e10f8c4c180ca9171405ed47acba161497dc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Wolfgang=20Hu=C3=9F?= Date: Wed, 6 Nov 2019 14:34:24 +0100 Subject: [PATCH] Use of mutation `enable` removed, fix fronend tests - The mutation definition still has to be removed. --- webapp/components/Modal/DisableModal.spec.js | 12 ++++++------ webapp/components/ReleaseModal/ReleaseModal.spec.js | 10 ++++++---- webapp/components/ReleaseModal/ReleaseModal.vue | 8 +++++--- 3 files changed, 17 insertions(+), 13 deletions(-) diff --git a/webapp/components/Modal/DisableModal.spec.js b/webapp/components/Modal/DisableModal.spec.js index b5ebf888c..25e3e9e04 100644 --- a/webapp/components/Modal/DisableModal.spec.js +++ b/webapp/components/Modal/DisableModal.spec.js @@ -29,9 +29,7 @@ describe('DisableModal.vue', () => { $apollo: { mutate: jest .fn() - .mockResolvedValueOnce({ - enable: 'u4711', - }) + .mockResolvedValueOnce() .mockRejectedValue({ message: 'Not Authorised!', }), @@ -162,11 +160,13 @@ describe('DisableModal.vue', () => { expect(mocks.$apollo.mutate).toHaveBeenCalled() }) - it('passes id to mutation', () => { + it('passes parameters to mutation', () => { const calls = mocks.$apollo.mutate.mock.calls const [[{ variables }]] = calls - expect(variables).toEqual({ - id: 'u4711', + expect(variables).toMatchObject({ + resourceId: 'u4711', + disable: true, + closed: false, }) }) diff --git a/webapp/components/ReleaseModal/ReleaseModal.spec.js b/webapp/components/ReleaseModal/ReleaseModal.spec.js index bb7281ab7..a2ff013d8 100644 --- a/webapp/components/ReleaseModal/ReleaseModal.spec.js +++ b/webapp/components/ReleaseModal/ReleaseModal.spec.js @@ -30,7 +30,7 @@ describe('ReleaseModal.vue', () => { $apollo: { mutate: jest .fn() - .mockResolvedValueOnce({ enable: 'u4711' }) + .mockResolvedValueOnce() .mockRejectedValue({ message: 'Not Authorised!' }), }, location: { @@ -157,11 +157,13 @@ describe('ReleaseModal.vue', () => { expect(mocks.$apollo.mutate).toHaveBeenCalled() }) - it('passes id to mutation', () => { + it('passes parameters to mutation', () => { const calls = mocks.$apollo.mutate.mock.calls const [[{ variables }]] = calls - expect(variables).toEqual({ - id: 'u4711', + expect(variables).toMatchObject({ + resourceId: 'u4711', + disable: false, + closed: false, }) }) diff --git a/webapp/components/ReleaseModal/ReleaseModal.vue b/webapp/components/ReleaseModal/ReleaseModal.vue index dace3d665..f098dd2c4 100644 --- a/webapp/components/ReleaseModal/ReleaseModal.vue +++ b/webapp/components/ReleaseModal/ReleaseModal.vue @@ -53,11 +53,13 @@ export default { // await this.modalData.buttons.confirm.callback() await this.$apollo.mutate({ mutation: gql` - mutation($id: ID!) { - enable(id: $id) + mutation($resourceId: ID!, $disable: Boolean, $closed: Boolean) { + decide(resourceId: $resourceId, disable: $disable, closed: $closed) { + disable + } } `, - variables: { id: this.id }, + variables: { resourceId: this.id, disable: false, closed: false }, }) this.$toast.success(this.$t('release.success')) this.isOpen = false