Alina Beck
63d223e368
Apply suggestions from code review
...
Co-Authored-By: Robert Schäfer <git@roschaefer.de>
2019-11-12 18:52:38 +03:00
mattwr18
8b5cd48d3c
Translate success message, guard clause for no Donations
2019-11-12 15:33:21 +01:00
mattwr18
3b5e40efaa
Merge branch 'master' of github.com:Human-Connection/Human-Connection into donation-info
2019-11-12 15:18:10 +01:00
Alina Beck
982a02fc4f
query donations data in donation info component
2019-11-12 14:24:46 +03:00
Alexander Friedland
8bb8bb220d
Merge pull request #2193 from Human-Connection/Delete_BlockButton_in_MainPage_PostCard
...
Fix: Delete Block Button in MainPage PostCards
2019-11-12 11:18:42 +01:00
Mo Zargham
34fb529147
console.error in Hashtag.spec.js #2161
2019-11-11 18:15:26 -05:00
Moriz Wahl
e46a23d445
css hyphens for webkit and moz
2019-11-11 23:01:03 +01:00
Moriz Wahl
d0c0fd373a
Language attribute added to post and postCard
2019-11-11 22:42:37 +01:00
mattwr18
7d95809f6e
Update test to ensure currency is shown by locale
2019-11-11 19:15:39 +01:00
Wolfgang Huß
677039b786
Merge branch 'master' of github.com:Human-Connection/Human-Connection into 1710-list-and-protocol-moderation
...
# Conflicts:
# webapp/pages/moderation/index.vue
2019-11-11 17:52:58 +01:00
Alina Beck
ffb3ff896e
add tests for DonationInfo component (wip)
2019-11-11 17:36:04 +03:00
Wolfgang Huß
4e49dfe9e1
Add a confirm modal.
2019-11-11 14:53:19 +01:00
Alina Beck
61cb7dd7c2
add ProgressBar tests
2019-11-11 16:28:39 +03:00
Alina Beck
d15a1a8105
style donations info for mobile
2019-11-11 15:57:29 +03:00
ogerly
47720e3ce0
Fix: Delete Block Button
2019-11-11 12:16:11 +01:00
Alina Beck
f6de44b337
place donation info in separate component
...
compute title and label according to selected locale and donation values
2019-11-11 13:09:51 +03:00
Alina Beck
768f5f6631
extract progress bar into separate component
2019-11-11 12:31:10 +03:00
mattwr18
288787bcb9
Remove deprecated slot syntax
...
- Update slot to use syntax supported after Vue 2.6
2019-11-11 08:52:51 +01:00
mattwr18
57b0a339c6
Avoid negative margins/targeting tags
...
- follow @alina-beck's PR suggestions
2019-11-11 08:52:51 +01:00
mattwr18
64e2a2a7c2
Add story for Paginate component
2019-11-11 08:52:51 +01:00
mattwr18
7d0b9861b8
Add story for AvatarMenu
2019-11-11 08:52:51 +01:00
mattwr18
49f73976b7
Fix DropdownFilter story after refactor
...
- it was refactored to make reuse easier
2019-11-11 08:52:04 +01:00
mattwr18
d56c81dc3d
Add test for NotificationsTable and refactor
2019-11-11 08:52:04 +01:00
mattwr18
09e4c20bb8
Update test to findIndex instead of hard coding
...
Co-authored-by: Mike Aono <aonomike@gmail.com>
2019-11-11 08:52:04 +01:00
mattwr18
b7e39ca3db
Add test for DropdownComponent
2019-11-11 08:52:04 +01:00
mattwr18
088d4a8ae5
Use verbose variables
2019-11-11 08:52:04 +01:00
mattwr18
ddb9fcdcb7
Make dropdown filter reusable
2019-11-11 08:52:04 +01:00
roschaefer
25c9b9585b
Translate dropdown values on notification page
...
@mattwr18 this solves the problem by 50%. If you switch the language and
click on the notifications dropdown filter, you will see the translated
labels. However, the label showing the selected value will not change,
probably because `<ds-menu>` caches the selected option 😞 .
2019-11-11 08:52:04 +01:00
roschaefer
8e129c6001
fix: update counter when notification is read
...
@mattwr18 vue-apollo rocks! Taking the time to study the docs is a
rewarding investment.
My first idea was to cache the `unreadNotificationsCount` with Vuex.
But the docs of apollo even suggest to use apollo's local state as a
complete replacement of Vuex:
https://vue-apollo.netlify.com/guide/local-state.html
Then I further investigated why the updated `NOTIFIED` objects won't
update the notification counter. Turns out: They don't have an ID and
the computed property didn't fire when the notifications array would
change. I fixed both in this commit and yes, it works as expected.
No additional code required 💪
2019-11-11 08:52:04 +01:00
roschaefer
8ca2445a25
Fix data of NotificationsTable.story.js
...
@mattwr18 probably you wanted to override the `author` of the
comment/post, right? If you use the { ... desctructuring } operator,
whatever comes last takes precedence. So you probaby want to put your
override last?
2019-11-11 08:52:04 +01:00
mattwr18
6fca753c1f
Add component test for Empty.vue
2019-11-11 08:52:04 +01:00
mattwr18
1d8e328a47
Clean up
...
- remove unused data variable
- avoid scoped scss
2019-11-11 08:52:04 +01:00
mattwr18
7564908456
Refactor to follow @alina-beck suggestions
...
- Update CSS
- Use design tokens where possible
- Update spec description
- Avoid scoped scss as it's more expensive
- did not change the next and back button as they weren't really visible
without the primary class
- Fix German translation
2019-11-11 08:52:04 +01:00
mattwr18
44ed462db2
Add NotificationsTable story, refactor code
...
- Use percentages for width on all columns to help with resonsiveness
- export constants from other stories to dry code out
2019-11-11 08:52:04 +01:00
mattwr18
542647f418
Add NotificationsDropdownFilter story, refactor
...
- rename incorrectly named varaibles
- use filterOptions to remove unneccessary computed routes
Co-authored-by: @alina-beck
2019-11-11 08:52:04 +01:00
mattwr18
3ae71544d6
Add story for Empty component
...
Co-authored-by: @alina-beck
2019-11-11 08:52:04 +01:00
mattwr18
aabaa2e637
Fix typo
...
Co-authored-by: Alina Beck <alina.beck@mail.com>
2019-11-11 08:50:35 +01:00
mattwr18
cb2cc37556
Extract components following @alina-beck suggestion
...
- see https://github.com/Human-Connection/Human-Connection/pull/2075/files
2019-11-11 08:50:35 +01:00
mattwr18
7007b1c444
Paginate notifications, reusable component w/ test
2019-11-11 08:50:35 +01:00
mattwr18
084388a21e
Follow new file structure
...
- avoid nested directories
2019-11-11 08:50:35 +01:00
mattwr18
4448c12f2e
Add componenet test for AvatarMenu
...
Co-authored-by: mindcodemediator
<mindcodemediator@users.noreply.github.com>
Co-authored-by: Mike Aono <aonomike@gmail.com>
2019-11-11 08:50:35 +01:00
mattwr18
d83a424513
Add styling
...
- to link in NotificationMenu
- make table more mobile responsive
- remove unneccessary props
Co-authored-by: Alina Beck <alina.beck@mail.com>
2019-11-11 08:50:35 +01:00
mattwr18
994a0b049d
Extract AvatarMenu into its own component
2019-11-11 08:50:35 +01:00
mattwr18
58b1f7948c
Follow @alina-beck and @Tirokk suggestions
...
- following PR reviews
2019-11-11 08:50:35 +01:00
mattwr18
e8cf51095a
Add back missing translation
2019-11-11 08:50:35 +01:00
mattwr18
cf8124fb2d
Clean up/add german translations
2019-11-11 08:50:35 +01:00
mattwr18
b79770469f
Update notifications page
...
- display more notifications by simplifying the table
- get sorting working
2019-11-11 08:50:35 +01:00
mattwr18
7cdc12f4b9
Add notifications page with Notifications in table
...
- At the moment, the notifications are displayed in a table, and have
the same functionality as the NotificationMenu where you can click on
the title of the Post and visit the Post
- Unsure about the styling, it would kind of be nice to have a more
condensed list to see more notifications per page, but still be able to
click on a row and visit the Post
2019-11-11 08:50:35 +01:00
roschaefer
6c947f782d
Fix CSS classes
2019-11-08 17:30:05 +01:00
roschaefer
4108bb7d71
Merge remote-tracking branch 'origin/2119_Create_Post_consistent_form_input_validation' into 2119_Create_Post_consistent_form_input_validation-improvements
2019-11-08 16:32:16 +01:00